privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Fix icons looking out of place on smaller screens #1102

Merged
dawidpotocki merged 1 commits from iconsalign into master 2019-08-06 23:23:22 +00:00
Conversation 6 Commits 1 Files Changed 1 +34 -66
dawidpotocki commented 2019-08-05 22:18:47 +00:00 (Migrated from github.com)
Copy Link

Fixes #905

sm or smaller screen

2019-08-06_1565042766

md or bigger screen, but too many icons

don't worry, 2 firefox icons are not in the commit

2019-08-06_1565042730

md or bigger screen

2019-08-06_1565042790

Fixes #905 ### sm or smaller screen ![2019-08-06_1565042766](https://user-images.githubusercontent.com/38681822/62498321-4fb63d00-b7ce-11e9-9acf-5a434b73cd37.png) ### md or bigger screen, but too many icons don't worry, 2 firefox icons are not in the commit ![2019-08-06_1565042730](https://user-images.githubusercontent.com/38681822/62498319-4e851000-b7ce-11e9-9fb5-557e2e8564c9.png) ### md or bigger screen ![2019-08-06_1565042790](https://user-images.githubusercontent.com/38681822/62498324-50e76a00-b7ce-11e9-97fe-dc3c64701dfb.png)
netlify[bot] commented 2019-08-05 22:19:33 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 1db4cdd2de

https://deploy-preview-1102--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 1db4cdd2de8fc3e558ac8588e0063854bacb89bf https://deploy-preview-1102--privacytools-io.netlify.com
jonah commented 2019-08-06 00:24:46 +00:00
Copy Link

For some reason I'm not seeing the same "too many icons" view on my browser, I'm only seeing 6 icons on the top row, instead of 7, which affects many more listings.

image
For some reason I'm not seeing the same "too many icons" view on my browser, I'm only seeing 6 icons on the top row, instead of 7, which affects many more listings. <img width="777" alt="image" src="https://user-images.githubusercontent.com/3637842/62502695-65b80380-b7b6-11e9-8376-ffe8fb2961c0.png">
dawidpotocki commented 2019-08-06 03:41:32 +00:00 (Migrated from github.com)
Copy Link

I was able to reproduce it on 90% zoom. It should be fixed now.

I was able to reproduce it on 90% zoom. It should be fixed now.
jonah commented 2019-08-06 05:29:54 +00:00
Copy Link

Still happening to me at any zoom level :/

image
Still happening to me at any zoom level :/ <img width="1220" alt="image" src="https://user-images.githubusercontent.com/3637842/62513328-484c5f00-b7e1-11e9-9653-22033f0e6df2.png">
dawidpotocki commented 2019-08-06 08:58:10 +00:00 (Migrated from github.com)
Copy Link

🙄

🙄
jonah approved these changes 2019-08-06 23:23:10 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1102
Delete Branch "iconsalign"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?