🌐 Website Issue | Icons out of place on mobile devices #905

New Issue

jonah · 2019-05-05T05:54:17Z

privacytoolsIO commented

2019-05-05 05:54:17 +00:00

(Migrated from github.com)

Description

Icons look out of place currently on mobile devices.

Screenshots

Looks neat:

Does not look neat at all:

## Description Icons look out of place currently on mobile devices. ## Screenshots Looks neat: ![good](https://user-images.githubusercontent.com/11730911/57189124-15be6c00-6f3d-11e9-8b39-2c09a7b0b1cd.jpg) Does not look neat at all: ![bad](https://user-images.githubusercontent.com/11730911/57189134-2373f180-6f3d-11e9-9ebd-19bcc6662291.jpg)

Mikaela commented

2019-05-05 08:05:59 +00:00

(Migrated from github.com)

I have no idea how would I start fixing this, so I am unassigning myself and setting "help wanted" label.

ghost commented

2019-05-05 11:51:09 +00:00

(Migrated from github.com)

I'm not that good with BS4 but basically we want the buttons and the icons to be in the same div (maybe .row or .col-12) and put the buttons and the icons in separate divs, something like div.col-md-6. And also make the icons section right aligned (ideally with flexbox) but center aligned (.justify-content-center) when the div "collapses" (when size is < md).

Currently the icons are right-aligned using .float-right. I think we should avoid floats as much as possible and use the BS4 grid instead.

Perhaps @Vincevrp or @JonahAragon could be able to implement this (assuming you're not busy)?

I'm not that good with BS4 but basically we want the buttons and the icons to be in the same div (maybe .row or .col-12) and put the buttons and the icons in separate divs, something like div.col-md-6. And also make the icons section right aligned (ideally with flexbox) but center aligned (.justify-content-center) when the div "collapses" (when size is < md). Currently the icons are right-aligned using `.float-right`. I think we should avoid floats as much as possible and use the BS4 grid instead. Perhaps @Vincevrp or @JonahAragon could be able to implement this (assuming you're not busy)?

👍 2

jonah commented

2019-05-05 14:37:30 +00:00

They should probably be left aligned on mobile, not centered. I’ll see if I have time to take a look later if nobody else figures it out, but I’m sure there’s some way to do that that’s built-in to BS4.

Definitely need to switch to the grid system if that isn’t what we’re currently using anymore.

They should probably be left aligned on mobile, not centered. I’ll see if I have time to take a look later if nobody else figures it out, but I’m sure there’s some way to do that that’s built-in to BS4. Definitely need to switch to the grid system if that isn’t what we’re currently using anymore.

privacytoolsIO commented

2019-08-17 03:14:57 +00:00

(Migrated from github.com)

thanks for fixing this @dawidpotocki

This repo is archived. You cannot comment on issues.