Update CONTRIBUTING.md #1445

Merged
jonah merged 2 commits from contributing into master 2019-11-04 12:25:25 +00:00
Owner

Description

Resolves: #1432

Check List

<!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #1432 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).
netlify[bot] commented 2019-10-30 03:31:02 +00:00 (Migrated from github.com)
Author
Owner

Deploy preview for privacytools-io ready!

Built with commit e27d70387f

https://deploy-preview-1445--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit e27d70387fb892abe6ed3e60f395e45ecb0749d1 https://deploy-preview-1445--privacytools-io.netlify.com
dawidpotocki commented 2019-10-30 03:39:02 +00:00 (Migrated from github.com)
Author
Owner
Rendered: https://github.com/privacytoolsIO/privacytools.io/blob/ab4ea72ce722591402ae65a0dbba6d73c3476d63/.github/CONTRIBUTING.md
dawidpotocki (Migrated from github.com) reviewed 2019-10-30 03:40:03 +00:00
Mikaela (Migrated from github.com) reviewed 2019-10-30 07:06:00 +00:00
Mikaela (Migrated from github.com) left a comment
Author
Owner

I am assuming that you have checked the rendering works.

Is there a possibility of replying to old messages like emailing privacytools+1445 or having #1445 in the title?

I am assuming that you have checked the rendering works. Is there a possibility of replying to old messages like emailing `privacytools+1445` or having `#1445` in the title?
djoate (Migrated from github.com) requested changes 2019-10-30 07:37:21 +00:00
djoate (Migrated from github.com) left a comment
Author
Owner

While we're at it, we should also fix some of the links. These links are dead links:

While we're at it, we should also fix some of the links. These links are dead links: - **Rules**: [Code of Conduct](https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) - The two examples under **Images**
Author
Owner

Good catch @djoate, replaced with some images that are far less likely to disappear.

Is there a possibility of replying to old messages like emailing privacytools+1445 or having #1445 in the title?

I don't know, but don't think so?

Good catch @djoate, replaced with some images that are far less likely to disappear. > Is there a possibility of replying to old messages like emailing privacytools+1445 or having #1445 in the title? I don't know, but don't think so?
nitrohorse (Migrated from github.com) approved these changes 2019-10-31 16:33:45 +00:00
Mikaela (Migrated from github.com) approved these changes 2019-11-04 12:24:07 +00:00
Mikaela (Migrated from github.com) left a comment
Author
Owner

LGTM 👍

I thought this was merged already though

LGTM :+1: I thought this was merged already though
This repo is archived. You cannot comment on pull requests.
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1445
No description provided.