privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

.travis.yml & build.sh: add html5validator & profiling #900

Closed
Mikaela wants to merge 2 commits from travis into master
pull from: travis
merge into: privacyguides:master
Conversation 5 Commits 2 Files Changed 2 +16 -2
Mikaela commented 2019-05-04 11:56:42 +00:00 (Migrated from github.com)
Copy Link

Enable html5validator and jekyll profiling.

We aren't valid HTML5 currently. I blacklisted classic, because I think it's taking errors that aren't errors on the new site and I am in belief that it's not cared about that much.

Enable html5validator and jekyll profiling. We aren't valid HTML5 currently. I blacklisted classic, because I think it's taking errors that aren't errors on the new site and I am in belief that it's not cared about that much.
netlify[bot] commented 2019-05-04 11:57:21 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 72a6a4a979

https://deploy-preview-900--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 72a6a4a979aef8f11754c5684d6bf9da511638d1 https://deploy-preview-900--privacytools-io.netlify.com
jonah commented 2019-05-04 16:00:09 +00:00
Copy Link

I'm not sure how travis works.

I'm not sure how travis works.
Mikaela commented 2019-05-15 08:13:29 +00:00 (Migrated from github.com)
Copy Link

@Shifterovich ping? :)

@Shifterovich ping? :)
nitrohorse (Migrated from github.com) requested changes 2019-07-21 00:17:47 +00:00
nitrohorse (Migrated from github.com) left a comment

Based on the Travis build log, it looks like your commit for adding html5validator is actually working fine which is great and thus fails because of these existing validation errors.

I think before approving, we should update this PR to include fixes for these errors. That way we set a new baseline of validated HTML, the build will pass, and then subsequent PRs will get validation error checking based solely on the author's changes.

Based on the [Travis build log](https://travis-ci.com/privacytoolsIO/privacytools.io/builds/110611519), it looks like your commit for adding html5validator is actually working fine which is great and thus fails because of [these existing validation errors](https://bin.disroot.org/?497f72958cd96134#Ybm13xgJJPwGLhVDEkt4z3ux5zYTBkLQlDXRqparuSg=). I think before approving, we should update this PR to include fixes for these errors. That way we set a new baseline of validated HTML, the build will pass, and then subsequent PRs will get validation error checking based solely on the author's changes.
nitrohorse commented 2019-08-17 04:16:02 +00:00 (Migrated from github.com)
Copy Link

I think we can close and fold this into https://github.com/privacytoolsIO/privacytools.io/issues/1093.

I think we can close and fold this into https://github.com/privacytoolsIO/privacytools.io/issues/1093.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
nitrohorse
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
🏠 housekeeping
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#900
No description provided.
Delete Branch "travis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?