privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

.travis.yml & build.sh: add html5validator & profiling #900

Closed
Mikaela wants to merge 2 commits from travis into master
pull from: travis
merge into: :master
Conversation 5 Commits 2 Files Changed 2
+16 -2
Mikaela commented 2019-05-04 11:56:42 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Enable html5validator and jekyll profiling.

We aren't valid HTML5 currently. I blacklisted classic, because I think it's taking errors that aren't errors on the new site and I am in belief that it's not cared about that much.

Enable html5validator and jekyll profiling. We aren't valid HTML5 currently. I blacklisted classic, because I think it's taking errors that aren't errors on the new site and I am in belief that it's not cared about that much.
netlify[bot] commented 2019-05-04 11:57:21 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Deploy preview for privacytools-io ready!

Built with commit 72a6a4a979

https://deploy-preview-900--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 72a6a4a979aef8f11754c5684d6bf9da511638d1 https://deploy-preview-900--privacytools-io.netlify.com
jonah commented 2019-05-04 16:00:09 +00:00
Copy Link
Copy Source

I'm not sure how travis works.

I'm not sure how travis works.
Mikaela commented 2019-05-15 08:13:29 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@Shifterovich ping? :)

@Shifterovich ping? :)
nitrohorse (Migrated from github.com) requested changes 2019-07-21 00:17:47 +00:00
nitrohorse (Migrated from github.com) left a comment

Based on the Travis build log, it looks like your commit for adding html5validator is actually working fine which is great and thus fails because of these existing validation errors.

I think before approving, we should update this PR to include fixes for these errors. That way we set a new baseline of validated HTML, the build will pass, and then subsequent PRs will get validation error checking based solely on the author's changes.

Based on the [Travis build log](https://travis-ci.com/privacytoolsIO/privacytools.io/builds/110611519), it looks like your commit for adding html5validator is actually working fine which is great and thus fails because of [these existing validation errors](https://bin.disroot.org/?497f72958cd96134#Ybm13xgJJPwGLhVDEkt4z3ux5zYTBkLQlDXRqparuSg=). I think before approving, we should update this PR to include fixes for these errors. That way we set a new baseline of validated HTML, the build will pass, and then subsequent PRs will get validation error checking based solely on the author's changes.
nitrohorse commented 2019-08-17 04:16:02 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I think we can close and fold this into https://github.com/privacytoolsIO/privacytools.io/issues/1093.

I think we can close and fold this into https://github.com/privacytoolsIO/privacytools.io/issues/1093.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
nitrohorse
Labels
Clear labels
:mag:🤖 Search Engines
I2P
The Invisible Internet Project (I2P)
 OS
Operating Systems
 Self-contained networks
Social media
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
iOS
low priority
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
🆕 software suggestion
🆘 critical
🇦🇶 translations
Anything covering a translated version of the site
 🌐 Social News Aggregators
🌐 hosting
🌐 website issue
*Technical* issues with the website.
 🏠 housekeeping
Anything primarily related to site cleanup.
 🐛 bug
👁️ browsers
👥 team chat
💢 conflicting
💬 discussion
💻 hardware
📁 file storage
📝 correction
Correction of content on the website
 📧 email
🔎 research required
🔐 password managers
🔒 VPN
Virtual Private Network
 🔒 file encryption
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🚫 Windows
🤖 Android
🦊 Firefox
Firefox & forks, about:config etc.
 🧰 productivity tools
No labels 🏠 housekeeping
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#900