privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add QR Codes #851

Merged
privacytoolsIO merged 6 commits from QR into master 2019-04-11 00:25:20 +00:00
Conversation 5 Commits 6 Files Changed 8 +7 -7
privacytoolsIO commented 2019-04-10 23:31:47 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: #none

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> <!-- ## Screenshots Please add screenshots if applicable -->
netlify[bot] commented 2019-04-10 23:32:20 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 7a199c5359

https://deploy-preview-851--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 7a199c5359ab6fde8e40375cb35bf16fecafe3c2 https://deploy-preview-851--privacytools-io.netlify.com
jonah reviewed 2019-04-10 23:35:57 +00:00
donate.html
@ -17,49 +17,49 @@ permalink: /donate/
<div class="col-md-12 col-lg-8 offset-lg-2 text-right">
jonah commented 2019-04-10 23:35:57 +00:00

If you move this icon to after the label, like Bitcoin (BTC) [qr icon] I think that'd look good.

If you move this icon to after the label, like `Bitcoin (BTC) [qr icon]` I think that'd look good.
jonah reviewed 2019-04-10 23:55:55 +00:00
donate.html
jonah commented 2019-04-10 23:55:54 +00:00 
        <label for="BTC" class="col-sm-4 col-form-label"><strong>Bitcoin (BTC)</strong> <a href="/assets/img/qr/BTC.png"><i class="fa fa-qrcode"></i></a></label>

image

```suggestion <label for="BTC" class="col-sm-4 col-form-label"><strong>Bitcoin (BTC)</strong> <a href="/assets/img/qr/BTC.png"><i class="fa fa-qrcode"></i></a></label> ``` ![image](https://user-images.githubusercontent.com/3637842/55921414-3f94a500-5bc2-11e9-978d-7900e4152af9.png)
jonah approved these changes 2019-04-11 00:24:52 +00:00
jonah left a comment

uhhh... LGTM. Not gonna bother checking those QR codes so I hope they go to the addresses and not some random off-shore account where the coins will never be seen from again 🤔

uhhh... LGTM. Not gonna bother checking those QR codes so I hope they go to the addresses and not some random off-shore account where the coins will never be seen from again 🤔
privacytoolsIO commented 2019-04-11 00:25:45 +00:00 (Migrated from github.com)
Copy Link

lol

lol
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#851
No description provided.
Delete Branch "QR"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?