Replace broken link #651

Merged
Booteille merged 1 commits from patch-2 into master 2019-02-28 22:41:55 +00:00
Booteille commented 2018-12-07 19:17:29 +00:00 (Migrated from github.com)

Replace broken link for Block Cloudflare MITM Attack Addon

Description

Resolves: #442

Replace broken link for Block Cloudflare MITM Attack Addon <!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #442 <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> <!-- ## Screenshots Please add screenshots if applicable -->
jonah reviewed 2018-12-08 00:21:14 +00:00
Vincevrp commented 2018-12-08 12:47:05 +00:00 (Migrated from github.com)

Can someone confirm that this is still the same extension? I can't seem to find the source.

Can someone confirm that this is still the same extension? I can't seem to find the source.
ghost commented 2018-12-08 13:37:30 +00:00 (Migrated from github.com)

I was thinking the same, hence the review request.

I was thinking the same, hence the review request.
Vincevrp (Migrated from github.com) requested changes 2018-12-12 12:14:50 +00:00
Vincevrp (Migrated from github.com) left a comment

Could you please provide a link to the source?

Could you please provide a link to the source?
ghost commented 2019-02-23 10:29:14 +00:00 (Migrated from github.com)

Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately.

@Vincevrp do you have time to look into it?

Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately. @Vincevrp do you have time to look into it?
Vincevrp commented 2019-02-24 19:24:30 +00:00 (Migrated from github.com)

There's no reference to the source code from the link provided in the PR, nor vise versa. The addon only has some Russian text on the page, which makes it a bit sketchy.

Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately.

@Vincevrp do you have time to look into it?

Same, sorry.

There's no reference to the source code from the link provided in the PR, nor vise versa. The addon only has some Russian text on the page, which makes it a bit sketchy. > Sorry, I saw the email but didn't have time to read it and I forgot about it. I'm busy with personal projects lately. > > @Vincevrp do you have time to look into it? Same, sorry.
Vincevrp commented 2019-02-28 22:41:20 +00:00 (Migrated from github.com)

So I received another email about this. I've changed the link to the project instead of the AMO page because:

Quote from the email:

Our collaborator who have access to AMO gone AWOL

Also

P.S Say hi to @Booteille for us as we cannot deal with GitHub.

So I received another email about this. I've changed the link to the project instead of the AMO page because: Quote from the email: > Our collaborator who have access to AMO gone AWOL Also > P.S Say hi to @Booteille for us as we cannot deal with GitHub.
Vincevrp (Migrated from github.com) approved these changes 2019-02-28 22:41:46 +00:00
Booteille commented 2019-03-01 08:33:58 +00:00 (Migrated from github.com)

Thanks for your investigation, all of you!

Thanks for your investigation, all of you!
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#651
No description provided.