Move nav to an include #607

2018-11-22T00:05:32Z

Vincevrp commented

2018-11-22 00:05:32 +00:00

(Migrated from github.com)

Description

Resolves: #600

Move nav to an include so it doesn't show on other pages. Also includes some formatting.

Warning: might conflict with #602 when merging.

## Description Resolves: #600 Move nav to an include so it doesn't show on other pages. Also includes some formatting. Warning: might conflict with #602 when merging.

ghost commented

2018-11-22 05:46:14 +00:00

(Migrated from github.com)

On what pages? I put it in the layout so that it's also on the donate page.

Vincevrp commented

2018-11-22 13:47:59 +00:00

(Migrated from github.com)

404 and donate page. It doesn't make sense to have the navbar over there because none of the links will work.

ghost commented

2018-11-22 13:49:47 +00:00

(Migrated from github.com)

I will fix the links.

Vincevrp commented

2018-11-22 13:51:09 +00:00

(Migrated from github.com)

I also prefer the look of the other pages without the navigation bar, it looks out of place.

ghost commented

2018-11-22 14:26:41 +00:00

(Migrated from github.com)

You can go from index to donate using the navbar, so it should work the other way as well.

ghost commented

2018-11-22 15:35:27 +00:00

(Migrated from github.com)

Move nav to an include so it doesn't show on other pages. Also includes some formatting.

It now does work on other pages. What formatting changes have you made?

> Move nav to an include so it doesn't show on other pages. Also includes some formatting. It now does work on other pages. What formatting changes have you made?

Vincevrp commented

2018-11-22 17:25:14 +00:00

(Migrated from github.com)

Move nav to an include so it doesn't show on other pages. Also includes some formatting.

It now does work on other pages. What formatting changes have you made?

Formatting of the code, indentation etc.

> > Move nav to an include so it doesn't show on other pages. Also includes some formatting. > > It now does work on other pages. What formatting changes have you made? Formatting of the code, indentation etc.

ghost commented

2018-11-22 17:30:44 +00:00

(Migrated from github.com)

Oh ok. If you want you can add this to the default.html template. Just don't delete what's there and put the reformatted code there, because I added new functionality. I'm closing this as the navbar does work on other pages now.

This repo is archived. You cannot comment on pull requests.

No reviewers