Introduce flag-icon-css and display select country flags #53

2016-05-15T07:23:44Z

MitchellCash commented

2016-05-15 07:23:44 +00:00

(Migrated from github.com)

![](https://dl.dropboxusercontent.com/u/37902134/GitHub/privacytoolsIO%3Aprivacytools-io/%2352_0.png)

bookercodes commented

2016-05-16 07:38:58 +00:00

(Migrated from github.com)

I think this is a nice addition.

👍 for using SVG images but can you please put them in the img folder and remove the ones we don't reference? Also, can you please link the source of the flags that I can check the licence.

Thanks 😄

I think this is a nice addition. :+1: for using SVG images but can you please put them in the `img` folder and remove the ones we don't reference? Also, can you please link the source of the flags that I can check the licence. Thanks :smile:

MitchellCash commented

2016-05-16 08:38:54 +00:00

(Migrated from github.com)

I can do.

With removing the ones we don't reference, I left them all there in case there were other parts of the project that could use them. What do you think?

It's an MIT licence. I'm no expert but I think it means we are safe to use?

https://github.com/lipis/flag-icon-css/blob/master/LICENSE

I can do. With removing the ones we don't reference, I left them all there in case there were other parts of the project that could use them. What do you think? It's an MIT licence. I'm no expert but I think it means we are safe to use? https://github.com/lipis/flag-icon-css/blob/master/LICENSE

bookercodes commented

2016-05-16 09:12:30 +00:00

(Migrated from github.com)

With removing the ones we don't reference, I left them all there in case there were other parts of the project that could use them. What do you think?

My concern is that there are 500 icons which require 6mb. We use just 14 😱

... It's a bit too unwieldy (relatively speaking) in terms of 1, deployment and 2, managing the Git repository.

Adding new flags in the future shouldn't be too much bother.

> With removing the ones we don't reference, I left them all there in case there were other parts of the project that could use them. What do you think? My concern is that there are **500** icons which require 6mb. We use just 14 :scream: ... It's a bit too unwieldy (relatively speaking) in terms of **1,** deployment and **2,** managing the Git repository. Adding new flags in the future shouldn't be too much bother.

MitchellCash commented

2016-05-16 09:13:35 +00:00

(Migrated from github.com)

Okay, agreed. Let me fix this commit

MitchellCash commented

2016-05-16 09:24:49 +00:00

(Migrated from github.com)

@alexbooker updated and squashed commit, can you please review?

bookercodes commented

2016-05-16 09:46:50 +00:00

(Migrated from github.com)

More awesome work 🔥. Thanks!
Merged 😄!