For Issue #381 Update VPN Price #382

2017-12-26T22:50:56Z

Eduardo06sp commented

2017-12-26 22:50:56 +00:00

(Migrated from github.com)

Description

Issue #381
IVPN price changed to $100

HTML Preview

Replace [GITHUB_USERNAME] with your GitHub username and [BRANCH] with the branch name.

http://htmlpreview.github.io/?https://github.com/Eduardo06sp/privacytools.io/blob/patch-1/index.html

### Description Issue #381 IVPN price changed to $100 ### HTML Preview *Replace [GITHUB_USERNAME] with your GitHub username and [BRANCH] with the branch name.* http://htmlpreview.github.io/?https://github.com/Eduardo06sp/privacytools.io/blob/patch-1/index.html

yassineim commented

2017-12-27 20:41:35 +00:00

(Migrated from github.com)

Thank you

👍 1

Eduardo06sp commented

2017-12-28 07:04:57 +00:00

(Migrated from github.com)

No problem! Baby steps first!

kewde commented

2017-12-30 15:43:58 +00:00

(Migrated from github.com)

The data values for the VPNs are wrong, they should correspond with the actual values such that the sorting works properly. This is not your fault, but your PR made me took notice to it.
There is also a sporadic usage of EUR & USD which complicates the matter. The USD/EUR conversion rate fluctuates so it won't be accurate at every moment but w/e.

The data values for the VPNs are wrong, they should correspond with the actual values such that the sorting works properly. This is not your fault, but your PR made me took notice to it. There is also a sporadic usage of EUR & USD which complicates the matter. The USD/EUR conversion rate fluctuates so it won't be accurate at every moment but w/e.

kewde commented

2017-12-30 15:44:44 +00:00

(Migrated from github.com)

I don't think anything critical has changed, so I'll merge this over the weekend.

This repo is archived. You cannot comment on pull requests.

No reviewers