Switch Red/Green in KDL section #334

2017-09-08T08:59:56Z

shifterovich2 commented

2017-09-08 08:59:56 +00:00

(Migrated from github.com)

Description

Don't merge until the design is resolved.

Resolves #333

Not sure whether I like it more now. Maybe use the same layout as #ukusa?

HTML Preview

http://htmlpreview.github.io/?https://github.com/shifterovich2/privacytools.io/blob/switch-red-green-kdl/index.html

### Description **Don't merge until the design is resolved.** Resolves #333 Not sure whether I like it more now. Maybe use the same layout as #ukusa? ### HTML Preview http://htmlpreview.github.io/?https://github.com/shifterovich2/privacytools.io/blob/switch-red-green-kdl/index.html

kewde commented

2017-09-12 15:15:26 +00:00

(Migrated from github.com)

@Shifterovich
Is @shifterovich2 an account that you own?

@Shifterovich Is @shifterovich2 an account that you own?

kewde commented

2017-09-12 15:20:31 +00:00

(Migrated from github.com)

Special key disclosure laws exist for Belgian citizens. I've moved it to the right section.

ghost commented

2017-09-12 18:10:25 +00:00

(Migrated from github.com)

Yes, it's the account I use on public/school computers.

shifterovich2 commented

2017-09-19 12:38:49 +00:00

(Migrated from github.com)

@kewde What do you think about the layout? Use the same as #ukusa or keep it like this?

ghost commented

2017-10-07 19:40:22 +00:00

(Migrated from github.com)

@hugoncosta Your opinion on the layout?

hugoncosta commented

2017-10-08 11:41:38 +00:00

(Migrated from github.com)

The preview says it cannot load, could you give me another link?

ghost commented

2017-10-08 15:58:07 +00:00

(Migrated from github.com)

Right, I apparently deleted the branch. I'll update the link once I have time to upload the files to my website.

hugoncosta commented

2017-10-09 18:36:53 +00:00

(Migrated from github.com)

btw I was thinking, I don't believe we should change the layout. We use this on the number eyes section too, and we have the worst offenders first. I believe that the current layout should stay, since both KDL and #Eyes are warnings and not necessarily tools/advices. Our philosophy of putting the "best" option with a green box and to the left should remain, by putting the "worst" offenders (in this case) to the left and in a red box.

ghost commented

2017-10-12 15:40:31 +00:00

(Migrated from github.com)

@kewde?

kewde commented

2017-10-16 16:25:29 +00:00

(Migrated from github.com)

@Shifterovich the link is dead so I can't see it anymore. Can you snap a pic of it?

👍 1

ghost commented

2017-11-17 22:52:45 +00:00

(Migrated from github.com)

89ce79e463/index.html (kdl)

https://htmlpreview.github.io/?https://raw.githubusercontent.com/privacytoolsIO/privacytools.io/89ce79e4637bc8349f091bbc5e538feafbb1384e/index.html#kdl

hugoncosta commented

2017-11-18 09:58:11 +00:00

(Migrated from github.com)

I'm still not conviced. I believe that the panel on the left should be the most important - either the "stay away" or "you should really use this". If we change the KDL from "Good" to "Bad", we should also change the Global Mass Surveillance and put the Fourteen Eyes first (switch like in here).

ghost commented

2017-11-18 10:15:11 +00:00

(Migrated from github.com)

Agree, I think I liked it better before aesthetically as well. Just wanted to know what you think. @kewde @beardog108 what do you think? Merge or close?

kewde commented

2017-11-26 15:47:25 +00:00

(Migrated from github.com)

I don't really care about this change, it's just moving boxes 📦 and the order of (worst -> best or best -> worst) is clear here.

I don't really care about this change, it's just moving boxes :package: and the order of (worst -> best or best -> worst) is clear here.

This repo is archived. You cannot comment on pull requests.

No reviewers