Add net neutrality widget #262

2017-07-10T20:14:51Z

ghost commented

2017-07-10 20:14:51 +00:00

(Migrated from github.com)

Description

Feel free to suggest any changes.

DON'T MERGE

HTML Preview

http://theprivacyguide.org/ptio/index.html#ALWAYS_SHOW_BFTN_WIDGET (htmlpreview.github.io wouldn't work due to iframes, so I used a domain I own to host the preview)

Once this PR is merged, I'll create a "revert" PR.

### Description Feel free to suggest any changes. # DON'T MERGE ### HTML Preview http://theprivacyguide.org/ptio/index.html#ALWAYS_SHOW_BFTN_WIDGET (htmlpreview.github.io wouldn't work due to iframes, so I used a domain I own to host the preview) ### Once this PR is merged, I'll create a "revert" PR.

kewde commented

2017-07-11 15:38:30 +00:00

(Migrated from github.com)

You can easily revert this with the button above^

Looking at the JS code now

You can easily revert this with the button above^ Looking at the JS code now

ghost commented

2017-07-11 15:39:34 +00:00

(Migrated from github.com)

Button above creates a PR. #264

kewde (Migrated from github.com) reviewed

2017-07-11 15:40:23 +00:00

kewde (Migrated from github.com) left a comment

Seems OK.

kewde commented

2017-07-11 15:41:16 +00:00

(Migrated from github.com)

It does set a cookie that expires in 365 days

ghost commented

2017-07-11 15:44:44 +00:00

(Migrated from github.com)

I managed to replace all the external resources, but didn't want to touch the JS code much as I'm not a JS dev and it's minified. Also I didn't want to remove the cookie in order to not annoy our visitors.

Damn, the expiration is one year. Can you change that to one day?

I managed to replace all the external resources, but didn't want to touch the JS code much as I'm not a JS dev and it's minified. Also I didn't want to remove the cookie in order to not annoy our visitors. Damn, the expiration is one year. Can you change that to one day?

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#262