Free option column #26

2016-01-19T02:08:08Z

OKNoah commented

2016-01-19 02:08:08 +00:00

(Migrated from github.com)

Adds “free option” column to emails and clarifies data.

bookercodes commented

2016-01-19 08:55:17 +00:00

(Migrated from github.com)

First of all, thanks for the pull request -- your contribution is very
much appreciated.

I don't have time to check this out right now, but I will when I get
home. In all likelihood, I will submit a link to this pull request to
r/privacytools to get the communities feedback.

Alex Booker
alexbooker@fastmail.im

On Mon, Jan 18, 2016, at 06:08 PM, OKNoah wrote:

Adds “free option” column to emails and clarifies data.

You can view, comment on, or merge this pull request online at:

https://github.com/privacytoolsIO/privacytools.io/pull/26

Commit Summary

Removes Bitcoin support from Tutanota email

Adds "free option" field to email providers
File Changes

M index.html1
Patch Links:

https://github.com/privacytoolsIO/privacytools.io/pull/26.patch

https://github.com/privacytoolsIO/privacytools.io/pull/26.diff
—
Reply to this email directly or view it on GitHub[2].

Links:

First of all, thanks for the pull request -- your contribution is very much appreciated. I don't have time to check this out right now, but I will when I get home. In all likelihood, I will submit a link to this pull request to _r/privacytools_ to get the communities feedback. ## Alex Booker alexbooker@fastmail.im On Mon, Jan 18, 2016, at 06:08 PM, OKNoah wrote: > Adds “free option” column to emails and clarifies data. > > You can view, comment on, or merge this pull request online at: > > https://github.com/privacytoolsIO/privacytools.io/pull/26 > > Commit Summary > - Removes Bitcoin support from Tutanota email > - Adds "free option" field to email providers > File Changes > - _M_ index.html[1](105) > Patch Links: > - https://github.com/privacytoolsIO/privacytools.io/pull/26.patch > - https://github.com/privacytoolsIO/privacytools.io/pull/26.diff > — > Reply to this email directly or view it on GitHub[2]. Links: 1. https://github.com/privacytoolsIO/privacytools.io/pull/26/files#diff-0 2. https://github.com/privacytoolsIO/privacytools.io/pull/26

OKNoah commented

2016-01-20 07:49:36 +00:00

(Migrated from github.com)

@alexbooker You are welcome. I didn't see your thread about it on reddit, but here's one: https://www.reddit.com/r/privacytoolsIO/comments/41td9l/proposed_site_update_more_email_provider/

bookercodes commented

2016-01-20 22:13:08 +00:00

(Migrated from github.com)

Thanks for posting that thread. I will revisit it in a day or so when more people have had a chance to see it.

@privacytoolsIO, for such a significant change, I would really appreciate your input. Thanks.

Thanks for posting that thread. I will revisit it in a day or so when more people have had a chance to see it. @privacytoolsIO, for such a significant change, I would really appreciate your input. Thanks.

OKNoah commented

2016-01-21 17:43:40 +00:00

(Migrated from github.com)

By the way, here is a screenshot.

It's really not too big a change, just a new column and clarity on two of the other columns.

By the way, here is a screenshot. ![screen shot 2016-01-21 at 6 44 53 am](https://cloud.githubusercontent.com/assets/3739277/12489052/541ede52-c023-11e5-8cbd-b0bb693a2482.png) It's really not too big a change, just a new column and clarity on two of the other columns.

bookercodes commented

2016-01-21 20:21:39 +00:00

(Migrated from github.com)

It's not a big change, you're right. I would still like to see some more support though.

As you can probably appreciate, it's not strictly up to me to make changes to the site. This is a community website after all.

Thanks for your patience. Believe me when I say I am giving this due consideration!

It's not a big change, you're right. I would still like to see some more support though. As you can probably appreciate, it's not strictly up to me to make changes to the site. This is a community website after all. Thanks for your patience. Believe me when I say I am giving this due consideration!

OKNoah commented

2016-02-05 04:46:55 +00:00

(Migrated from github.com)

Any progress here?

OKNoah commented

2016-02-23 15:24:28 +00:00

(Migrated from github.com)

Happy belated 1 month anniversary to this pull request!

bookercodes commented

2016-02-23 15:43:51 +00:00

(Migrated from github.com)

I appreciate you 1, taking the time to make these changes in the first place and 2, diligently reminding me to tend to them. I cannot promise I will merge this but I do promise to evaluate it properly this evening, when I have time.

If I remember correctly, I have three concerns:

I have to double check all your data
I think there was a small issue with the Bootstrap labels (not shown in your screenshot)
Not much engagement on Reddit, but I agree this is a small and probably useful change

Thanks.

I appreciate you **1,** taking the time to make these changes in the first place and **2,** diligently reminding me to tend to them. I cannot promise I will merge this but I do promise to evaluate it properly this evening, when I have time. If I remember correctly, I have three concerns: - I have to double check all your data - I think there was a small issue with the [Bootstrap labels](http://getbootstrap.com/components/#available-variations) (not shown in your screenshot) - [Not much engagement on Reddit](https://www.reddit.com/r/privacytoolsIO/comments/41td9l/proposed_site_update_more_email_provider/), but I agree this is a small and probably useful change Thanks.

bookercodes commented

2016-02-23 21:05:28 +00:00

(Migrated from github.com)

I apprecaite your contribution, @OKNoah but as it stands, there are a couple of problems with this pull request. I encourage you to fix them and will help you if you need.

Problem 1: Your changes have caused the table to look quite messy:

Compare that screenshot of your fork to the current site:

Problem 2: The word "No" should have a blue background like the other occurrences of the word:

Problem 3: Please avoid text in parentheses like "(for donations)". It makes the table appear more complicated than it needs to be.

Thanks 😄!

I apprecaite your contribution, @OKNoah but as it stands, there are a couple of problems with this pull request. I encourage you to fix them and will help you if you need. **Problem 1:** Your changes have caused the table to look quite messy: ![](http://i.imgur.com/lBPCIgD.png) Compare that screenshot of your fork to the current site: ![](http://i.imgur.com/GzcUbvG.png) **Problem 2:** The word _"No"_ should have a blue background like the other occurrences of the word: ![](http://i.imgur.com/DXYzWJH.png) **Problem 3:** Please avoid text in parentheses like _"(for donations)"_. It makes the table appear more complicated than it needs to be. Thanks :smile:!

privacytoolsIO commented

2016-02-24 03:16:25 +00:00

(Migrated from github.com)

Sorry @OKNoah, like @alexbooker pointed out it gets too messy. I'd like to keep it simple. But I also appreciate the efforts. Thanks, guys!

OKNoah commented

2016-02-24 20:12:19 +00:00

(Migrated from github.com)

@privacytoolsIO @alexbooker All fixes submitted.

Agreed that it needs to be simple, but not so much that it becomes misleading. I spent a lot of time reading about or signing up for these services only to find they didn't really meet the features the table implied. Hopefully these changes save others time.

@privacytoolsIO @alexbooker All fixes submitted. Agreed that it needs to be simple, but not so much that it becomes misleading. I spent a lot of time reading about or signing up for these services only to find they didn't really meet the features the table implied. Hopefully these changes save others time.

bookercodes commented

2016-02-24 20:28:39 +00:00

(Migrated from github.com)

@privacytoolsIO @alexbooker All fixes submitted.

@OKNoah, I cannot see any updates to this pull request, nor can I see a new pull request 😕

@privacytoolsIO, I'm a tiny bit confused. Are you in support of this update or not?

> @privacytoolsIO @alexbooker All fixes submitted. @OKNoah, I cannot see any updates to this pull request, nor can I see a new pull request :confused: @privacytoolsIO, I'm a tiny bit confused. Are you in support of this update or not?

privacytoolsIO commented

2016-02-25 01:57:11 +00:00

(Migrated from github.com)

@alexbooker Sorry, should've made myself more clear. I'm not in support of the update because of the issues you also pointed out.

bookercodes commented

2016-02-25 15:19:54 +00:00

(Migrated from github.com)

@privacytoolsIO Thanks for clarifying.

Would you be on board if @OKNoah addressed the issues I mentioned (i.e. if @OKNoah added a simple free column only)?

@privacytoolsIO Thanks for clarifying. Would you be on board if @OKNoah _addressed_ the issues I mentioned (i.e. if @OKNoah added a simple free column _only_)?

OKNoah commented

2016-02-25 16:02:10 +00:00

(Migrated from github.com)

@alexbooker I believe I must start a new PR because this one was closed prematurely.

This repo is archived. You cannot comment on pull requests.

No reviewers