Update Signal logo and entries w/ APK link #205

jonah · 2017-03-23T14:42:46Z

NinebitX commented

2017-03-23 14:42:46 +00:00

(Migrated from github.com)

Description

I updated the Signal logo. The titles and descriptions in the Signal entries were inconsistent with each other. It's also cleaner and more consistent with the other entries to only display one download link. I added a link to the Signal APK download site to the Related Information sections, because PrivacytoolsIO recommends operating systems that don't include Google Play, and the Signal APK download site isn't linked to directly from the signal.org front page.

HTML Preview

http://htmlpreview.github.io/?https://github.com/NinebitX/privacytools.io/blob/master/index.html

### Description I updated the Signal logo. The titles and descriptions in the Signal entries were inconsistent with each other. It's also cleaner and more consistent with the other entries to only display one download link. I added a link to the Signal APK download site to the Related Information sections, because PrivacytoolsIO recommends operating systems that don't include Google Play, and the Signal APK download site isn't linked to directly from the signal.org front page. ### HTML Preview http://htmlpreview.github.io/?https://github.com/NinebitX/privacytools.io/blob/master/index.html

jonah approved these changes 2017-03-23 14:53:44 +00:00

kewde (Migrated from github.com) requested changes 2017-04-07 11:37:07 +00:00

kewde (Migrated from github.com) left a comment

Links for site and APK are okay.

I don't like this sentence tho, it's very chaotic.
"The app provides end-to-end encrypted one-to-one and group messaging, as well as end-to-end encrypted voice and video calling.

Links for site and APK are okay. I don't like this sentence tho, it's very chaotic. "The app provides end-to-end encrypted one-to-one and group messaging, as well as end-to-end encrypted voice and video calling.

NinebitX commented

2017-04-07 12:27:43 +00:00

(Migrated from github.com)

@kewde Would it be better to say: "The app provides one-to-one and group messaging, as well as voice and video calling. All communications are end-to-end encrypted."

kewde commented

2017-04-07 13:21:12 +00:00

(Migrated from github.com)

I'm not really fond of the word one-to-one, but I won't be blocking a merge proposal if you decide to use it anyways.
Here's my attempt at fixing the sentence that still clearly underlines that all of the following communication method are secure.
"The app provides end-to-end encrypted communication such private messaging, group conversations, voice and video calls. "

I'm not really fond of the word one-to-one, but I won't be blocking a merge proposal if you decide to use it anyways. Here's my attempt at fixing the sentence that still clearly underlines that all of the following communication method are secure. "The app provides end-to-end encrypted communication such private messaging, group conversations, voice and video calls. "

NinebitX commented

2017-04-07 17:19:52 +00:00

(Migrated from github.com)

@kewde How about simply saying: "The app provides instant messaging, as well as voice and video calling. All communications are end-to-end encrypted."

I'm sure people can figure out that it also provides other features like group messaging by visiting the Signal website.

@kewde How about simply saying: "The app provides instant messaging, as well as voice and video calling. All communications are end-to-end encrypted." I'm sure people can figure out that it also provides other features like group messaging by visiting the Signal website.

kewde (Migrated from github.com) approved these changes 2017-04-07 17:30:05 +00:00

kewde (Migrated from github.com) left a comment

Looks good!

kewde commented

2017-04-07 17:30:24 +00:00

(Migrated from github.com)

@NinebitX 👍

@NinebitX :+1:

This repo is archived. You cannot comment on pull requests.

No reviewers

kewde