privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update cardv2 for mobile layouts #1849

Merged
nitrohorse merged 1 commits from updates-for-mobile-layouts into master 2020-04-25 01:19:40 +00:00
Conversation 4 Commits 1 Files Changed 2 +9 -3
nitrohorse commented 2020-04-22 03:20:19 +00:00 (Migrated from github.com)
Copy Link

Description

This MR attempts to update v2 cards to be more mobile friendly; specifically letting the card buttons flex. Also will allow more buttons to fit in the future (for example, the Qwant card below adds a "Privacy Policy" button).

Netlify: https://deploy-preview-1849--privacytools-io.netlify.app/

Resolves: #none

Example 1

change-1

Before

before-3

After

change-3

Example 2

q-before-1

Before

q-before-2

q-before-3

After

q-after-2

q-after-3

q-after-4

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description This MR attempts to update v2 cards to be more mobile friendly; specifically letting the card buttons flex. Also will allow more buttons to fit in the future (for example, the Qwant card below adds a "Privacy Policy" button). Netlify: https://deploy-preview-1849--privacytools-io.netlify.app/ Resolves: #none <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. --> ### Example 1 ![change-1](https://user-images.githubusercontent.com/1514352/79936588-60374200-8447-11ea-8c19-5cb3c2787b99.png) #### Before ![before-3](https://user-images.githubusercontent.com/1514352/79936605-6af1d700-8447-11ea-8b7b-e409ada2249e.png) #### After ![change-3](https://user-images.githubusercontent.com/1514352/79936621-747b3f00-8447-11ea-82a6-1741f84e4943.png) ### Example 2 ![q-before-1](https://user-images.githubusercontent.com/1514352/79936692-9d033900-8447-11ea-8097-68c72245c57e.png) #### Before ![q-before-2](https://user-images.githubusercontent.com/1514352/79936705-a2608380-8447-11ea-9d9a-86468b4db9b9.png) ![q-before-3](https://user-images.githubusercontent.com/1514352/79936717-a7253780-8447-11ea-913a-9d3979ac70d3.png) #### After ![q-after-2](https://user-images.githubusercontent.com/1514352/79936734-af7d7280-8447-11ea-9ba9-54de68cbed07.png) ![q-after-3](https://user-images.githubusercontent.com/1514352/79936744-b2786300-8447-11ea-9db2-cc5402fb4232.png) ![q-after-4](https://user-images.githubusercontent.com/1514352/79936754-b73d1700-8447-11ea-8d62-5488d29679a7.png)
netlify[bot] commented 2020-04-22 03:22:31 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 56bcaeaeba28c67e53c1be1fa9faf4170e638397

https://deploy-preview-1849--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 56bcaeaeba28c67e53c1be1fa9faf4170e638397 https://deploy-preview-1849--privacytools-io.netlify.app
netlify[bot] commented 2020-04-22 03:24:33 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 05b3df9cb9

https://deploy-preview-1849--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 05b3df9cb93927cf6683d194384d7ae1851495df https://deploy-preview-1849--privacytools-io.netlify.app
danarel (Migrated from github.com) approved these changes 2020-04-22 03:26:59 +00:00
danarel (Migrated from github.com) left a comment

I like this!

I like this!
dngray (Migrated from github.com) approved these changes 2020-04-25 01:18:23 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
danarel
dngray
Labels
Clear labels
:mag:🤖 Search Engines
approved
approved, waiting for a PR
 dependencies
Pull requests that update a dependency file
 duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
 iOS
low priority
OS
Operating Systems
 Self-contained networks
Social media
stale
A label for stalebot if it gets added
 streaming
Anything related to media streaming.
 todo
Tor
Anything covering the Tor network
 WIP
active work in progress, do not merge or PR (yet)!
 wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
 XMPP
Extensible Messaging and Presence Protocol
 [m]
Matrix protocol
 ₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
 ✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
 🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
 💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
 🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
 🌐 website issue
*Technical* issues with the website.
 🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
 🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label 🏠 housekeeping
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1849
Delete Branch "updates-for-mobile-layouts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?