Fixed pricing for ProtonVPN #1829

jonah · 2020-04-13T13:41:47Z

dngray commented

2020-04-13 13:41:47 +00:00

(Migrated from github.com)

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1827

https://deploy-preview-1829--privacytools-io.netlify.com/providers/vpn/
https://deploy-preview-1829--privacytools-io.netlify.com/providers/email/

Resolves: https://github.com/privacytoolsIO/privacytools.io/issues/1827 https://deploy-preview-1829--privacytools-io.netlify.com/providers/vpn/ https://deploy-preview-1829--privacytools-io.netlify.com/providers/email/

netlify[bot] commented

2020-04-13 13:44:32 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 05dcb3a6f8

https://deploy-preview-1829--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 05dcb3a6f8dbb81ec6e5343da63ec95160a3c82b https://deploy-preview-1829--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2020-04-13 15:15:10 +00:00

Mikaela (Migrated from github.com) left a comment

I kind of dislike the Yr. but I am unable to find anything I like more.

I kind of dislike the `Yr.` but I am unable to find anything I like more.

Mikaela (Migrated from github.com) reviewed 2020-04-13 15:17:28 +00:00

dngray commented

2020-04-13 15:18:09 +00:00

(Migrated from github.com)

I kind of dislike the Yr. but I am unable to find anything I like more.

I decided to go with "yr".

Wikipedia says:

In English, the abbreviations y and yr are commonly used.

It also says further down Abbreviations yr and ya:

In astronomy, geology, and paleontology, the abbreviation yr for years and ya for years ago are sometimes used, combined with prefixes for thousand, million, or billion.[19][29] They are not SI units, using y to abbreviate the English "year", but following ambiguous international recommendations, use either the standard English first letters as prefixes (t, m, and b) or metric prefixes (k, M, and G) or variations on metric prefixes (k, m, g).

We could just use y, it might allow me to fix up the size adjustment I made for ProtonVPN.

> I kind of dislike the `Yr.` but I am unable to find anything I like more. I decided to go with "yr". [Wikipedia says](https://en.wikipedia.org/wiki/Year): > In English, the abbreviations _y_ and _yr_ are commonly used. It also says further down [Abbreviations yr and ya](https://en.wikipedia.org/wiki/Year#Abbreviations_yr_and_ya): > In [astronomy](https://en.wikipedia.org/wiki/Astronomy), geology, and paleontology, the abbreviation _yr_ for years and ya for years ago are sometimes used, combined with prefixes for thousand, million, or billion.[[19]](https://en.wikipedia.org/wiki/Year#cite_note-AGUStyle-19)[[29]](https://en.wikipedia.org/wiki/Year#cite_note-NASC-29) They are not SI units, using _y_ to abbreviate the English "year", but following ambiguous international recommendations, use either the standard English first letters as prefixes (t, m, and b) or metric prefixes (k, M, and G) or variations on [metric prefixes](https://en.wikipedia.org/wiki/Metric_prefix) (k, m, g). We could just use _y_, it might allow me to fix up the size adjustment I made for ProtonVPN.

Mikaela (Migrated from github.com) approved these changes 2020-04-13 15:50:28 +00:00

jonah approved these changes 2020-04-13 22:09:13 +00:00

jonah left a comment

uhhh unsure about the abbreviation but whatever, LGTM

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1829