VPN ownership several Chinese companies #1805

jonah · 2020-03-30T02:28:09Z

dngray commented

2020-03-30 02:28:09 +00:00

(Migrated from github.com)

https://deploy-preview-1805--privacytools-io.netlify.com/providers/vpn/#info

jonah reviewed 2020-03-30 02:28:09 +00:00

netlify[bot] commented

2020-03-30 02:30:31 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 4ef4bbd5db

https://deploy-preview-1805--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 4ef4bbd5dbd651a25975e5378cda3ed97b6cabf1 https://deploy-preview-1805--privacytools-io.netlify.com

nitrohorse (Migrated from github.com) approved these changes 2020-03-30 05:33:04 +00:00

nitrohorse (Migrated from github.com) left a comment

I somehow missed this video—it’s great 👍🏼 LGTM

Mikaela (Migrated from github.com) approved these changes 2020-03-30 18:38:43 +00:00

dngray commented

2020-03-31 07:35:30 +00:00

(Migrated from github.com)

Should we do something to signify that is a video? We could embed the video too, with an invidious instance ie https://invidio.us/embed/WVDQEoe6ZWY?local=true I feel it should be more prominent rather than mixed up with the related links.

What do you think @nitrohorse?

Should we do something to signify that is a video? We could embed the video too, with an invidious instance ie https://invidio.us/embed/WVDQEoe6ZWY?local=true I feel it should be more prominent rather than mixed up with the related links. What do you think @nitrohorse?

nitrohorse commented

2020-04-12 21:30:08 +00:00

(Migrated from github.com)

Should we do something to signify that is a video? We could embed the video too, with an invidious instance ie invidio.us/embed/WVDQEoe6ZWY?local=true I feel it should be more prominent rather than mixed up with the related links.

What do you think @nitrohorse?

Hmm, that could be a good idea for visibility. Something like this?

> Should we do something to signify that is a video? We could embed the video too, with an invidious instance ie [invidio.us/embed/WVDQEoe6ZWY?local=true](https://invidio.us/embed/WVDQEoe6ZWY?local=true) I feel it should be more prominent rather than mixed up with the related links. > > What do you think @nitrohorse? Hmm, that could be a good idea for visibility. Something like this? ![embed-vpn](https://user-images.githubusercontent.com/1514352/79080474-c19f3880-7d04-11ea-8d13-da01c6f1657a.png)

dngray commented

2020-04-13 02:22:50 +00:00

(Migrated from github.com)

@nitrohorse yeah i think that looks rather good, and fits in with our page style.

dngray commented

2020-04-13 03:19:36 +00:00

(Migrated from github.com)

@JonahAragon mentioned that it would be best to just host an image thumbnail with a play icon in the middle of it that people could click to open Invidious in a new tab.

He's said he will take a look at this tomorrow.

@JonahAragon mentioned that it would be best to just host an image thumbnail with a play icon in the middle of it that people could click to open Invidious in a new tab. He's said he will take a look at this tomorrow.

👍 1

dngray commented

2020-05-05 09:55:28 +00:00

(Migrated from github.com)

I think some changes need to be made to allow the use of jpg images. Ie if we wanted to use this as the image thumbnail.

I was thinking maybe something like:

<li>
  <img src="/assets/img/jpg/3rd-party/this-video-is-sponsored-by.jpg"
       width="180rem" class="img-fluid float-left mr-3"
       alt="This Video Is Sponsored By censored VPN">
  <a href="https://youtube.com/watch?v=WVDQEoe6ZWY">This Video Is Sponsored By ███ VPN</a>
</li>

Obviously image would need resizing though.

I think some changes need to be made to allow the use of jpg images. Ie if we wanted to use [this](https://i.ytimg.com/vi/WVDQEoe6ZWY/maxresdefault.jpg) as the image thumbnail. I was thinking maybe something like: ```html <li> <img src="/assets/img/jpg/3rd-party/this-video-is-sponsored-by.jpg" width="180rem" class="img-fluid float-left mr-3" alt="This Video Is Sponsored By censored VPN"> <a href="https://youtube.com/watch?v=WVDQEoe6ZWY">This Video Is Sponsored By ███ VPN</a> </li> ``` Obviously image would need resizing though.

nitrohorse commented

2020-05-06 03:01:02 +00:00

(Migrated from github.com)

Closing in favor of https://github.com/privacytoolsIO/privacytools.io/pull/1891!

This repo is archived. You cannot comment on pull requests.

No reviewers

nitrohorse

Mikaela