Added Pass to the PasswordManagers page #1676

2020-01-30T16:06:26Z

FishCoding commented

2020-01-30 16:06:26 +00:00

(Migrated from github.com)

Description

Resolves: #1648

Check List

I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.
I have read and understand the contributing guidelines.
The project is Free Libre and/or Open Source Software

Netlify preview for the mainly edited page: https://deploy-preview-1676--privacytools-io.netlify.com/software/passwords/
- I have edited the Password Managers page adding the information about the program named in the Issue #1648. Also I have add a svg that is pretty accurate for the program because It does not have one.

## Description Resolves: #1648  #### Check List  - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-1676--privacytools-io.netlify.com/software/passwords/ * I have edited the Password Managers page adding the information about the program named in the Issue #1648. Also I have add a svg that is pretty accurate for the program because It does not have one.

netlify[bot] commented

2020-01-30 16:07:11 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit e5efd3fb5b

https://deploy-preview-1676--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit e5efd3fb5b24757a7c5100fa0eb7d176c4021950 https://deploy-preview-1676--privacytools-io.netlify.com

Mikaela (Migrated from github.com) requested changes

2020-01-30 16:52:14 +00:00

Mikaela (Migrated from github.com) left a comment

Thank you for your PR, I have some comments:

Debian appears to trust pass or at least has packaged it for the main repository (I personally cannot audit it), so I guess the app itself is fine.
However I am not sure on the linked apps, who can say can they be relied upon?
I think pass does not comform with our main software requirements, mainly the ease to use. So I think pass would be better as a worth mentioning app rather than recommended and something like "pass compatible apps for multiple platforms are available" could be said with a link to the section on their website.

Thank you for your PR, I have some comments: * Debian appears to trust `pass` or at least has packaged it for the main repository (I personally cannot audit it), so I guess the app itself is fine. * However I am not sure on the linked apps, who can say can they be relied upon? * I think `pass` does not comform with our [main software requirements](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md#main), mainly the ease to use. So I think `pass` would be better as a worth mentioning app rather than recommended and something like "pass compatible apps for multiple platforms are available" could be said with a link to the section on their website.

_includes/sections/password-managers.html

Mikaela (Migrated from github.com) commented

2020-01-30 16:38:18 +00:00

  git="https://git.zx2c4.com/password-store"

I think we have a separate photo for non-GitHub repos when git is used. Also a typo.

```suggestion git="https://git.zx2c4.com/password-store" ``` I think we have a separate photo for non-GitHub repos when `git` is used. Also a typo.

Mikaela (Migrated from github.com) commented

2020-01-30 16:39:12 +00:00

  description="<strong>Pass</strong> is a very simple password store that keeps passwords using gpg2 encrypted files inside a simple directory tree residing at <code>~/.password-store</code>. It has a simple terminal interface where the user can perform the usual actions, and some plugins can be installed for extra functionalities."

I am not entirely sure on this description though, are Windows users likely to be familiar with ~ ?

```suggestion description="<strong>Pass</strong> is a very simple password store that keeps passwords using gpg2 encrypted files inside a simple directory tree residing at <code>~/.password-store</code>. It has a simple terminal interface where the user can perform the usual actions, and some plugins can be installed for extra functionalities." ``` I am not entirely sure on this description though, are Windows users likely to be familiar with `~` ?

Mikaela (Migrated from github.com) commented

2020-01-30 16:45:18 +00:00

I feel a bit uncomfortable with these as they aren't official apps, while they seem to be open source.

assets/img/svg/3rd-party/pass.svg

Mikaela (Migrated from github.com) commented

2020-01-30 16:46:49 +00:00

Do SVGs usually look like this?

FishCoding (Migrated from github.com) reviewed

2020-01-30 16:56:36 +00:00

assets/img/svg/3rd-party/pass.svg

FishCoding (Migrated from github.com) commented

2020-01-30 16:56:36 +00:00

It can be seen in the preview, but yee it's quite strange

FishCoding commented

2020-01-30 17:04:19 +00:00

(Migrated from github.com)

For the review itself, the program is no more than a bash script that encrypts the password and decrypts it.

I currently use the Android App that is in the froid store, but concerning the other applications none can ensure that are working well or are trustworthy so that I can delete the links.

And least I agree with you to move it to the worth mentioning instead in the general section due to the "easy to use" point, I will add the the phrase you have said.

For the review itself, the program is no more than a bash script that encrypts the password and decrypts it. I currently use the Android App that is in the froid store, but concerning the other applications none can ensure that are working well or are trustworthy so that I can delete the links. And least I agree with you to move it to the worth mentioning instead in the general section due to the "easy to use" point, I will add the the phrase you have said.

👍 2

dngray (Migrated from github.com) reviewed

2020-01-31 01:24:39 +00:00

_includes/sections/password-managers.html

dngray (Migrated from github.com) commented

2020-01-31 01:24:39 +00:00

I agree, i think we could add pass as a worth mentioning app but not with it's own card.

The main power of pass is that it can store secrets which can be used in scripts without having the actual password in the script. This isn't a feature however a lot of users are going to use, and I would certainly say the 3 mentioned Bitwarden, KeePassXC, and LessPass are better choices for most users.

I agree, i think we could add pass as a worth mentioning app but not with it's own card. The main power of `pass` is that it can store secrets which can be used in scripts without having the actual password in the script. This isn't a feature however a lot of users are going to use, and I would certainly say the 3 mentioned Bitwarden, KeePassXC, and LessPass are better choices for most users.

FishCoding (Migrated from github.com) reviewed

2020-01-31 13:42:49 +00:00

_includes/sections/password-managers.html

FishCoding (Migrated from github.com) commented

2020-01-31 13:42:48 +00:00

Moved to the worth mentioning section :)

Mikaela (Migrated from github.com) requested changes

2020-02-01 16:46:51 +00:00

_includes/sections/password-managers.html

Mikaela (Migrated from github.com) commented

2020-02-01 16:44:14 +00:00

    <a href="https://www.passwordstore.org/">Pass</a> - Pass is a bare-bones password store that keeps passwords using gpg2 encrypted files inside a simple directory tree residing at <code>~/.password-store</code>. It has a simple terminal interface where the user can perform the usual actions, and it's functionality can be extended by plugins. It can also be used in scripts without having to input the actual password in plain text.

```suggestion <a href="https://www.passwordstore.org/">Pass</a> - Pass is a bare-bones password store that keeps passwords using gpg2 encrypted files inside a simple directory tree residing at <code>~/.password-store</code>. It has a simple terminal interface where the user can perform the usual actions, and it's functionality can be extended by plugins. It can also be used in scripts without having to input the actual password in plain text. ```

Mikaela (Migrated from github.com) commented

2020-02-01 16:46:14 +00:00

The other suggestions don't have a space
@cradamy nearby suggested bare-bones as very simple means easy to use (which happens to also be one of the reasons we requested moving it as worth mentioning)
code tags were previously suggested and approved
the rest is just my gut feeling on what would seem better

* The other suggestions don't have a space * @cradamy nearby suggested bare-bones as very simple means easy to use (which happens to also be one of the reasons we requested moving it as worth mentioning) * code tags were previously suggested and approved * the rest is just my gut feeling on what would seem better

Mikaela (Migrated from github.com) approved these changes

2020-02-02 09:39:32 +00:00

Mikaela (Migrated from github.com) left a comment

Thank you

dngray (Migrated from github.com) approved these changes

2020-02-02 12:40:42 +00:00

dngray (Migrated from github.com) left a comment

Sounds good.

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1676