Rearrange some sections and correct grammatical errors #1548

2019-11-30T20:38:00Z

jonah commented

2019-11-30 20:38:00 +00:00

This PR corrects some sentences I didn't like, and rearranges the content of the website a bit.

Recommendations and worth mentioning products should generally go in the _includes/sections folder, while supplemental information (such as VPN criteria, news on E2EE, and other "further reading") should go directly on the page in /pages. This makes that guideline more consistently applied across the site.

This PR corrects some sentences I didn't like, and rearranges the content of the website a bit. Recommendations and worth mentioning products should generally go in the `_includes/sections` folder, while supplemental information (such as VPN criteria, news on E2EE, and other "further reading") should go directly on the page in `/pages`. This makes that guideline more consistently applied across the site.

netlify[bot] commented

2019-11-30 20:44:21 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 99e8e09cfb

https://deploy-preview-1548--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 99e8e09cfbfcefa3c6016fe60a9d82bffe8c3f9d https://deploy-preview-1548--privacytools-io.netlify.com

djoate (Migrated from github.com) requested changes

2019-11-30 22:37:37 +00:00

djoate (Migrated from github.com) left a comment

supplemental information (such as VPN criteria, news on E2EE, and other "further reading") should go directly on the page in /pages.

Due to how old.html is written, this PR leaves supplemental information out of the classic page

> supplemental information (such as VPN criteria, news on E2EE, and other "further reading") should go directly on the page in `/pages`. Due to how `old.html` is written, this PR leaves supplemental information out of the [classic page](https://deploy-preview-1548--privacytools-io.netlify.com/classic/)

_includes/sections/browser-addons.html

djoate (Migrated from github.com) commented

2019-11-30 22:27:37 +00:00

description="<strong>HTTPS Everywhere</strong> enables encryption of your connections to many major websites, making your browsing more secure. It is a collaboration between The Tor Project and the Electronic Frontier Foundation."

```suggestion description="<strong>HTTPS Everywhere</strong> enables encryption of your connections to many major websites, making your browsing more secure. It is a collaboration between The Tor Project and the Electronic Frontier Foundation." ```

jonah commented

2019-12-01 04:33:00 +00:00

That is intentional behavior.

dngray (Migrated from github.com) approved these changes

2019-12-01 05:36:18 +00:00

nitrohorse (Migrated from github.com) approved these changes

2019-12-01 08:12:37 +00:00

nitrohorse (Migrated from github.com) left a comment

Nice work! LGTM

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1548