Adding Mullvad Mobile Clients #1528

Closed
xelarate86 wants to merge 0 commits from master into master
xelarate86 commented 2019-11-26 05:46:29 +00:00 (Migrated from github.com)

Description

This pull request corrects the Mullvad documentation on the VPN providers page - they do in fact provide mobile applications now.

Resolves: #1413

Check List

<!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description This pull request corrects the Mullvad documentation on the VPN providers page - they *do* in fact provide mobile applications now. Resolves: #1413 <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. --> #### Check List <!-- Please add an x in each box below, like so: [x] --> - [Y] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [Y] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards --> https://eager-colden-4cbe67.netlify.com/providers/vpn https://deploy-preview-1528--privacytools-io.netlify.com/providers/vpn/#vpn * Code repository of the project (if applicable): N/A
Mikaela (Migrated from github.com) reviewed 2019-11-26 05:46:29 +00:00
jonah reviewed 2019-11-26 05:46:29 +00:00
netlify[bot] commented 2019-11-26 05:47:13 +00:00 (Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 080edbfa3a

https://deploy-preview-1528--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 080edbfa3a482173013558a30482a309820cd151 https://deploy-preview-1528--privacytools-io.netlify.com
Mikaela commented 2019-11-26 09:44:24 +00:00 (Migrated from github.com)

I corrected your original comment a bit (missing #1413 + strange Netlify link).

Are there any news on the app getting into F-Droid repository or Mullvad hosting their own F-Droid repository and how about iOS?

I corrected your original comment a bit (missing #1413 + strange Netlify link). Are there any news on the app getting into F-Droid repository or Mullvad hosting their own F-Droid repository and how about iOS?
Mikaela (Migrated from github.com) reviewed 2019-11-26 09:45:38 +00:00
Mikaela (Migrated from github.com) left a comment

Thank you, I will need second opinions though due to not being a Mullvad nor iOS users.

Thank you, I will need second opinions though due to not being a Mullvad nor iOS users.
Mikaela commented 2019-11-26 09:53:03 +00:00 (Migrated from github.com)

CC @djoate, I cannot request your review from the UI

CC @djoate, I cannot request your review from the UI
djoate (Migrated from github.com) reviewed 2019-11-26 10:16:41 +00:00
djoate (Migrated from github.com) left a comment

I think mentioning it as a beta seems fine, but right now, it doesn't seem to be ready for general use as it's still an early beta. For instance, according to https://github.com/mullvad/mullvadvpn-app/issues/1260, it seems that they don't have VPN start up on boot right now. This would currently contradict the later statement on the PTIO VPN page of how the Mullvad VPN clients "are able to automatically start on boot."

So, we should mention that they have OpenVPN and WireGuard configuration files for Android as well. The way it's phrased right now makes it seem like the beta app is the only option for Android. If one wants to have such features like start on boot, they have the option to use those mature open-source VPN clients for now.

I think mentioning it as a beta seems fine, but right now, it doesn't seem to be ready for general use as it's still an early beta. For instance, according to https://github.com/mullvad/mullvadvpn-app/issues/1260, it seems that they don't have VPN start up on boot right now. This would currently contradict the later statement on the PTIO VPN page of how the Mullvad VPN clients "are able to automatically start on boot." So, we should mention that they have OpenVPN and WireGuard configuration files for Android as well. The way it's phrased right now makes it seem like the beta app is the only option for Android. If one wants to have such features like start on boot, they have the option to use those mature open-source VPN clients for now.
@ -21,3 +21,3 @@
<a href="#mullvad"><i class="fas fa-link anchor-icon"></i></a> Mullvad
{% include badge.html color="info" text="EUR €60/y" %}
<span class="badge badge-info">EUR €60/Year</span>
</h2>
djoate (Migrated from github.com) commented 2019-11-26 10:07:44 +00:00

I think if we want to mention the Android beta specifically, it would be better to link to the Android page (https://mullvad.net/en/download/#android) instead of their git repo. That git repo is also where they develop for other platforms. The download link also includes a link to the repo anyway for those that are interested.

I think if we want to mention the Android beta specifically, it would be better to link to the Android page (https://mullvad.net/en/download/#android) instead of their git repo. That git repo is also where they develop for other platforms. The download link also includes a link to the repo anyway for those that are interested.
danarel (Migrated from github.com) reviewed 2019-11-26 18:46:29 +00:00
@ -21,3 +21,3 @@
<a href="#mullvad"><i class="fas fa-link anchor-icon"></i></a> Mullvad
{% include badge.html color="info" text="EUR €60/y" %}
<span class="badge badge-info">EUR €60/Year</span>
</h2>
danarel (Migrated from github.com) commented 2019-11-26 18:46:29 +00:00

I agree, linking to the page instead of the repo is the way to go.

I agree, linking to the page instead of the repo is the way to go.
xelarate86 (Migrated from github.com) reviewed 2019-11-27 00:26:36 +00:00
@ -21,3 +21,3 @@
<a href="#mullvad"><i class="fas fa-link anchor-icon"></i></a> Mullvad
{% include badge.html color="info" text="EUR €60/y" %}
<span class="badge badge-info">EUR €60/Year</span>
</h2>
xelarate86 (Migrated from github.com) commented 2019-11-27 00:26:36 +00:00

I'm new to contribution on github - should I make this change and open a new pull request or can I modify this one?

I'm new to contribution on github - should I make this change and open a new pull request or can I modify this one?
danarel (Migrated from github.com) reviewed 2019-11-27 00:38:54 +00:00
danarel (Migrated from github.com) left a comment

I think this looks good and is ready to go.

I think this looks good and is ready to go.
nitrohorse (Migrated from github.com) reviewed 2019-11-27 04:06:52 +00:00
djoate (Migrated from github.com) reviewed 2019-11-27 04:49:40 +00:00
@ -21,3 +21,3 @@
<a href="#mullvad"><i class="fas fa-link anchor-icon"></i></a> Mullvad
{% include badge.html color="info" text="EUR €60/y" %}
<span class="badge badge-info">EUR €60/Year</span>
</h2>
djoate (Migrated from github.com) commented 2019-11-27 04:49:39 +00:00

@xelarate86 You can just modify your branch that this PR is from and GitHub will automatically show the changes here

@xelarate86 You can just modify your branch that this PR is from and GitHub will automatically show the changes here
danarel (Migrated from github.com) reviewed 2019-11-27 04:52:48 +00:00
@ -21,3 +21,3 @@
<a href="#mullvad"><i class="fas fa-link anchor-icon"></i></a> Mullvad
{% include badge.html color="info" text="EUR €60/y" %}
<span class="badge badge-info">EUR €60/Year</span>
</h2>
danarel (Migrated from github.com) commented 2019-11-27 04:52:48 +00:00

@xelarate86 I made the change here: c90db84.

This part is resolved.

@xelarate86 I made the change here: [c90db84](https://github.com/privacytoolsIO/privacytools.io/pull/1528/commits/c90db84ba598eee2e82df5608116356e27e4a29a). This part is resolved.
dngray (Migrated from github.com) reviewed 2019-11-27 05:15:43 +00:00
jonah requested changes 2019-11-27 06:34:59 +00:00
jonah left a comment

The mobile client criteria is for 1) ease-of-use for users and 2) additional mobile functionality that generic VPN apps do not provide. Their current offering does not satisfy this IMO.

I think it makes more sense to wait until their apps are finished to mention them. As we previously discussed at https://github.com/privacytoolsIO/privacytools.io/issues/1413#issuecomment-544211872.

The mobile client criteria is for 1) ease-of-use for users and 2) additional mobile functionality that generic VPN apps do not provide. Their current offering does not satisfy this IMO. I think it makes more sense to wait until their apps are finished to mention them. As we previously discussed at https://github.com/privacytoolsIO/privacytools.io/issues/1413#issuecomment-544211872.
danarel commented 2019-11-27 07:47:58 +00:00 (Migrated from github.com)

The mobile client criteria is for 1) ease-of-use for users and 2) additional mobile functionality that generic VPN apps do not provide. Their current offering does not satisfy this IMO.

I think it makes more sense to wait until their apps are finished to mention them. As we previously discussed at #1413 (comment).

It might though. While the Android beta isn't as easy as the Play store, using Wireguard could likely be what Mullvad wants their users to do. They have put money into that project and it's as easy as installing and selecting Mullvad to get it working.

> The mobile client criteria is for 1) ease-of-use for users and 2) additional mobile functionality that generic VPN apps do not provide. Their current offering does not satisfy this IMO. > > I think it makes more sense to wait until their apps are finished to mention them. As we previously discussed at [#1413 (comment)](https://github.com/privacytoolsIO/privacytools.io/issues/1413#issuecomment-544211872). It might though. While the Android beta isn't as easy as the Play store, using Wireguard could likely be what Mullvad wants their users to do. They have put money into that project and it's as easy as installing and selecting Mullvad to get it working.
xelarate86 (Migrated from github.com) reviewed 2019-12-04 23:02:43 +00:00
xelarate86 (Migrated from github.com) left a comment

Agreed

Agreed
danarel commented 2020-04-07 15:17:54 +00:00 (Migrated from github.com)
Mullvad client on Google Play Store https://play.google.com/store/apps/details?id=net.mullvad.mullvadvpn
danarel commented 2020-04-08 21:31:49 +00:00 (Migrated from github.com)
And here is their iOS client. https://mullvad.net/en/blog/2020/4/8/launched-mullvad-vpn-ios-here/
Mikaela commented 2020-04-10 16:21:51 +00:00 (Migrated from github.com)

I guess this needs merge conflicts fixed and preferably links to the app stores?

I guess this needs merge conflicts fixed and preferably links to the app stores?
xelarate86 commented 2020-04-11 22:41:47 +00:00 (Migrated from github.com)

Hello everyone - for some reason I force-pushed my branch back to the master, closing this PR. Thus, I've opened a new one making the required changes that @Mikaela requested.

This new PR can be found at #1824

Hello everyone - for some reason I force-pushed my branch back to the master, closing this PR. Thus, I've opened a new one making the required changes that @Mikaela requested. This new PR can be found at #1824
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1528
No description provided.