Updated Mullvad VPN details with Play Store and App Store Links #1824

Merged
xelarate86 merged 2 commits from master into master 2020-04-12 02:03:46 +00:00
xelarate86 commented 2020-04-11 22:40:09 +00:00 (Migrated from github.com)

Description

Per the most recent activity on the old PR #1528 I have reconfigured this request to make the required changes.

Given that Mullvad now has published Apps on both main app stores for Android and iOS, I have included links and corrected the incorrect documentation that mobile clients were still in the works.

Resolves: #1528 which was erroneously closed. (By me, oops).

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

  • Netlify preview for the mainly edited page:
    Netlify Preview here

  • Code repository of the project (if applicable):
    N/A

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Per the [most recent activity](https://github.com/privacytoolsIO/privacytools.io/pull/1528#issuecomment-612105347) on the old PR #1528 I have reconfigured this request to make the required changes. Given that Mullvad now has published Apps on both main app stores for Android and iOS, I have included links and corrected the incorrect documentation that mobile clients were still in the works. Resolves: #1528 which was erroneously closed. (By me, oops). #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards --> [Netlify Preview here](https://eager-colden-4cbe67.netlify.com/providers/vpn/) * Code repository of the project (if applicable): N/A
netlify[bot] commented 2020-04-11 22:40:43 +00:00 (Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 4467797f8e

https://deploy-preview-1824--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 4467797f8e18643029d85eed20501ad375969e63 https://deploy-preview-1824--privacytools-io.netlify.com
xelarate86 commented 2020-04-11 22:43:05 +00:00 (Migrated from github.com)

@Mikaela @danarel @JonahAragon Pinging you to this, updating #1528. Apologies for the poor practice in opening a new PR.

@Mikaela @danarel @JonahAragon Pinging you to this, updating #1528. Apologies for the poor practice in opening a new PR.
danarel commented 2020-04-11 22:43:41 +00:00 (Migrated from github.com)

Do we want to link to the clients since we don’t for the other providers?

Do we want to link to the clients since we don’t for the other providers?
jonah reviewed 2020-04-11 22:44:28 +00:00
jonah left a comment

Uhhh reviewing on my phone, but LGTM

Uhhh reviewing on my phone, but LGTM

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.
danarel commented 2020-04-11 22:46:09 +00:00 (Migrated from github.com)

Uhhh reviewing on my phone, but LGTM

For Proton and IVPN we only mention they have mobile clients.

I think we should either add them, or remove the links in the Mullvad description.

> Uhhh reviewing on my phone, but LGTM For Proton and IVPN we only mention they have mobile clients. I think we should either add them, or remove the links in the Mullvad description.
xelarate86 commented 2020-04-11 22:46:47 +00:00 (Migrated from github.com)

Uhhh reviewing on my phone, but LGTM

For Proton and IVPN we only mention they have mobile clients.

I think we should either add them, or remove the links in the Mullvad description.

I will add them and update this pull request @JonahAragon

> > Uhhh reviewing on my phone, but LGTM > > For Proton and IVPN we only mention they have mobile clients. > > I think we should either add them, or remove the links in the Mullvad description. I will add them and update this pull request @JonahAragon
danarel commented 2020-04-11 22:47:02 +00:00 (Migrated from github.com)

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.

Agreed. I rather add links then remove them.

> @danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO. Agreed. I rather add links then remove them.
xelarate86 commented 2020-04-11 22:54:32 +00:00 (Migrated from github.com)

@danarel @JonahAragon Updated the PR with the IVPN and ProtonVPN links.
A preview can be found at that same netlify link

@danarel @JonahAragon Updated the PR with the IVPN and ProtonVPN links. [A preview can be found at that same netlify link](https://eager-colden-4cbe67.netlify.com/providers/vpn/)
jonah approved these changes 2020-04-11 22:55:45 +00:00
jonah left a comment

👌

👌
danarel (Migrated from github.com) approved these changes 2020-04-11 23:24:27 +00:00
danarel (Migrated from github.com) left a comment

Looks good to me!

Looks good to me!
dngray (Migrated from github.com) approved these changes 2020-04-12 02:03:28 +00:00
dngray (Migrated from github.com) left a comment

LGTM

LGTM
This repo is archived. You cannot comment on pull requests.
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1824
No description provided.