privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Updated Mullvad VPN details with Play Store and App Store Links #1824

Merged
xelarate86 merged 2 commits from master into master 2020-04-12 02:03:46 +00:00
Conversation 12 Commits 2 Files Changed 1 +4 -4
xelarate86 commented 2020-04-11 22:40:09 +00:00 (Migrated from github.com)
Copy Link

Description

Per the most recent activity on the old PR #1528 I have reconfigured this request to make the required changes.

Given that Mullvad now has published Apps on both main app stores for Android and iOS, I have included links and corrected the incorrect documentation that mobile clients were still in the works.

Resolves: #1528 which was erroneously closed. (By me, oops).

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

  • Netlify preview for the mainly edited page:
    Netlify Preview here

  • Code repository of the project (if applicable):
    N/A

<!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Per the [most recent activity](https://github.com/privacytoolsIO/privacytools.io/pull/1528#issuecomment-612105347) on the old PR #1528 I have reconfigured this request to make the required changes. Given that Mullvad now has published Apps on both main app stores for Android and iOS, I have included links and corrected the incorrect documentation that mobile clients were still in the works. Resolves: #1528 which was erroneously closed. (By me, oops). #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards --> [Netlify Preview here](https://eager-colden-4cbe67.netlify.com/providers/vpn/) * Code repository of the project (if applicable): N/A
netlify[bot] commented 2020-04-11 22:40:43 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 4467797f8e

https://deploy-preview-1824--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 4467797f8e18643029d85eed20501ad375969e63 https://deploy-preview-1824--privacytools-io.netlify.com
xelarate86 commented 2020-04-11 22:43:05 +00:00 (Migrated from github.com)
Copy Link

@Mikaela @danarel @JonahAragon Pinging you to this, updating #1528. Apologies for the poor practice in opening a new PR.

@Mikaela @danarel @JonahAragon Pinging you to this, updating #1528. Apologies for the poor practice in opening a new PR.
danarel commented 2020-04-11 22:43:41 +00:00 (Migrated from github.com)
Copy Link

Do we want to link to the clients since we don’t for the other providers?

Do we want to link to the clients since we don’t for the other providers?
jonah reviewed 2020-04-11 22:44:28 +00:00
jonah left a comment

Uhhh reviewing on my phone, but LGTM

Uhhh reviewing on my phone, but LGTM
jonah commented 2020-04-11 22:46:05 +00:00
Copy Link

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.
danarel commented 2020-04-11 22:46:09 +00:00 (Migrated from github.com)
Copy Link

Uhhh reviewing on my phone, but LGTM

For Proton and IVPN we only mention they have mobile clients.

I think we should either add them, or remove the links in the Mullvad description.

> Uhhh reviewing on my phone, but LGTM For Proton and IVPN we only mention they have mobile clients. I think we should either add them, or remove the links in the Mullvad description.
👍 1
xelarate86 commented 2020-04-11 22:46:47 +00:00 (Migrated from github.com)
Copy Link

Uhhh reviewing on my phone, but LGTM

For Proton and IVPN we only mention they have mobile clients.

I think we should either add them, or remove the links in the Mullvad description.

I will add them and update this pull request @JonahAragon

> > Uhhh reviewing on my phone, but LGTM > > For Proton and IVPN we only mention they have mobile clients. > > I think we should either add them, or remove the links in the Mullvad description. I will add them and update this pull request @JonahAragon
👍 1
danarel commented 2020-04-11 22:47:02 +00:00 (Migrated from github.com)
Copy Link

@danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO.

Agreed. I rather add links then remove them.

> @danarel no, not for consistency...... although I’d probably actually prefer adding links to the other two instead of removing these. Makes sense to list them IMO. Agreed. I rather add links then remove them.
xelarate86 commented 2020-04-11 22:54:32 +00:00 (Migrated from github.com)
Copy Link

@danarel @JonahAragon Updated the PR with the IVPN and ProtonVPN links.
A preview can be found at that same netlify link

@danarel @JonahAragon Updated the PR with the IVPN and ProtonVPN links. [A preview can be found at that same netlify link](https://eager-colden-4cbe67.netlify.com/providers/vpn/)
jonah approved these changes 2020-04-11 22:55:45 +00:00
jonah left a comment

👌

👌
danarel (Migrated from github.com) approved these changes 2020-04-11 23:24:27 +00:00
danarel (Migrated from github.com) left a comment

Looks good to me!

Looks good to me!
dngray (Migrated from github.com) approved these changes 2020-04-12 02:03:28 +00:00
dngray (Migrated from github.com) left a comment

LGTM

LGTM
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
danarel
dngray
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1824
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?