Clarify sponsorship policy #1508

jonah · 2019-11-22T18:48:41Z

jonah commented

2019-11-22 18:48:41 +00:00

https://github.com/privacytoolsIO/privacytools.io/pull/1451#issuecomment-553954762

@davegson I would be interested in your thoughts.

https://deploy-preview-1508--privacytools-io.netlify.com/sponsors/

https://github.com/privacytoolsIO/privacytools.io/pull/1451#issuecomment-553954762 @davegson I would be interested in your thoughts. https://deploy-preview-1508--privacytools-io.netlify.com/sponsors/

privacytoolsIO (Migrated from github.com) reviewed 2019-11-22 18:48:41 +00:00

netlify[bot] commented

2019-11-22 18:49:22 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 72cd94438f

https://deploy-preview-1508--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 72cd94438f60ae213102f727e83293fc4e7204c2 https://deploy-preview-1508--privacytools-io.netlify.com

davegson commented

2019-11-22 20:20:38 +00:00

(Migrated from github.com)

I really like the clarification! Draws a clear line to rule out shady actors but still gives space for you as a team to validate each request on a case by case basis 👍👍👍

Two sentences I feel you can improve:

Strong encryption is the only way to prevent governments from snooping in on our communications.

It's odd to single out governments here. There are many different types of malicious entities ready to spoof user data. I'd rephrase it to something more generic like: "to prevent malicious actors from..."

We reserve the right to approve or deny all sponsorships from receiving the benefits detailed below if we believe that your organization or product is not aligned with our key values.

I think there is a logical error in here, first I do not know if you can say: "approve/deny a sponsorship" Would it not rather be that you approve/deny a sponsorship request (or inquiry) [I'm not fluent]

Also, I'd split the sentence into two so the approve/deny part is in one sentence and the reason for denying in the latter. Otherwise the misalignment seems to be both the reason for the accept & deny.

Something like:

We reserve the right to approve or deny all sponsorship inquieries from receiving the benefits detailed below. We will deny any incoming requests if we believe the organization or product is not aligned with our key values.

Make it your own 😉

I really like the clarification! Draws a clear line to rule out shady actors but still gives space for you as a team to validate each request on a case by case basis 👍👍👍 Two sentences I feel you can improve: ----------------- > Strong encryption is the only way to prevent governments from snooping in on our communications. It's odd to single out governments here. There are many different types of malicious entities ready to spoof user data. I'd rephrase it to something more generic like: "to prevent malicious actors from..." ----------------- > We reserve the right to approve or deny all sponsorships from receiving the benefits detailed below if we believe that your organization or product is not aligned with our key values. I think there is a logical error in here, first I do not know if you can say: "approve/deny a sponsorship" Would it not rather be that you approve/deny a sponsorship request (or inquiry) [I'm *not* fluent] Also, I'd split the sentence into two so the approve/deny part is in one sentence and the reason for denying in the latter. Otherwise the misalignment seems to be both the reason for the accept & deny. Something like: We reserve the right to approve or deny all sponsorship inquieries from receiving the benefits detailed below. We will deny any incoming requests if we believe the organization or product is not aligned with our key values. Make it your own 😉

jonah commented

2019-11-22 22:54:30 +00:00

I think there is a logical error in here, first I do not know if you can say: "approve/deny a sponsorship" Would it not rather be that you approve/deny a sponsorship request (or inquiry)

So the problem is that the sponsorship tiers are published on Open Collective and nothing technically is stopping somebody like say, Facebook, from giving us $250/month or whatever. So the main point is that if you don't first email sponsors@privacytools.io and get in touch, there's no guarantee that you'll get your logo on the website or something, simply because you sent money over.

> I think there is a logical error in here, first I do not know if you can say: "approve/deny a sponsorship" Would it not rather be that you approve/deny a sponsorship request (or inquiry) So the problem is that the sponsorship tiers are published on Open Collective and nothing *technically* is stopping somebody like say, Facebook, from giving us $250/month or whatever. So the main point is that if you don't *first* email sponsors@privacytools.io and get in touch, there's no guarantee that you'll get your logo on the website or something, simply because you sent money over.

Mikaela (Migrated from github.com) reviewed 2019-11-24 17:56:11 +00:00

Mikaela (Migrated from github.com) left a comment

Why the moving away from variable? I am not reading further while wondering this.

.github/CODEOWNERS

						
				@ -17,3 +20,4 @@

				/LICENSE.txt @JonahAragon

				/.travis.yml @JonahAragon @Shifterovich @nitrohorse

				/CNAME @JonahAragon

				/nginx/ @JonahAragon

Mikaela (Migrated from github.com) commented

2019-11-24 17:53:27 +00:00

I am curious on why?

_includes/footer.html

						
				@ -46,3 +46,3 @@

				  <p>

				  <input type="text" value="{{ site.name }} - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <input type="text" value="PrivacyTools - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <span class="help-block">For easy copy and paste. Share this text snippet.</span>

Mikaela (Migrated from github.com) commented

2019-11-24 17:54:42 +00:00

Why not using the variable?

_includes/sections/header.html

						
				@ -13,3 +12,4 @@

				<input type="search" name="q" class="form-control input-lg" id="q" placeholder="Try PrivacyTools Search, a Privacy-Respecting Search Engine" autocomplete="off" value="">

				<span class="input-group-btn">

				<button type="submit" class="btn btn-primary input-lg"><span class="hide_if_nojs"><i class="fas fa-search"></i> </span><span class="hidden active_if_nojs">start search</span></button>

				</span>

Mikaela (Migrated from github.com) commented

2019-11-24 17:55:22 +00:00

I don't understand the variable change here either.

davegson (Migrated from github.com) reviewed 2019-11-25 08:33:54 +00:00

_includes/footer.html

						
				@ -46,3 +46,3 @@

				  <p>

				  <input type="text" value="{{ site.name }} - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <input type="text" value="PrivacyTools - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <span class="help-block">For easy copy and paste. Share this text snippet.</span>

davegson (Migrated from github.com) commented

2019-11-25 08:33:53 +00:00

Since I'm already on this PR. I agree the why needs to be elaborated. Your commits messages do not elaborate on that.

Wouldn't iE @abbluiz need the {{ site.name }} variable to more easily support the Portuguese version?

Since I'm already on this PR. I agree the *why* needs to be elaborated. Your commits messages do not elaborate on that. Wouldn't iE @abbluiz need the `{{ site.name }}` variable to more easily support the Portuguese version?

davegson commented

2019-11-25 08:39:58 +00:00

(Migrated from github.com)

@JonahAragon, I like the text tweaks. 👍

jonah reviewed 2019-11-25 18:54:15 +00:00

_includes/footer.html

						
				@ -46,3 +46,3 @@

				  <p>

				  <input type="text" value="{{ site.name }} - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <input type="text" value="PrivacyTools - Encryption and tools to protect against global mass surveillance - {{ site.production_url }}" class="form-control input-lg onclick-select">

				  <span class="help-block">For easy copy and paste. Share this text snippet.</span>

jonah commented

2019-11-25 18:54:15 +00:00

It doesn’t make sense to me as we shift to in-repo translations (#1509), and it was implemented to solve a problem that doesn’t currently exist.

Mikaela (Migrated from github.com) requested changes 2019-11-26 10:12:47 +00:00

Mikaela (Migrated from github.com) left a comment

Ok, but

I want that typo fixed before I am approving this PR or a citation of it being correct.
I dislike changing the variable to PrivacyTools without explanation (until asked) and in my opinion it should be in a separate PR.

Ok, but * [ ] I want that typo fixed before I am approving this PR or a citation of it being correct. * I dislike changing the variable to PrivacyTools without explanation (until asked) and in my opinion it should be in a separate PR.

pages/privacy.md

						
				@ -11,2 +10,3 @@

				PrivacyTools is an unincorporated community developing this website and a number of privacy-friendly services. The current list of public team members [can be found on GitHub](https://github.com/orgs/privacytoolsIO/people). In order to operate these services, PrivacyTools receives hosting and administration services from Aragon Ventures LLC.

				## How does {{ site.name }} collect data about me?

				## How does PrivacyTools collect data about me?

Mikaela (Migrated from github.com) commented

2019-11-26 10:08:58 +00:00

I wonder if https://www.privacytools.io/about/ would be a better or at least good to mention here?

pages/sponsors.html

Mikaela (Migrated from github.com) commented

2019-11-26 10:10:55 +00:00

  <p>We reserve the right to deny all sponsors from receiving the benefits detailed below if we believe that your organization or product is not aligned with our key values. Therefore, if you are interested in sponsoring our project, please first email <a href="mailto:sponsors@privacytools.io">sponsors@privacytools.io</a> so we may discuss further.</p>

Right or deny makes no sense to me, did you perhaps mean right to?

```suggestion <p>We reserve the right to deny all sponsors from receiving the benefits detailed below if we believe that your organization or product is not aligned with our key values. Therefore, if you are interested in sponsoring our project, please first email <a href="mailto:sponsors@privacytools.io">sponsors@privacytools.io</a> so we may discuss further.</p> ``` Right or deny makes no sense to me, did you perhaps mean right to?

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1508