privacyguides
/
privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

search-engines: delist startpage #1410

Merged
Mikaela merged 4 commits from delist-startpage into master 2019-11-12 22:20:18 +00:00
Conversation 11 Commits 4 Files Changed 2 -8
Mikaela commented 2019-10-15 21:17:02 +00:00 (Migrated from github.com)
Copy Link

Resolves: #1409

Preview: https://deploy-preview-1410--privacytools-io.netlify.com/providers/search-engines/#search

Resolves: #1409 Preview: https://deploy-preview-1410--privacytools-io.netlify.com/providers/search-engines/#search
👍 2
blacklight447 (Migrated from github.com) reviewed 2019-10-15 21:17:02 +00:00
netlify[bot] commented 2019-10-15 21:17:44 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 79dc3f4676

https://deploy-preview-1410--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 79dc3f46764464782ffe86676b22b3f7a2ebc3cc https://deploy-preview-1410--privacytools-io.netlify.com
Mikaela commented 2019-10-17 21:53:39 +00:00 (Migrated from github.com)
Copy Link

In case anyone finds here, but not the discussion, it's in two places https://github.com/privacytoolsIO/privacytools.io/issues/1409#issuecomment-542506807 and our forum before the WIP (don't merge/PR) label gets removed and anything happens with this PR.

With luck I think we may even be able to close this issue and not delist Startpage, but it's too early to say.

In case anyone finds here, but not the discussion, it's in two places https://github.com/privacytoolsIO/privacytools.io/issues/1409#issuecomment-542506807 and [our forum](https://forum.privacytools.io/t/candidate-for-delisting-discussion-startpage/284/6?u=mikaela) before the WIP (don't merge/PR) label gets removed and anything happens with this PR. With luck I think we may even be able to close this issue and not delist Startpage, but it's too early to say.
djoate (Migrated from github.com) reviewed 2019-10-26 21:51:37 +00:00
_includes/sections/search-engines.html
@ -24,4 +17,3 @@
{% include cardv2.html
title="DuckDuckGo - USA"
image="/assets/img/provider/DuckDuckGo.png"
djoate (Migrated from github.com) commented 2019-10-26 21:51:37 +00:00

If we end up delisting StartPage, we should also remove the asset (https://github.com/privacytoolsIO/privacytools.io/blob/master/assets/img/provider/StartPage.png)

If we end up delisting StartPage, we should also remove the asset (https://github.com/privacytoolsIO/privacytools.io/blob/master/assets/img/provider/StartPage.png)
Mikaela (Migrated from github.com) reviewed 2019-10-27 16:35:36 +00:00
_includes/sections/search-engines.html
@ -24,4 +17,3 @@
{% include cardv2.html
title="DuckDuckGo - USA"
image="/assets/img/provider/DuckDuckGo.png"
Mikaela (Migrated from github.com) commented 2019-10-27 16:35:36 +00:00

Thanks, done

Thanks, done
Mikaela commented 2019-10-27 16:39:32 +00:00 (Migrated from github.com)
Copy Link

I also fixed the merge conflict and removed the WIP label, even while I am not sure if a concensus was reached, I am ~10 days behind on everything.

I also fixed the merge conflict and removed the WIP label, even while I am not sure if a concensus was reached, I am ~10 days behind on everything.
nitrohorse (Migrated from github.com) reviewed 2019-10-27 16:42:48 +00:00
dawidpotocki (Migrated from github.com) reviewed 2019-11-06 22:50:41 +00:00
Mikaela commented 2019-11-10 12:59:35 +00:00 (Migrated from github.com)
Copy Link

@privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation?

CC: @LizMcIntyre

@privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation? CC: @LizMcIntyre
LizMcIntyre commented 2019-11-10 18:49:43 +00:00 (Migrated from github.com)
Copy Link

@privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation?

CC: @LizMcIntyre

Hi @Mikaela @blacklight447-ptio I believe something should be posted to note the removal. I'm thinking a short comment is best. Here's the latest I recommended in the discussion thread:

The Startpage search engine is de-listed until it is fully transparent about its new ownership and data processing.

People can click the link to get the details.

I believe that once PrivacytoolsIO recommends a service, it should indicate that a service is removed and why it is removed. This will help alert those who use a recommended service that has lost trust. How else might they know?

A press release and other media might also be a good idea because some people might not return to see a warning.

> @privacytoolsIO/editorial Can we merge this? Or does @blacklight447-ptio want to suggest changes to add a note to explain the situation? > > CC: @LizMcIntyre Hi @Mikaela @blacklight447-ptio I believe *something* should be posted to note the removal. I'm thinking a short comment is best. Here's the latest I recommended in the discussion thread: **The Startpage search engine is de-listed until it is fully transparent about its [new ownership](https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/) and data processing.** People can click the link to get the details. I believe that once PrivacytoolsIO recommends a service, it should indicate that a service is removed and why it is removed. This will help alert those who use a recommended service that has lost trust. How else might they know? A press release and other media might also be a good idea because some people might not return to see a warning.
Mikaela commented 2019-11-10 19:57:45 +00:00 (Migrated from github.com)
Copy Link

@privacytoolsIO/editorial & @LizMcIntyre, please rereview changes at https://github.com/privacytoolsIO/privacytools.io/pull/1410/files + consider can we merge it.

I have no comment on the rest at the moment.

@privacytoolsIO/editorial & @LizMcIntyre, please rereview changes at https://github.com/privacytoolsIO/privacytools.io/pull/1410/files + consider can we merge it. I have no comment on the rest at the moment.
djoate (Migrated from github.com) requested changes 2019-11-10 23:26:59 +00:00
djoate (Migrated from github.com) left a comment

Also, I think it would look better if the warning text wasn't in the middle of the cards but rather at the bottom of the cards

Also, I think it would look better if the warning text wasn't in the middle of the cards but rather at the bottom of the cards
_includes/sections/search-engines.html
djoate (Migrated from github.com) commented 2019-11-10 23:25:17 +00:00 
<p><strong>The Startpage search engine is delisted until it is fully transparent about <a href="https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/">its new ownership</a> and data processing.</strong></p>
```suggestion <p><strong>The Startpage search engine is delisted until it is fully transparent about <a href="https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/">its new ownership</a> and data processing.</strong></p> ```
nitrohorse (Migrated from github.com) reviewed 2019-11-11 00:20:01 +00:00
_includes/sections/search-engines.html
nitrohorse (Migrated from github.com) commented 2019-11-11 00:20:01 +00:00

Yeah, I agree; the warning in the middle does look a bit odd.

Yeah, I agree; the warning in the middle does look a bit odd.
blacklight447 commented 2019-11-11 05:57:46 +00:00 (Migrated from github.com)
Copy Link

Tbh, do we want the post delisting on the website now? It goes a bit against what we normally do, i would personally opt to just remove it, and put out a small blog post.

Tbh, do we want the post delisting on the website now? It goes a bit against what we normally do, i would personally opt to just remove it, and put out a small blog post.
nitrohorse commented 2019-11-11 06:30:10 +00:00 (Migrated from github.com)
Copy Link

You’re right, that would make more sense overall I think.

You’re right, that would make more sense overall I think.
Mikaela commented 2019-11-11 09:27:42 +00:00 (Migrated from github.com)
Copy Link

Trai comments:

Mikaela, if we make an announcement out of it, let's also include the r/PTIO post that Liz referenced in your linked pull request: https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/
It's more informative, and includes links to other posts that include SP's response (such as it is).
It'll let readers go as deep as they'd like to go.

So should I:

  • revert ff5ef961f1 ?
  • move the warning to bottom and add link to Privacytools subreddit?
Trai comments: > Mikaela, if we make an announcement out of it, let's also include the r/PTIO post that Liz referenced in your linked pull request: https://www.reddit.com/r/StartpageSearch/comments/dicp03/startpage_is_now_owned_by_an_advertising_company/ It's more informative, and includes links to other posts that include SP's response (such as it is). It'll let readers go as deep as they'd like to go. So should I: * revert https://github.com/privacytoolsIO/privacytools.io/pull/1410/commits/ff5ef961f1fb4ce34948ea046d85358c1e3ad6fe ? * move the warning to bottom and add link to Privacytools subreddit?
blacklight447 commented 2019-11-11 10:15:29 +00:00 (Migrated from github.com)
Copy Link

I would just remove startpage, add nothing else, then publish a blog explaining the removal.

I would just remove startpage, add nothing else, then publish a blog explaining the removal.
LizMcIntyre commented 2019-11-11 15:02:56 +00:00 (Migrated from github.com)
Copy Link

I would just remove startpage, add nothing else, then publish a blog explaining the removal.

That could work, too. Less disruptive to the flow and tradition, as pointed out.

> I would just remove startpage, add nothing else, then publish a blog explaining the removal. That could work, too. Less disruptive to the flow and tradition, as pointed out.
nitrohorse (Migrated from github.com) approved these changes 2019-11-11 17:19:50 +00:00
dawidpotocki (Migrated from github.com) approved these changes 2019-11-11 17:21:04 +00:00
jonah reviewed 2019-11-12 22:20:06 +00:00
jonah left a comment

https://blog.privacytools.io/delisting-startpage/

https://blog.privacytools.io/delisting-startpage/
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
blacklight447
djoate
nitrohorse
dawidpotocki
Labels
Clear labels   
🔍🤖 Search Engines

   
approved

approved, waiting for a PR

  
dependencies

Pull requests that update a dependency file

  
duplicate

   
feedback wanted

   
high priority

   
I2P

The Invisible Internet Project (I2P)

  
iOS

   
low priority

   
OS

Operating Systems

  
Self-contained networks

   
Social media

   
stale

A label for stalebot if it gets added

  
streaming

Anything related to media streaming.

  
todo

   
Tor

Anything covering the Tor network

  
WIP

active work in progress, do not merge or PR (yet)!

  
wontfix

Issues or bugs that will not be fixed and/or do not have significant impact on the project.

  
XMPP

Extensible Messaging and Presence Protocol

  
[m]

Matrix protocol

  
₿ cryptocurrency

   
ℹ️ help wanted

   
↔️ file sharing

   
⚙️ web extensions

Browser Extension related issues

  
✨ enhancement

   
❌ software removal

   
💬 discussion

   
🤖 Android

   
🐛 bug

   
💢 conflicting

   
📝 correction

Correction of content on the website

  
🆘 critical

   
📧 email

   
🔒 file encryption

   
📁 file storage

   
🦊 Firefox

Firefox & forks, about:config etc.

  
💻 hardware

   
🌐 hosting

   
🏠 housekeeping

Anything primarily related to site cleanup.

  
🔐 password managers

   
🧰 productivity tools

   
🔎 research required

   
🌐 Social News Aggregators

   
🆕 software suggestion

   
👥 team chat

   
🔒 VPN

Virtual Private Network

  
🌐 website issue

*Technical* issues with the website.

  
🚫 Windows

   
👁️ browsers

   
🖊️ digital notebooks

   
🗄️ DNS

Domain Name System

  
🗨️ instant messaging (im)

   
🇦🇶 translations

Anything covering a translated version of the site

No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1410
No description provided.
Delete Branch "delist-startpage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?