privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Add media assets to IPFS #1374

Open
jonah wants to merge 6 commits from ipfs into master
pull from: ipfs
merge into: privacyguides:master
Conversation 5 Commits 6 Files Changed 43 +159 -159
jonah commented 2019-10-03 03:14:17 +00:00
Owner
Copy Link

Description

Testing

Related: #1373

Check List

<!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Testing Related: #1373 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).
netlify[bot] commented 2019-10-03 03:15:08 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

Deploy preview for privacytools-io ready!

Built with commit f0965719ee

https://deploy-preview-1374--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit f0965719ee355da55fa40c1642898929040ccd75 https://deploy-preview-1374--privacytools-io.netlify.com
jonah commented 2019-10-03 03:18:41 +00:00
Author
Owner
Copy Link

Hmm. At a glance, having a CSP might be fundamentally incompatible with how IPFS operates which might make this change impossible.

<meta http-equiv="Content-Security-Policy" content="default-src 'none'; script-src 'self' 'unsafe-inline' https://*.privacytools.io 127.0.0.1; style-src 'self' 'unsafe-inline' 127.0.0.1; img-src 'self' data: https://*.privacytools.io 127.0.0.1; object-src 'none'; frame-src https://stats.privacytools.io; font-src 'self'; manifest-src 'self';">
Hmm. At a glance, having a CSP might be fundamentally incompatible with how IPFS operates which might make this change impossible. --- ``` <meta http-equiv="Content-Security-Policy" content="default-src 'none'; script-src 'self' 'unsafe-inline' https://*.privacytools.io 127.0.0.1; style-src 'self' 'unsafe-inline' 127.0.0.1; img-src 'self' data: https://*.privacytools.io 127.0.0.1; object-src 'none'; frame-src https://stats.privacytools.io; font-src 'self'; manifest-src 'self';"> ```
Mikaela commented 2019-10-05 16:02:48 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

I wonder if the IPFS gateway should be a variable in _config.yml like I do with mikaela.info ?

I wonder if the IPFS gateway should be a variable in `_config.yml` like [I do with mikaela.info](https://github.com/Mikaela/mikaela.github.io/blob/f75d710b6ea3f38fd4b532301e7f08f8acf86b9e/_config.yml#L35-L43) ?
jonah commented 2019-10-05 22:54:02 +00:00
Author
Owner
Copy Link

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify).

Obviously if this were merged the IPFS gateway we host would get a little more attention than it currently does :P

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify). Obviously if this were merged the IPFS gateway we host would get a little more attention than it currently does :P
Mikaela commented 2019-10-06 11:27:17 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify).

What if the gateway ever gets renamed or there will be IPFS gateway redirector instead or something like that? I think it could also be beneficial for forks and maybe local testing.

> I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify). What if the gateway ever gets renamed or there will be IPFS gateway redirector instead or something like that? I think it could also be beneficial for forks and maybe local testing.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1374
No description provided.
Delete Branch "ipfs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?