Add media assets to IPFS #1374

jonah · 2019-10-03T03:14:17Z

jonah commented

2019-10-03 03:14:17 +00:00

Description

Testing

Related: #1373

Check List

I have read and understand the contributing guidelines.

## Description Testing Related: #1373 #### Check List  - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md).

netlify[bot] commented

2019-10-03 03:15:08 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit f0965719ee

https://deploy-preview-1374--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit f0965719ee355da55fa40c1642898929040ccd75 https://deploy-preview-1374--privacytools-io.netlify.com

jonah commented

2019-10-03 03:18:41 +00:00

Hmm. At a glance, having a CSP might be fundamentally incompatible with how IPFS operates which might make this change impossible.

<meta http-equiv="Content-Security-Policy" content="default-src 'none'; script-src 'self' 'unsafe-inline' https://*.privacytools.io 127.0.0.1; style-src 'self' 'unsafe-inline' 127.0.0.1; img-src 'self' data: https://*.privacytools.io 127.0.0.1; object-src 'none'; frame-src https://stats.privacytools.io; font-src 'self'; manifest-src 'self';">

Hmm. At a glance, having a CSP might be fundamentally incompatible with how IPFS operates which might make this change impossible. --- ``` <meta http-equiv="Content-Security-Policy" content="default-src 'none'; script-src 'self' 'unsafe-inline' https://*.privacytools.io 127.0.0.1; style-src 'self' 'unsafe-inline' 127.0.0.1; img-src 'self' data: https://*.privacytools.io 127.0.0.1; object-src 'none'; frame-src https://stats.privacytools.io; font-src 'self'; manifest-src 'self';"> ```

Mikaela commented

2019-10-05 16:02:48 +00:00

(Migrated from github.com)

I wonder if the IPFS gateway should be a variable in _config.yml like I do with mikaela.info ?

I wonder if the IPFS gateway should be a variable in `_config.yml` like [I do with mikaela.info](https://github.com/Mikaela/mikaela.github.io/blob/f75d710b6ea3f38fd4b532301e7f08f8acf86b9e/_config.yml#L35-L43) ?

jonah commented

2019-10-05 22:54:02 +00:00

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify).

Obviously if this were merged the IPFS gateway we host would get a little more attention than it currently does :P

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify). Obviously if this were merged the IPFS gateway we host would get a little more attention than it currently does :P

Mikaela commented

2019-10-06 11:27:17 +00:00

(Migrated from github.com)

I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify).

What if the gateway ever gets renamed or there will be IPFS gateway redirector instead or something like that? I think it could also be beneficial for forks and maybe local testing.

> I don't see why we'd ever change it though. I wouldn't want to trust a third-party gateway for non-IPFS users (especially since most traffic would be going to whatever gateway we specify). What if the gateway ever gets renamed or there will be IPFS gateway redirector instead or something like that? I think it could also be beneficial for forks and maybe local testing.

This repo is archived. You cannot comment on pull requests.

No reviewers