tokens for selfhosted OS, and corred missing token for OS warning in … #1214

Open
yeet648 wants to merge 9 commits from yeet648/i18n into i18n
yeet648 commented 2019-08-24 19:47:22 +00:00 (Migrated from github.com)

…OS page.

tokens for selfhosted os, filesync, and added missing token in OS page. Supports issue #1106

Resolves: #none

Check List

  • Netlify preview for the mainly edited page:

  • Code Repository (if applicable):

…OS page. <!-- PLEASE READ OUR CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## tokens for selfhosted os, filesync, and added missing token in OS page. Supports issue #1106 Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line --> #### Check List <!-- Please add an x in each box below, like so: [x] --> - [ x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x ] I have [listed the source code](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). - [ x] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software). - [ x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). * Netlify preview for the mainly edited page: <!-- link or Non Applicable? Edit this in afterwards --> * Code Repository (if applicable):
jonah reviewed 2019-08-24 19:47:22 +00:00
yeet648 commented 2019-08-24 20:35:17 +00:00 (Migrated from github.com)

hello maintainers, on the build break does jekyll need to be updated on the build machine? After a pull I got a build warning and had to run "bundle install" again for my local build to work and wonder if this is same here.

hello maintainers, on the build break does jekyll need to be updated on the build machine? After a pull I got a build warning and had to run "bundle install" again for my local build to work and wonder if this is same here.
Mikaela commented 2019-08-24 21:28:30 +00:00 (Migrated from github.com)

I think it's just that Travis is unhappy with your changes.

I think it's just that Travis is unhappy with your changes. * https://travis-ci.com/privacytoolsIO/privacytools.io/builds/124474079
yeet648 commented 2019-08-25 01:39:48 +00:00 (Migrated from github.com)

fwiw I get this same build break when i clone i18n without my changes.

fwiw I get this same build break when i clone i18n without my changes.

This is an issue with the i18n branch in general since 0c840011fe, and I am not sure why... Maybe the i18n plugin we're using was updated? But it's not an issue with this PR 👍

I'll review this in a bit, thanks! 🙏

This is an issue with the i18n branch in general since 0c840011fe0aa9b3dba4ab7b775a2ec8de71b023, and I am not sure why... Maybe the i18n plugin we're using was updated? But it's not an issue with this PR 👍 I'll review this in a bit, thanks! 🙏
yeet648 commented 2019-09-10 22:49:39 +00:00 (Migrated from github.com)

@jonahAragon, no rush here on the review... just wanted to let you know I'll keep chipping away on token-izing these pages until you tell me otherwise.

@jonahAragon, no rush here on the review... just wanted to let you know I'll keep chipping away on token-izing these pages until you tell me otherwise.
djoate (Migrated from github.com) requested changes 2019-11-09 06:11:14 +00:00
@ -337,0 +353,4 @@
freenet_descr: "Freenet is a peer-to-peer platform for censorship-resistant communication. It uses a decentralized distributed data store to keep and deliver information, and has a suite of free software for publishing and communicating on the Web without fear of censorship. Both Freenet and some of its associated tools were originally designed by Ian Clarke, who defined Freenet's goal as providing freedom of speech on the Internet with strong anonymity protection."
related_information: "Related Information"
true_stories: "- True stories from the dark side of the Internet."
worth_mentioning: "Worth Mentioning"
djoate (Migrated from github.com) commented 2019-11-09 06:01:01 +00:00

It is worth mentioning that worth_mentioning should just be a global string as it's used in many places. This goes for all the other worth_mentioning keys in the yaml

It is worth mentioning that `worth_mentioning` should just be a global string as it's used in many places. This goes for all the other `worth_mentioning` keys in the yaml
@ -337,0 +361,4 @@
yggdrasil_descr: "- An early-stage implementation of a fully end-to-end encrypted IPv6 network. It is lightweight, self-arranging, supported on multiple platforms and allows pretty much any IPv6-capable application to communicate securely with other Yggdrasil nodes. Yggdrasil does not require you to have IPv6 Internet connectivity - it also works over IPv4."
yggdrasil_warning: "The project is currently in early stages but it is being actively developed."
yggdrasil_danger: "Yggdrasil doesn't have a goal of providing anonymity and your peers know your IP address unless you are only using Tor/I2P peers."
experimental: "experimental"
djoate (Migrated from github.com) commented 2019-11-09 06:03:56 +00:00

related_information is already a global string

`related_information` is already a global string
@ -337,0 +372,4 @@
real_time_communication:
title: "Real-Time Communication"
descr: "Discover secure and private ways to communicate with others online without letting any third parties read your messages."
instant_messenger:
djoate (Migrated from github.com) commented 2019-11-09 06:10:44 +00:00

We should probably decide on whether to keep these tags all lowercase ("experimental") or not ("Experimental").
Notice that at https://www.privacytools.io/software/real-time-communication/#im we have "Experimental" and "Warning", but at https://www.privacytools.io/software/networks/ we have "experimental" and "privacy warning"

We should probably decide on whether to keep these tags all lowercase ("experimental") or not ("Experimental"). Notice that at https://www.privacytools.io/software/real-time-communication/#im we have "Experimental" and "Warning", but at https://www.privacytools.io/software/networks/ we have "experimental" and "privacy warning"
@ -337,0 +392,4 @@
other_omemo: "Other OMEMO ready clients"
kontalk: " - A community-driven instant messaging network. Supports end-to-end encryption. Both client-to-server and server-to-server channels are fully encrypted."
keybase: " End-to-end encrypted messaging with social verification."
keybase_tooltip: "This software relies on a closed-source central server."
djoate (Migrated from github.com) commented 2019-11-09 06:08:11 +00:00

See above: worth_mentioning is better as a global string

See above: `worth_mentioning` is better as a global string
djoate (Migrated from github.com) commented 2019-11-09 06:07:27 +00:00

related_information is already a global string

`related_information` is already a global string
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1214
No description provided.