Combine "worth mentioning" sections in DNS page #1164

jonah · 2019-08-16T04:18:35Z

nitrohorse commented

2019-08-16 04:18:35 +00:00

(Migrated from github.com)

Description

This PR combines the two "Worth Mentioning" sections on the DNS page into one which seems a bit more cleaner and efficient. The vocabulary has also been updated for consistency.

https://deploy-preview-1164--privacytools-io.netlify.com/providers/dns/#icanndns

Resolves: N/A

Check List

I have read and understand CONTRIBUTING.md.
~~I have listed the source code for this project in source_code.md.~~
~~This project is free/libre software.~~
~~This project has an associated discussion.~~

Code Repository (if applicable): N/A

## Description This PR combines the two "Worth Mentioning" sections on the DNS page into one which seems a bit more cleaner and efficient. The vocabulary has also been updated for consistency. https://deploy-preview-1164--privacytools-io.netlify.com/providers/dns/#icanndns Resolves: N/A #### Check List  - [x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - ~~[ ] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).~~ - ~~[ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).~~ - ~~[ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).~~ Code Repository (if applicable): N/A

netlify[bot] commented

2019-08-16 04:19:29 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 6c46c0f11d

https://deploy-preview-1164--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 6c46c0f11d43ab8f90104a7532a1e5342ee9c29e https://deploy-preview-1164--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-08-16 16:31:33 +00:00

Mikaela (Migrated from github.com) left a comment

Looks good to me, I just have minor suggestion as Pi hole also supports other hardware.

_includes/sections/dns.html

Mikaela (Migrated from github.com) commented

2019-08-16 16:31:05 +00:00

      <li><a href="https://pi-hole.net/">Pi-hole</a> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li>

```suggestion <li><a href="https://pi-hole.net/">Pi-hole</a> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li> ```