privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Combine "worth mentioning" sections in DNS page #1164

Merged
nitrohorse merged 2 commits from dns-page-updates into master 2019-08-16 21:26:47 +00:00
Conversation 4 Commits 2 Files Changed 1 +6 -15
nitrohorse commented 2019-08-16 04:18:35 +00:00 (Migrated from github.com)
Copy Link

Description

This PR combines the two "Worth Mentioning" sections on the DNS page into one which seems a bit more cleaner and efficient. The vocabulary has also been updated for consistency.

https://deploy-preview-1164--privacytools-io.netlify.com/providers/dns/#icanndns

Resolves: N/A

Check List

Code Repository (if applicable): N/A

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description This PR combines the two "Worth Mentioning" sections on the DNS page into one which seems a bit more cleaner and efficient. The vocabulary has also been updated for consistency. https://deploy-preview-1164--privacytools-io.netlify.com/providers/dns/#icanndns Resolves: N/A #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - ~~[ ] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).~~ - ~~[ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).~~ - ~~[ ] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues).~~ Code Repository (if applicable): N/A
netlify[bot] commented 2019-08-16 04:19:29 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 6c46c0f11d

https://deploy-preview-1164--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 6c46c0f11d43ab8f90104a7532a1e5342ee9c29e https://deploy-preview-1164--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2019-08-16 16:31:33 +00:00
Mikaela (Migrated from github.com) left a comment

Looks good to me, I just have minor suggestion as Pi hole also supports other hardware.

Looks good to me, I just have minor suggestion as Pi hole also supports other hardware.
_includes/sections/dns.html
Mikaela (Migrated from github.com) commented 2019-08-16 16:31:05 +00:00 
      <li><a href="https://pi-hole.net/">Pi-hole</a> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li>
```suggestion <li><a href="https://pi-hole.net/">Pi-hole</a> - A network-wide DNS server mainly for the Raspberry Pi. Blocks ads, tracking, and malicious domains for all devices on your network.</li> ```
Mikaela (Migrated from github.com) approved these changes 2019-08-16 17:04:42 +00:00
jonah approved these changes 2019-08-16 21:26:34 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Mikaela
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
✨ enhancement
🗄️ DNS
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1164
No description provided.
Delete Branch "dns-page-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?