I18n #1163

jonah · 2019-08-15T03:30:43Z

yeet648 commented

2019-08-15 03:30:43 +00:00

(Migrated from github.com)

additional changes for issue #1106. Added tokens for:

router-firmware
PC OS pages
mobile OS

Resolves: #none <!-- The number of the issue that is resolved by this pull request. If there is none, feel free to delete this line

Check List

[ x] I have read and understand CONTRIBUTING.md.
[n/a ] I have listed the source code for this project in source_code.md.
[x ] This project is free/libre software.
[ x] This project has an associated discussion.

Code Repository (if applicable):

## additional changes for issue #1106. Added tokens for: - router-firmware - PC OS pages - mobile OS Resolves: #none  - [ x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [n/a ] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). - [x ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software). - [ x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). Code Repository (if applicable):

jonah commented

2019-08-16 19:27:46 +00:00

Thank you! Merging this to i18n in a second. One thing, we don't need titles added because the names of things aren't English words. So we don't need lineageos_title: "LineageOS" added, but we do need other headers like mobile_operating_systems: "Mobile Operating Systems", and if the brand name is in a description like lineageos_descr: "LineageOS is a free and open-source... that is good too 👍

Thank you! Merging this to i18n in a second. One thing, we don't need titles added because the names of things aren't English words. So we **don't** need `lineageos_title: "LineageOS"` added, but we **do** need other headers like `mobile_operating_systems: "Mobile Operating Systems"`, and if the brand name is in a description like `lineageos_descr: "LineageOS is a free and open-source...` that is good too 👍

yeet648 commented

2019-08-17 20:37:07 +00:00

(Migrated from github.com)

@JonahAragon got it excluding the product name and also see the global contrib token as well. I will use that on my next update.

❤️ 1

This repo is archived. You cannot comment on pull requests.

No reviewers