Small Improvements #1149

jonah · 2019-08-13T04:55:14Z

jonah commented

2019-08-13 04:55:14 +00:00

Reordered the sub-navigations for "browser" and "os" to make more logical sense, not sure why they were alphabetized with the rest.

Renamed sections to be browser-agnostic.

Added support for adding links to platform icons in cardv2.html:

Icons left blank (as they all currently are) will remain functionally the same, for example:

firefox=""
chrome=""
safari=""
opera=""
edge=""
android=""

However, adding a link to one:

chrome="https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm?hl=en"

...will add a hyperlink to that icon (the same way the Git icons are currently linked), allowing us to link to download pages for various platforms. All platform icons now support this functionality, although it will be most useful for linking browser extensions. I did not find and add links to each platform in this PR.

Reordered the sub-navigations for "browser" and "os" to make more logical sense, not sure why they were alphabetized with the rest. Renamed sections to be browser-agnostic. Added support for adding links to platform icons in cardv2.html: Icons left blank (as they all currently are) will remain functionally the same, for example: ``` firefox="" chrome="" safari="" opera="" edge="" android="" ``` However, adding a link to one: ``` chrome="https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm?hl=en" ``` ...will add a hyperlink to that icon (the same way the Git icons are currently linked), allowing us to link to download pages for various platforms. All platform icons now support this functionality, although it will be most useful for linking browser extensions. I did not find and add links to each platform in this PR.

🎉 1

Mikaela (Migrated from github.com) reviewed 2019-08-13 04:55:14 +00:00

blacklight447 (Migrated from github.com) reviewed 2019-08-13 04:55:14 +00:00

nitrohorse (Migrated from github.com) reviewed 2019-08-13 04:55:14 +00:00

netlify[bot] commented

2019-08-13 04:56:06 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit d8e913525e

https://deploy-preview-1149--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit d8e913525e74360cfb2f3fce86f91470e479c316 https://deploy-preview-1149--privacytools-io.netlify.com

nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:21:18 +00:00

_includes/nav.html

nitrohorse (Migrated from github.com) commented

2019-08-13 06:21:18 +00:00

I think we could change the title to match, "Recommended Browser Add-ons"

nitrohorse (Migrated from github.com) reviewed 2019-08-13 06:22:47 +00:00

nitrohorse (Migrated from github.com) left a comment

This is great! 👍

This is great! :+1:

Mikaela (Migrated from github.com) reviewed 2019-08-13 08:38:11 +00:00

Mikaela (Migrated from github.com) left a comment

👍

:+1:

blacklight447 (Migrated from github.com) reviewed 2019-08-13 09:29:46 +00:00

jonah reviewed 2019-08-13 17:33:33 +00:00

_includes/nav.html

jonah commented

2019-08-13 17:33:33 +00:00

            <a class="dropdown-item" href="/browsers/#addons"><i class="far fa-list-alt fa-fw"></i> Browser Add-ons</a>

```suggestion <a class="dropdown-item" href="/browsers/#addons"><i class="far fa-list-alt fa-fw"></i> Browser Add-ons</a> ```

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1149