Archived
Real time communication improvements #1147
Merged
Mikaela
merged 19 commits from 2019-08-17 02:33:33 +00:00
rtc-improvements into master
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
:mag:🤖 Search Engines
I2P
OS
Self-contained networks
Social media
Tor
WIP
XMPP
[m]
approved
dependencies
duplicate
feedback wanted
high priority
iOS
low priority
stale
streaming
todo
wontfix
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
🆕 software suggestion
🆘 critical
🇦🇶 translations
🌐 Social News Aggregators
🌐 hosting
🌐 website issue
🏠 housekeeping
🐛 bug
👁️ browsers
👥 team chat
💢 conflicting
💬 discussion
💻 hardware
📁 file storage
📝 correction
📧 email
🔎 research required
🔐 password managers
🔒 VPN
🔒 file encryption
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🚫 Windows
🤖 Android
🦊 Firefox
🧰 productivity tools
The Invisible Internet Project (I2P)
Operating Systems
Anything covering the Tor network
active work in progress, do not merge or PR (yet)!
Extensible Messaging and Presence Protocol
Matrix protocol
approved, waiting for a PR
Pull requests that update a dependency file
A label for stalebot if it gets added
Anything related to media streaming.
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
Browser Extension related issues
Anything covering a translated version of the site
*Technical* issues with the website.
Anything primarily related to site cleanup.
Correction of content on the website
Virtual Private Network
Domain Name System
Firefox & forks, about:config etc.
No labels
Milestone
No items
No Milestone
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#1147
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Resolves: #1137
Resolves: #967
References: #1071
List security audits for:
Preview: https://deploy-preview-1147--privacytools-io.netlify.com/software/real-time-communication/
Deploy preview for privacytools-io ready!
Built with commit
9235f50abchttps://deploy-preview-1147--privacytools-io.netlify.com
My usual commentary
See #967
I copied this style from XMPP again.
This is the same order we list them in on the page.
I try to address the concern of many being already listed and now this section has only less known software.
See also the related information section
I wonder if a warning on WebRTC being required should be here?
I suggested it in #1137 and thus had to remove encrypted from the title. @nitrohorse OKed it, but I understand if you wish to remove it.
I think Mumble may be more beginner friendly than Linphone and currently the only other suggestion is Jitsi Meet, which requires WebRTC that many are going to have disabled thanks to the Firefox tweaks.
I think this may make Mumble more privacy friendly than Jitsi Meet, presuming logging is disabled. Tor Browser disables WebRTC, doesn't it?
@@ -137,1 +138,4 @@Ring/Jami: https://git.jami.net/savoirfairelinux## Team chatI corrected the source code location for Jami. Otherwise I just moved things around.
Would there be any point in listing Signal desktop separately and saying that it needs to be linked to Signal mobile?
Made some changes at https://github.com/Mikaela/privacytools.io/pull/1 I'd like to see included, otherwise LGTM.
I also can't decide if we should include a
Supports VoIPbadge on the Instant Messengers that support VoIP, because we removed them from the Voice section. I just want it to be clear that Signal/Wire also support Voice. But maybe the warning listed is enough. I'm very on the fence about it. If we do want to add a badge like that though, I need the cardv2.html changes I made in #1148 to be merged first.Minor typo:
IndependentYeah, just validated myself and it's disabled in
about:config.@@ -55,3 +54,3 @@<li><a href="https://gajim.org/">Gajim</a> (FreeBSD, Linux, Windows) - An open source fully featured XMPP client. <span class="badge badge-success">OMEMO</span></li><li><a href="https://monal.im/">Monal</a> (iOS, MacOS) - An XMPP client in active development. <span class="badge badge-success">OMEMO</span></li><li><a href="https://monal.im/">Monal</a> (iOS, MacOS) - An XMPP client in active development. <span class="badge badge-success">OMEMO</span> <span class="badge badge-success">VoIP</span></li><li><a href="https://omemo.top/">Other OMEMO ready clients</a>.</li>Minor suggestion; remove "a":
Gives you full control...Small suggestion: add "the";
in the instantI would say so since we encourage it's disablement: https://www.privacytools.io/browsers/#webrtc
Looking it over I think adding a badge would be a good idea. The callout in the warning alert is kind of easy to miss.
Otherwise, LGTM too!
LGTM once comments are resolved 👍
I think this became obsolete.
So I just need to warn about WebRTC and Minor suggestion; remove "a": Gives you full control...?
Do I need to somehow add the supports VoIP label or will @JonahAragon do that later?
@JonahAragon @nitrohorse How about this?
I am going to cancel that last commit though as I think it looks better with the space.
K last change: Since #1148 was merged the changes I pushed to Mikaela#2 make more sense for the VoIP and other badges.
@JonahAragon Did you remove the warning label?
No, looking better the warning is there, but it's not visible on live site. I don't know when I can look at it better to fix it.
I will grant permissions to write in my fork in case it helps.
I don't think I made any changes here. The issue is the backslashes, not sure where those are from.
👍🏼