Archived
Use js-beautify for formatting HTML #1089
Closed
nitrohorse wants to merge 21 commits from
add-beautify into master
pull from: add-beautify
merge into: :master
:master
:dependabot/bundler/nokogiri-1.13.6
:dependabot/bundler/addressable-2.8.0
:freddy-m-patch-3
:pr-add_RemoveMyPhone_sponsor
:pr-browser_cleanup_1257_1328_1430
:freddy-m-patch-2
:freddy-m-patch-1
:pr-vpn_hated_one_video
:cdn
:update-nitrohorse-image
:promote-metager-to-card
:hardware
:pr-add_azirevpn
:pr-add_mailfence
:shop
:1673
:pr/1658
:i18n-simple
:sponsorship-edits-nov2019
:i18n
:ipfs
:blacklight447-ptio-patch-3
:blog
:remove-windows-icons
:pr/1147
:i18n-testing
:add-beautify
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
:mag:🤖 Search Engines
I2P
OS
Self-contained networks
Social media
Tor
WIP
XMPP
[m]
approved
dependencies
duplicate
feedback wanted
high priority
iOS
low priority
stale
streaming
todo
wontfix
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
🆕 software suggestion
🆘 critical
🇦🇶 translations
🌐 Social News Aggregators
🌐 hosting
🌐 website issue
🏠 housekeeping
🐛 bug
👁️ browsers
👥 team chat
💢 conflicting
💬 discussion
💻 hardware
📁 file storage
📝 correction
📧 email
🔎 research required
🔐 password managers
🔒 VPN
🔒 file encryption
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🚫 Windows
🤖 Android
🦊 Firefox
🧰 productivity tools
The Invisible Internet Project (I2P)
Operating Systems
Anything covering the Tor network
active work in progress, do not merge or PR (yet)!
Extensible Messaging and Presence Protocol
Matrix protocol
approved, waiting for a PR
Pull requests that update a dependency file
A label for stalebot if it gets added
Anything related to media streaming.
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
Browser Extension related issues
Anything covering a translated version of the site
*Technical* issues with the website.
Anything primarily related to site cleanup.
Correction of content on the website
Virtual Private Network
Domain Name System
Firefox & forks, about:config etc.
No labels
🏠 housekeeping
Milestone
No items
No Milestone
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#1089
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Description
Related: https://github.com/privacytoolsIO/privacytools.io/pull/900
This PR introduces "js-beautify" for auto-formatting the HTML code on code commits and git pushes based on specified rules in
.jsbeautifyrc(here's a larger example). The rule I added for now includes using tabs over spaces. Overall, this tooling will increase style consistency and maintainability for contributors 😄Example of trying to commit unformatted code:
Example of committing unformatted code and Travis failing the build:
Alternatively, @dawidpotocki mentioned Prettier which could also do this job. I also have a working, local branch for that but felt Beautify to be more tailored and simpler for our needs at the moment. I also ran into some weird HTML formatting issues (such as https://github.com/prettier/prettier-vscode/issues/646) when using Prettier.
Deploy preview for privacytools-io ready!
Built with commit
c9f9cf255bhttps://deploy-preview-1089--privacytools-io.netlify.com
Deploy preview for privacytools-io ready!
Built with commit
c7937a241ahttps://deploy-preview-1089--privacytools-io.netlify.com
Okay
Still okay
@@ -2,3 +2,3 @@<div class="alert alert-success" role="alert"><strong>All providers listed here are operating outside the US and support <a data-toggle="tooltip" data-placement="bottom" data-original-title="When sending or receiving emails, if both the sending and receiving servers support TLS encryption, the email is sent between servers using an encrypted connection.">SMTP TLS.</a> The table is sortable.</strong><strong>All providers listed here are operating outside the US and support <a data-toggle="tooltip" data-placement="bottom" data-original-title="When sending or receiving emails, if both the sending and receiving servers support TLS encryption, the email is sent between servers using an encrypted connection.">SMTP TLS.</a> The table is sortable.</strong>This doesn't seem right
@@ -2,3 +2,3 @@<div class="alert alert-success" role="alert"><strong>All providers listed here are operating outside the US and support <a data-toggle="tooltip" data-placement="bottom" data-original-title="When sending or receiving emails, if both the sending and receiving servers support TLS encryption, the email is sent between servers using an encrypted connection.">SMTP TLS.</a> The table is sortable.</strong><strong>All providers listed here are operating outside the US and support <a data-toggle="tooltip" data-placement="bottom" data-original-title="When sending or receiving emails, if both the sending and receiving servers support TLS encryption, the email is sent between servers using an encrypted connection.">SMTP TLS.</a> The table is sortable.</strong>Good catch! Fixed.
What... hmm
Okay, fixed.
This looks scarily big to me, but there are conflicting files so I won't read deeper right now.
Yeah, I'm unsure what direction we want to take with this at the moment. It should be fairly straightforward to get auto-formatting tooling integrated, but for the proposed solutions (Prettier and JS-Beautify) both will introduce NodeJS to the project which will add some complexity and increase maintainability a bit (making sure packages are up-to-date)...
Going to close this until the right formatter tool is decided 👍