privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Extend Hardware Section #989

Open
ghbjklhv wants to merge 50 commits from ghbjklhv/patch-6 into master
pull from: ghbjklhv/patch-6
merge into: privacyguides:master
Conversation 16 Commits 50 Files Changed 20 +226
ghbjklhv commented 2019-06-15 04:23:11 +00:00 (Migrated from github.com)
Copy Link

Description: Add Extended Hardware Section based on #616 and #904
What was changed: I recommend looking through the preview:
https://deploy-preview-989--privacytools-io.netlify.com/classic/#laptops
Why isn't ___ blank listed?: Only privacy and free software supporting projects are listed.
Basically all recommendations have had to some degree of audit. If you think I skipped something feel free to recommend changes in the comments!

Edits from maintainers are welcome!

**Description**: Add Extended Hardware Section based on #616 and #904 **What was changed**: I recommend looking through the preview: https://deploy-preview-989--privacytools-io.netlify.com/classic/#laptops **Why isn't ___ blank listed?**: Only privacy and free software supporting projects are listed. Basically all recommendations have had to some degree of audit. If you think I skipped something feel free to recommend changes in the comments! Edits from maintainers are welcome!
Vincevrp (Migrated from github.com) reviewed 2019-06-15 04:23:11 +00:00
blacklight447 (Migrated from github.com) reviewed 2019-06-15 04:23:11 +00:00
privacytoolsIO (Migrated from github.com) reviewed 2019-06-15 04:23:11 +00:00
netlify[bot] commented 2019-06-15 04:40:53 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 9f55209641

https://deploy-preview-989--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 9f55209641e90580fe0ddb11c9f72aca607ec714 https://deploy-preview-989--privacytools-io.netlify.com
jonah requested changes 2019-06-23 20:15:16 +00:00
_includes/sections/key-manager.html
jonah commented 2019-06-23 20:13:48 +00:00

Something about this line is broken in the preview.

image

Something about this line is broken in the preview. ![image](https://user-images.githubusercontent.com/3637842/59981480-78d99000-95c9-11e9-864c-491605955386.png)
ghbjklhv (Migrated from github.com) reviewed 2019-06-24 02:35:56 +00:00
_includes/sections/key-manager.html
ghbjklhv (Migrated from github.com) commented 2019-06-24 02:35:56 +00:00

Sincerest apologies, I commented this out for /old and must've forgotten to fix/un-comment it. You may want to look into this as well: /diff-88e96f1b7cc4c9bc9fa893113a8e0aacR38

I'm not certain what the issue is.

Sincerest apologies, I commented this out for /old and must've forgotten to fix/un-comment it. You may want to look into this as well: [/diff-88e96f1b7cc4c9bc9fa893113a8e0aacR38](https://github.com/privacytoolsIO/privacytools.io/pull/989/files#diff-88e96f1b7cc4c9bc9fa893113a8e0aacR38) I'm not certain what the issue is.
ghbjklhv (Migrated from github.com) reviewed 2019-06-24 02:48:27 +00:00
_includes/sections/key-manager.html
ghbjklhv (Migrated from github.com) commented 2019-06-24 02:48:27 +00:00

To verify that Key Manager's is indeed the problem, I'll comment it out.
If this is the issue, I'm not certain how it is different from the other cards.

To verify that Key Manager's is indeed the problem, I'll comment it out. If this is the issue, I'm not certain how it is different from the other cards.
ghbjklhv (Migrated from github.com) reviewed 2019-06-24 03:10:59 +00:00
_includes/sections/key-manager.html
ghbjklhv (Migrated from github.com) commented 2019-06-24 03:10:58 +00:00

Removing this line seems to enable it to load properly:

(<a href='https://github.com/Nitrokey/nitrokey-pro-firmware/issues/48'>more info</a>)

I will see if I can figure out why this line breaks it.

Removing this line seems to enable it to load properly: `(<a href='https://github.com/Nitrokey/nitrokey-pro-firmware/issues/48'>more info</a>)` I will see if I can figure out why this line breaks it.
ghbjklhv (Migrated from github.com) reviewed 2019-06-24 03:26:24 +00:00
_includes/sections/key-manager.html
ghbjklhv (Migrated from github.com) commented 2019-06-24 03:26:23 +00:00

https:// must be removed for some reason fixes in latest commit: 9f55209641

@JonahAragon

`https://` must be removed for some reason fixes in latest commit: https://github.com/privacytoolsIO/privacytools.io/pull/989/commits/9f55209641e90580fe0ddb11c9f72aca607ec714 @JonahAragon
jonah commented 2019-06-24 17:25:55 +00:00
Copy Link

@ghbjklhv do you not test your changes locally with bundle exec jekyll serve before pushing? lol

I'll take a look at these changes in a bit.

Edit: Oh I see you're making these changes on GitHub.com, that seems rather tedious 😝

@ghbjklhv do you not test your changes locally with `bundle exec jekyll serve` before pushing? lol I'll take a look at these changes in a bit. Edit: Oh I see you're making these changes on GitHub.com, that seems rather tedious 😝
👍 1
ghbjklhv commented 2019-06-24 18:04:05 +00:00 (Migrated from github.com)
Copy Link

@JonahAragon Yeah, I use the online editor now.

My computer always shows errors when compiling:

Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml
       Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly.
jekyll 3.1.6 | Error:  undefined method `config=' for #<Jekyll::Site:0x0055d37d225668>
Did you mean?  config

Sorry if my PR seems a bit messy. :P

I'll see if I can fix my Jekyll.....

@JonahAragon Yeah, I use the online editor now. My computer always shows errors when compiling: ``` Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly. Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly. Configuration file: /home/usr/Jekyll1/privacytools.io-patch-6/_config.yml Deprecation: The 'plugins' configurationoption has been renamed to 'plugins_dir'. Please update your config file accordingly. jekyll 3.1.6 | Error: undefined method `config=' for #<Jekyll::Site:0x0055d37d225668> Did you mean? config ``` Sorry if my PR seems a bit messy. :P I'll see if I can fix my Jekyll.....
WorryTheBirds12 commented 2019-07-30 01:09:42 +00:00 (Migrated from github.com)
Copy Link

@JonahAragon Are ya'll just waiting for #904 to clear up.
Or is something wrong with this post.

Hasn't been reviewed in over a month.

@JonahAragon Are ya'll just waiting for #904 to clear up. Or is something wrong with this post. Hasn't been reviewed in over a month.
😆 1
jonah requested changes 2019-08-03 19:21:45 +00:00
jonah left a comment

I really like this PR. I just need the SeaBIOS image fixed and then I'll approve this.

Long-term I also want to stop using card.html entirely on the site so we should switch everything to cardv2.html, but if you don't want to do that now we can make that change later and I'll merge this in the meantime.

I really like this PR. I just need the SeaBIOS image fixed and then I'll approve this. Long-term I also want to stop using `card.html` entirely on the site so we should switch everything to `cardv2.html`, but if you don't want to do that now we can make that change later and I'll merge this in the meantime.
_includes/sections/bios.html
@ -0,0 +10,4 @@
{% include card.html color="primary"
title="SeaBIOS"
image="/assets/img/tools/seabios.png"
jonah commented 2019-08-03 19:18:58 +00:00

This image seems to be broken?

This image seems to be broken?
ghbjklhv1 (Migrated from github.com) reviewed 2019-08-08 22:21:27 +00:00
_includes/sections/bios.html
@ -0,0 +10,4 @@
{% include card.html color="primary"
title="SeaBIOS"
image="/assets/img/tools/seabios.png"
ghbjklhv1 (Migrated from github.com) commented 2019-08-08 22:21:27 +00:00

Yes, Seabios doesn't seem to have a logo.
If it is required, they have a Wiki logo: https://www.coreboot.org/images/a/ae/Chip_tools.png

Github blocked my old account but edits from maintainers should be turned on.
Or, you can add if after merging.

Yes, Seabios doesn't seem to have a logo. If it is required, they have a Wiki logo: https://www.coreboot.org/images/a/ae/Chip_tools.png __________________ Github blocked my old account but edits from maintainers should be turned on. Or, you can add if after merging.
ghbjklhv1 commented 2019-10-12 04:08:05 +00:00 (Migrated from github.com)
Copy Link

Would it be possible for you to start a discussion thread for some of these on the forum?
Some of the products like the Librem 5 and EOMA68 have new status updates.[1][2]

@JonahAragon @Mikaela

Would it be possible for you to start a discussion thread for some of these on the forum? Some of the products like the Librem 5 and EOMA68 have new status updates.[[1](https://puri.sm/posts/librem-5-shipping-announcement/)][[2](https://www.crowdsupply.com/eoma68/micro-desktop/updates)] ______________________________________ @JonahAragon @Mikaela
Mikaela commented 2019-10-12 17:18:18 +00:00 (Migrated from github.com)
Copy Link

Hardware is not my cup of tea, so I prefer to not get involved with this PR.

@privacytoolsIO/editorial please see the previous comment.

Hardware is not my cup of tea, so I prefer to not get involved with this PR. @privacytoolsIO/editorial please see the previous comment.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Vincevrp
blacklight447
privacytoolsIO
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
💻 hardware
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#989
No description provided.
Delete Branch "ghbjklhv/patch-6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?