Reworked layout #705

2018-12-29T13:24:04Z

ghost commented

2018-12-29 13:24:04 +00:00

(Migrated from github.com)

Added FA icons, removed unnecessary sections

(@c0rdis #704)

Added FA icons, removed unnecessary sections (@c0rdis #704)

ghost commented

2018-12-29 13:29:30 +00:00

(Migrated from github.com)

Which unnecessary sections did you remove?

c0rdis commented

2018-12-29 13:36:49 +00:00

(Migrated from github.com)

"Share" with a dropdown and "Twitter", as both of them are immediately available when following "Participate", but imho looks much cleaner. Also, removed duplicates from "Software" section (which are already present in "Provider"), such as "DNS", "Social networks" and "Search engines"

c0rdis commented

2018-12-29 13:38:20 +00:00

(Migrated from github.com)

Planning to also change a bit to more clearly reflect current structure, possibly copying "Most important" section from privacytools.ru. Hopefully tomorrow / next week, so will be a separate PR.

Vincevrp commented

2018-12-29 16:48:34 +00:00

(Migrated from github.com)

Could you add some screenshots?

c0rdis commented

2018-12-29 21:57:07 +00:00

(Migrated from github.com)

![header](https://user-images.githubusercontent.com/10441512/50542420-0741fb80-0bbd-11e9-9cd0-af8fce965b7a.png)

<img width="809" alt="participate" src="https://user-images.githubusercontent.com/10441512/50542415-06a96500-0bbd-11e9-8c71-b12b6cfe70fc.png"> <img width="708" alt="os" src="https://user-images.githubusercontent.com/10441512/50542416-06a96500-0bbd-11e9-82f3-ea6a47ff23dc.png"> <img width="670" alt="software" src="https://user-images.githubusercontent.com/10441512/50542417-06a96500-0bbd-11e9-9d63-8b1cbb5049d7.png"> <img width="560" alt="browser" src="https://user-images.githubusercontent.com/10441512/50542418-06a96500-0bbd-11e9-848f-59cf11cfeceb.png"> <img width="535" alt="provider" src="https://user-images.githubusercontent.com/10441512/50542419-0741fb80-0bbd-11e9-8872-762c410b255f.png"> ![header](https://user-images.githubusercontent.com/10441512/50542420-0741fb80-0bbd-11e9-9cd0-af8fce965b7a.png)

👍 1

gjhklfdsa commented

2018-12-30 01:27:37 +00:00

(Migrated from github.com)

@Shifterovich If your are looking into updating the layout a bit, I think it should have a link to each software's source code. Maybe not a big button, but maybe make when you click the title it brings you to it or some part of each description.

I for one, thought it was weird how many non-free services used to be on this site like SailfishOS.

If you want I could try to make a separate pull request and/or help make a list of the URLs.
Just thought I would bring it up :)

@Shifterovich If your are looking into updating the layout a bit, I think it should have a link to each software's source code. Maybe not a big button, but maybe make when you click the title it brings you to it or some part of each description. I for one, thought it was weird how many non-free services used to be on this site like SailfishOS. If you want I could try to make a separate pull request and/or help make a list of the URLs. Just thought I would bring it up :)

Vincevrp commented

2018-12-30 01:56:44 +00:00

(Migrated from github.com)

Looks good to me. If you're finished you can remove the commented code.

👍 1

c0rdis commented

2018-12-30 09:05:32 +00:00

(Migrated from github.com)

@Vincevrp done

Vincevrp (Migrated from github.com) approved these changes

2018-12-30 14:11:06 +00:00

This repo is archived. You cannot comment on pull requests.