The VPN table was quite outdated - reviewed and fixed number of servers, price and in case of Perfect Privacy - country (from Panama to Switzerland, see https://www.perfect-privacy.com/imprint). Also smaller fixes for better sorting of the table.
## Description
The VPN table was quite outdated - reviewed and fixed number of servers, price and in case of Perfect Privacy - country (from Panama to Switzerland, see https://www.perfect-privacy.com/imprint). Also smaller fixes for better sorting of the table.
True - although it's visually much easier to get the data sorted according to numbers. Also, we wouldn't be dependent on exchange rates (e.g. now 54 € ~ $62)
True - although it's visually much easier to get the data sorted according to numbers. Also, we wouldn't be dependent on exchange rates (e.g. now 54 € ~ $62)
c0rdis
(Migrated from github.com)
reviewed 2018-12-29 12:10:46 +00:00
If it's possible to do that inline while keeping the table nice, sure. Otherwise, maybe add a * footnote to these two?
> Not sure
I think it's misleading to just say "Free".
> ProtonVPN
If it's possible to do that inline while keeping the table nice, sure. Otherwise, maybe add a \* footnote to these two?
it's visually much easier to get the data sorted according to numbers
But somewhat misleading, I think they should be sorted according to numbers in the same units.
Also, we wouldn't be dependent on exchange rates
Perhaps this could be somehow automatized? I'll see if Jekyll can be used for that.
> it's visually much easier to get the data sorted according to numbers
But somewhat misleading, I think they should be sorted according to numbers in the same units.
> Also, we wouldn't be dependent on exchange rates
Perhaps this could be somehow automatized? I'll see if Jekyll can be used for that.
Looks like I've got another commit as part of this PR - related to https://github.com/privacytoolsIO/privacytools.io/pull/621#issuecomment-450481258. Please review it as well.
Could you run git revert e5d56f969737a55a27cef9e7a7b5e111412fb5e5 in your master branch? Rebase would be nicer but I'll squash the commits on merge so whatever.
Could you run `git revert e5d56f969737a55a27cef9e7a7b5e111412fb5e5` in your master branch? Rebase would be nicer but I'll squash the commits on merge so whatever.
When you merge, please also squash:
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
jonah
Description
The VPN table was quite outdated - reviewed and fixed number of servers, price and in case of Perfect Privacy - country (from Panama to Switzerland, see https://www.perfect-privacy.com/imprint). Also smaller fixes for better sorting of the table.
Here you use EUR in data-value
@@ -250,3 +250,4 @@<td>28</td><td><span class="flag-icon flag-icon-is"></span> Iceland</td><td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td></tr>And here you use USD in data-value.
@@ -261,3 +261,4 @@<td>148</td><td><span class="flag-icon flag-icon-vg"></span> British Virgin Islands</td><td><a href="https://www.expressvpn.com/">ExpressVPN.com</a></td></tr>This should be rounded to 36.
Maybe this should mention that there is a 2 GB limit?
Not sure - if we do that, we should probably also mention limitations of other cheapest/free options - e.g. that of ProtonVPN
True - although it's visually much easier to get the data sorted according to numbers. Also, we wouldn't be dependent on exchange rates (e.g. now 54 € ~ $62)
@@ -250,3 +250,4 @@<td>28</td><td><span class="flag-icon flag-icon-is"></span> Iceland</td><td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td></tr>See comment above
I think it's misleading to just say "Free".
If it's possible to do that inline while keeping the table nice, sure. Otherwise, maybe add a * footnote to these two?
But somewhat misleading, I think they should be sorted according to numbers in the same units.
Perhaps this could be somehow automatized? I'll see if Jekyll can be used for that.
Looks like I've got another commit as part of this PR - related to https://github.com/privacytoolsIO/privacytools.io/pull/621#issuecomment-450481258. Please review it as well.
I'll extract it into a separate branch. One change per PR.
https://github.com/privacytoolsIO/privacytools.io/pull/704/commits/084def9d8411fee80b405d5537bc3f3f041ef574
Could you run
git revert e5d56f969737a55a27cef9e7a7b5e111412fb5e5in your master branch? Rebase would be nicer but I'll squash the commits on merge so whatever.@@ -250,3 +250,4 @@<td>28</td><td><span class="flag-icon flag-icon-is"></span> Iceland</td><td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td></tr>For now, manually updated to reflect USD values, so resolving
For now, manually updated to reflect USD values, so resolving
When you merge, please also squash:
Sure, sorry