privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Actualized VPN table #704

Merged
c0rdis merged 6 commits from master into master 2018-12-29 13:47:49 +00:00
Conversation 18 Commits 6 Files Changed 1 +30 -29
c0rdis commented 2018-12-29 09:32:58 +00:00 (Migrated from github.com)
Copy Link

Description

The VPN table was quite outdated - reviewed and fixed number of servers, price and in case of Perfect Privacy - country (from Panama to Switzerland, see https://www.perfect-privacy.com/imprint). Also smaller fixes for better sorting of the table.

## Description The VPN table was quite outdated - reviewed and fixed number of servers, price and in case of Perfect Privacy - country (from Panama to Switzerland, see https://www.perfect-privacy.com/imprint). Also smaller fixes for better sorting of the table.
jonah reviewed 2018-12-29 10:13:40 +00:00
index.html
jonah commented 2018-12-29 10:13:40 +00:00

Here you use EUR in data-value

Here you use EUR in data-value
jonah reviewed 2018-12-29 10:14:07 +00:00
index.html
@ -250,3 +250,4 @@
<td>28</td>
<td><span class="flag-icon flag-icon-is"></span> Iceland</td>
<td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td>
</tr>
jonah commented 2018-12-29 10:14:07 +00:00

And here you use USD in data-value.

And here you use USD in data-value.
jonah reviewed 2018-12-29 10:14:30 +00:00
index.html
@ -261,3 +261,4 @@
<td>148</td>
<td><span class="flag-icon flag-icon-vg"></span> British Virgin Islands</td>
<td><a href="https://www.expressvpn.com/">ExpressVPN.com</a></td>
</tr>
jonah commented 2018-12-29 10:14:30 +00:00

This should be rounded to 36.

This should be rounded to 36.
jonah reviewed 2018-12-29 10:15:40 +00:00
index.html
jonah commented 2018-12-29 10:15:40 +00:00

Maybe this should mention that there is a 2 GB limit?

Maybe this should mention that there is a 2 GB limit?
c0rdis (Migrated from github.com) reviewed 2018-12-29 12:09:09 +00:00
index.html
c0rdis (Migrated from github.com) commented 2018-12-29 12:09:09 +00:00

Not sure - if we do that, we should probably also mention limitations of other cheapest/free options - e.g. that of ProtonVPN

Not sure - if we do that, we should probably also mention limitations of other cheapest/free options - e.g. that of ProtonVPN
c0rdis (Migrated from github.com) reviewed 2018-12-29 12:10:38 +00:00
index.html
c0rdis (Migrated from github.com) commented 2018-12-29 12:10:38 +00:00

True - although it's visually much easier to get the data sorted according to numbers. Also, we wouldn't be dependent on exchange rates (e.g. now 54 € ~ $62)

True - although it's visually much easier to get the data sorted according to numbers. Also, we wouldn't be dependent on exchange rates (e.g. now 54 € ~ $62)
c0rdis (Migrated from github.com) reviewed 2018-12-29 12:10:46 +00:00
index.html
@ -250,3 +250,4 @@
<td>28</td>
<td><span class="flag-icon flag-icon-is"></span> Iceland</td>
<td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td>
</tr>
c0rdis (Migrated from github.com) commented 2018-12-29 12:10:46 +00:00

See comment above

See comment above
jonah reviewed 2018-12-29 12:16:36 +00:00
index.html
jonah commented 2018-12-29 12:16:36 +00:00

Not sure

I think it's misleading to just say "Free".

ProtonVPN

If it's possible to do that inline while keeping the table nice, sure. Otherwise, maybe add a * footnote to these two?

> Not sure I think it's misleading to just say "Free". > ProtonVPN If it's possible to do that inline while keeping the table nice, sure. Otherwise, maybe add a \* footnote to these two?
jonah reviewed 2018-12-29 12:24:57 +00:00
index.html
jonah commented 2018-12-29 12:24:57 +00:00

it's visually much easier to get the data sorted according to numbers

But somewhat misleading, I think they should be sorted according to numbers in the same units.

Also, we wouldn't be dependent on exchange rates

Perhaps this could be somehow automatized? I'll see if Jekyll can be used for that.

> it's visually much easier to get the data sorted according to numbers But somewhat misleading, I think they should be sorted according to numbers in the same units. > Also, we wouldn't be dependent on exchange rates Perhaps this could be somehow automatized? I'll see if Jekyll can be used for that.
c0rdis commented 2018-12-29 13:14:59 +00:00 (Migrated from github.com)
Copy Link

Looks like I've got another commit as part of this PR - related to https://github.com/privacytoolsIO/privacytools.io/pull/621#issuecomment-450481258. Please review it as well.

Looks like I've got another commit as part of this PR - related to https://github.com/privacytoolsIO/privacytools.io/pull/621#issuecomment-450481258. Please review it as well.
ghost commented 2018-12-29 13:16:07 +00:00 (Migrated from github.com)
Copy Link

I'll extract it into a separate branch. One change per PR.

I'll extract it into a separate branch. One change per PR.
👍 1
c0rdis (Migrated from github.com) reviewed 2018-12-29 13:24:27 +00:00
index.html
c0rdis (Migrated from github.com) commented 2018-12-29 13:24:27 +00:00

084def9d84

https://github.com/privacytoolsIO/privacytools.io/pull/704/commits/084def9d8411fee80b405d5537bc3f3f041ef574
ghost commented 2018-12-29 13:27:33 +00:00 (Migrated from github.com)
Copy Link

Could you run git revert e5d56f969737a55a27cef9e7a7b5e111412fb5e5 in your master branch? Rebase would be nicer but I'll squash the commits on merge so whatever.

Could you run `git revert e5d56f969737a55a27cef9e7a7b5e111412fb5e5` in your master branch? Rebase would be nicer but I'll squash the commits on merge so whatever.
👍 1
c0rdis (Migrated from github.com) reviewed 2018-12-29 13:32:02 +00:00
index.html
@ -250,3 +250,4 @@
<td>28</td>
<td><span class="flag-icon flag-icon-is"></span> Iceland</td>
<td><a href="https://cryptostorm.is/">Cryptostorm.is</a></td>
</tr>
c0rdis (Migrated from github.com) commented 2018-12-29 13:32:02 +00:00

For now, manually updated to reflect USD values, so resolving

For now, manually updated to reflect USD values, so resolving
c0rdis (Migrated from github.com) reviewed 2018-12-29 13:32:12 +00:00
index.html
c0rdis (Migrated from github.com) commented 2018-12-29 13:32:12 +00:00

For now, manually updated to reflect USD values, so resolving

For now, manually updated to reflect USD values, so resolving
jonah approved these changes 2018-12-29 13:42:34 +00:00
ghost commented 2018-12-29 14:23:41 +00:00 (Migrated from github.com)
Copy Link

When you merge, please also squash:

screenshot from 2018-12-29 15-23-09

When you merge, please also squash: ![screenshot from 2018-12-29 15-23-09](https://user-images.githubusercontent.com/4354706/50539255-ab0bb700-0b7d-11e9-951d-091aaf2a48e5.png)
c0rdis commented 2018-12-29 15:37:32 +00:00 (Migrated from github.com)
Copy Link

Sure, sorry

Sure, sorry
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
jonah
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#704
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?