Archived
Bootstrap 4 + Jekyll transition #552
Merged
ghost
merged 54 commits from 2018-10-27 18:15:14 +00:00
bootstrap4-transition into master
Labels
Clear labels
:mag:🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
approved, waiting for a PR
Pull requests that update a dependency file
The Invisible Internet Project (I2P)
Operating Systems
A label for stalebot if it gets added
Anything related to media streaming.
Anything covering the Tor network
active work in progress, do not merge or PR (yet)!
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
Extensible Messaging and Presence Protocol
Matrix protocol
Browser Extension related issues
Correction of content on the website
Firefox & forks, about:config etc.
Anything primarily related to site cleanup.
Virtual Private Network
*Technical* issues with the website.
Domain Name System
Anything covering a translated version of the site
No labels
Milestone
No items
No Milestone
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#552
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Description
#544
HTML Preview
http://ptio.airdns.org:44449
@kewde @bakku @Atavic @Hillside502 @beerisgood @beardog108 Can we merge?
Some new features
{% include %}s.Screenshots
on mobile (tables have a horizontal scrollbar and links break to avoid creating a horizontal scrollbar on the page)
Based on preview, looks good to me. Nice work.
I think the long-strings class is not working correctly.
.
Thanks for pointing that out. I'll fix it.
I resolved conflicts by ignoring all changes in master. I re-added this change manually.
I'll merge this PR now, but I'll close #544 once we resolve the messy navbar issue.
Seems like bootstrap is broken because of a missing map file.
Of course, the merge caused the site to break. I'm getting no errors in console, though.
I'll re-add the map file, one moment.
I don't think the missing map file is the issue.
ptio.airdns.org:44449 doesn't serve the map file and everything works there.
I'm getting this error:
I got the same error for popper.js, so I removed the last line from popper.js (the one that specified the map file). Note that this error shouldn't break anything. https://stackoverflow.com/a/21504707/7009314 map files are only useful for debugging. I think they are the cause of showing x.scss instead of boostrap.min.css in dev tools.
Ah. Old custom.css. Simply shift+F5 to clear cache.
That's kind of problem solved, but we want our users to have this cache deleted as well. Maybe changing
<link href="css/custom.css?v=1" rel="stylesheet">to<link href="css/custom.css?v=2" rel="stylesheet">would work?I appended all URLs to JS and CSS with
?v=4. Now I understand why custom.css had that?v=1in the URL to it.