privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Bootstrap 4 + Jekyll transition #552

Merged
ghost merged 54 commits from bootstrap4-transition into master 2018-10-27 18:15:14 +00:00
Conversation 16 Commits 54 Files Changed 124 +6803 -24452
ghost commented 2018-10-27 16:47:39 +00:00 (Migrated from github.com)
Copy Link

Description

#544

HTML Preview

http://ptio.airdns.org:44449

### Description #544 ### HTML Preview http://ptio.airdns.org:44449
ghost commented 2018-10-27 16:56:47 +00:00 (Migrated from github.com)
Copy Link

@kewde @bakku @Atavic @Hillside502 @beerisgood @beardog108 Can we merge?

@kewde @bakku @Atavic @Hillside502 @beerisgood @beardog108 Can we merge?
ghost commented 2018-10-27 17:36:24 +00:00 (Migrated from github.com)
Copy Link

Some new features

  • Awesome responsivity
    • It works great on mobile. Viewport allows users to zoom. There's no horizontal scrollbar.
  • Looks much nicer, much more modern.
    • Again, it's very nice even on mobile.
  • Scrollspy
    • Shows the user at what section he's currently at
  • Jekyll
    • All those panels with recommended software are now ~7 line long {% include %}s.
  • 100% valid HTML
    • We will add either a CI or a bot that would check validity of all pull requests.

Screenshots

ptio airdns org_44449_ 1
ptio airdns org_44449_
on mobile (tables have a horizontal scrollbar and links break to avoid creating a horizontal scrollbar on the page)

# Some new features - **Awesome responsivity** - It works great on mobile. Viewport allows users to zoom. There's no horizontal scrollbar. - Looks much nicer, much more modern. - Again, it's very nice even on mobile. - Scrollspy - Shows the user at what section he's currently at - **Jekyll** - All those panels with recommended software are now ~7 line long `{% include %}`s. - 100% valid HTML - We will add either a CI or a bot that would check validity of all pull requests. ## Screenshots ![ptio airdns org_44449_ 1](https://user-images.githubusercontent.com/4354706/47607301-5a150080-da1e-11e8-9831-1947611d6898.png) ![ptio airdns org_44449_](https://user-images.githubusercontent.com/4354706/47607302-5a150080-da1e-11e8-9542-8bd84f453adc.png) [on mobile](https://imgur.com/a/DAj8hnN) (tables have a horizontal scrollbar and links break to avoid creating a horizontal scrollbar on the page)
ghost commented 2018-10-27 17:42:45 +00:00 (Migrated from github.com)
Copy Link

Based on preview, looks good to me. Nice work.

Based on preview, looks good to me. Nice work.
Vincevrp commented 2018-10-27 17:43:24 +00:00 (Migrated from github.com)
Copy Link

I think the long-strings class is not working correctly. broken.

I think the long-strings class is not working correctly. ![broken](https://user-images.githubusercontent.com/13933712/47607452-97be5d00-da0f-11e8-8eaf-a3a845451923.png).
ghost commented 2018-10-27 17:46:12 +00:00 (Migrated from github.com)
Copy Link

Thanks for pointing that out. I'll fix it.

Thanks for pointing that out. I'll fix it.
jonah reviewed 2018-10-27 18:12:55 +00:00
_layouts/default.html
jonah commented 2018-10-27 18:12:55 +00:00

I resolved conflicts by ignoring all changes in master. I re-added this change manually.

screenshot from 2018-10-27 20-11-59

I resolved conflicts by ignoring all changes in master. I re-added this change manually. ![screenshot from 2018-10-27 20-11-59](https://user-images.githubusercontent.com/4354706/47607767-a400e500-da24-11e8-9b79-e1dbfcc1c035.png)
ghost commented 2018-10-27 18:15:08 +00:00 (Migrated from github.com)
Copy Link

I'll merge this PR now, but I'll close #544 once we resolve the messy navbar issue.

I'll merge this PR now, but I'll close #544 once we resolve the messy navbar issue.
Vincevrp commented 2018-10-27 18:18:21 +00:00 (Migrated from github.com)
Copy Link

I'll merge this PR now, but I'll close #544 once we resolve the messy navbar issue.

Seems like bootstrap is broken because of a missing map file.

> I'll merge this PR now, but I'll close #544 once we resolve the messy navbar issue. Seems like bootstrap is broken because of a missing map file.
ghost commented 2018-10-27 18:18:40 +00:00 (Migrated from github.com)
Copy Link

Of course, the merge caused the site to break. I'm getting no errors in console, though.

Of course, the merge caused the site to break. I'm getting no errors in console, though.
Vincevrp commented 2018-10-27 18:19:07 +00:00 (Migrated from github.com)
Copy Link

Of course, this caused the site to break. I'm getting no errors in console, though.

I'll re-add the map file, one moment.

> Of course, this caused the site to break. I'm getting no errors in console, though. I'll re-add the map file, one moment.
ghost commented 2018-10-27 18:21:07 +00:00 (Migrated from github.com)
Copy Link

I don't think the missing map file is the issue.

pi@raspberrypi:~/ptio/css $ ls
bootstrap.min.css  flag-icon.min.css        sortable-theme-bootstrap.css
custom.css         fontawesome-all.min.css

ptio.airdns.org:44449 doesn't serve the map file and everything works there.

I don't think the missing map file is the issue. ``` pi@raspberrypi:~/ptio/css $ ls bootstrap.min.css flag-icon.min.css sortable-theme-bootstrap.css custom.css fontawesome-all.min.css ``` ptio.airdns.org:44449 doesn't serve the map file and everything works there.
Vincevrp commented 2018-10-27 18:22:39 +00:00 (Migrated from github.com)
Copy Link

I'm getting this error: fix

I'm getting this error: ![fix](https://user-images.githubusercontent.com/13933712/47607863-42854a00-da15-11e8-9739-53b4ead042cd.png)
ghost commented 2018-10-27 18:24:40 +00:00 (Migrated from github.com)
Copy Link

I got the same error for popper.js, so I removed the last line from popper.js (the one that specified the map file). Note that this error shouldn't break anything. https://stackoverflow.com/a/21504707/7009314 map files are only useful for debugging. I think they are the cause of showing x.scss instead of boostrap.min.css in dev tools.

I got the same error for popper.js, so I removed the last line from popper.js (the one that specified the map file). Note that this error shouldn't break anything. https://stackoverflow.com/a/21504707/7009314 map files are only useful for debugging. I think they are the cause of showing x.scss instead of boostrap.min.css in dev tools.
ghost commented 2018-10-27 18:26:36 +00:00 (Migrated from github.com)
Copy Link

Ah. Old custom.css. Simply shift+F5 to clear cache.

Ah. Old custom.css. Simply shift+F5 to clear cache.
ghost commented 2018-10-27 18:27:29 +00:00 (Migrated from github.com)
Copy Link

That's kind of problem solved, but we want our users to have this cache deleted as well. Maybe changing <link href="css/custom.css?v=1" rel="stylesheet"> to <link href="css/custom.css?v=2" rel="stylesheet"> would work?

That's kind of problem solved, but we want our users to have this cache deleted as well. Maybe changing `<link href="css/custom.css?v=1" rel="stylesheet">` to `<link href="css/custom.css?v=2" rel="stylesheet">` would work?
ghost commented 2018-10-27 18:32:58 +00:00 (Migrated from github.com)
Copy Link

I appended all URLs to JS and CSS with ?v=4. Now I understand why custom.css had that ?v=1 in the URL to it.

I appended all URLs to JS and CSS with `?v=4`. Now I understand why custom.css had that `?v=1` in the URL to it.
😆 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#552
No description provided.
Delete Branch "bootstrap4-transition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?