### Description
Reworked donated button to improve looks and fix W3 error. Small changes to nav to improve responsiveness as well.
### HTML Preview
https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/donate-button/index.html
The float: right gets ugly when navbar is collapsed.
The `float: right` gets ugly when navbar is collapsed.
Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly.
Maybe we should implement some sort of CI/CD with linting and validation before migrating to BS4? Just to make sure that the future code will be W3 compliant.
I will fix this issues later this week.
> > Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly.
Maybe we should implement some sort of CI/CD with linting and validation before migrating to BS4? Just to make sure that the future code will be W3 compliant.
I will fix this issues later this week.
If we're going to merge the BS4 branch soon, this change is unnecessary. See the BS4 version of the navbar:
If we're going to merge the BS4 branch soon, this change is unnecessary. See the BS4 version of the navbar:
I think that's @privacytoolsIO's BTC address, I hope he still has access to it, I haven't heard from him for a long time.
> Your donation will cover our cost for server, domains, coffee, beer and pizza.
Right now our (@privacytoolsIO's) only expense is the domain cost (and possibly Cloudflare, not sure). Which is covered for many years ahead from the BTC on these two addresses only https://www.blockchain.com/btc/address/1N4bKCx3kpvUTBhsvbmthPDssN8ATPEhgt https://www.blockchain.com/btc/address/1EM2JEbQeoiZP4Cd4Pm2wgJcBPAWJBeijz (there's also https://www.blockchain.com/btc/address/1N6heMWD34ARyApkRmNv7V7NzQfYvgC4dg which had a few BTC prior to the creation of PTIO). I'd personally rather see any money left after domain costs are paid invested in other privacy projects.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
jonah
Description
Reworked donated button to improve looks and fix W3 error. Small changes to nav to improve responsiveness as well.
HTML Preview
https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/donate-button/index.html
Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly.
@@ -20,0 +43,4 @@}#donate {float: right;The
float: rightgets ugly when navbar is collapsed.@@ -20,0 +52,4 @@}#donate > a {padding: 15px 0;I'd add some space (margin) between the text and the heart.
Maybe we should implement some sort of CI/CD with linting and validation before migrating to BS4? Just to make sure that the future code will be W3 compliant.
I will fix this issues later this week.
@Vincevrp Good idea.
We really should switch to BS4. I could help with some of these things better as I'm very familiar with BS4 syntax.
I'll start some work on the transition already. I'll create a new branch.
Should be fixed now.
If we're going to merge the BS4 branch soon, this change is unnecessary. See the BS4 version of the navbar:
I finished it so it's fixed while BS4 is getting implemented. If you prefer not to merge it you may close this PR.
I think that's @privacytoolsIO's BTC address, I hope he still has access to it, I haven't heard from him for a long time.
Right now our (@privacytoolsIO's) only expense is the domain cost (and possibly Cloudflare, not sure). Which is covered for many years ahead from the BTC on these two addresses only https://www.blockchain.com/btc/address/1N4bKCx3kpvUTBhsvbmthPDssN8ATPEhgt https://www.blockchain.com/btc/address/1EM2JEbQeoiZP4Cd4Pm2wgJcBPAWJBeijz (there's also https://www.blockchain.com/btc/address/1N6heMWD34ARyApkRmNv7V7NzQfYvgC4dg which had a few BTC prior to the creation of PTIO). I'd personally rather see any money left after domain costs are paid invested in other privacy projects.