Rework donate button #543

jonah · 2018-10-22T20:33:18Z

Vincevrp commented

2018-10-22 20:33:18 +00:00

(Migrated from github.com)

Description

Reworked donated button to improve looks and fix W3 error. Small changes to nav to improve responsiveness as well.

HTML Preview

https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/donate-button/index.html

### Description Reworked donated button to improve looks and fix W3 error. Small changes to nav to improve responsiveness as well. ### HTML Preview https://htmlpreview.github.io/?https://github.com/Vincevrp/privacytools.io/blob/donate-button/index.html

ghost commented

2018-10-23 13:27:25 +00:00

(Migrated from github.com)

Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly.

jonah requested changes 2018-10-23 13:28:35 +00:00

css/custom.css

						
				@ -20,0 +43,4 @@

				}

				#donate {

				  float: right;

jonah commented

2018-10-23 13:27:43 +00:00

The float: right gets ugly when navbar is collapsed.

The `float: right` gets ugly when navbar is collapsed. ![screenshot from 2018-10-23 15-25-34](https://user-images.githubusercontent.com/4354706/47363772-eac6a600-d6d7-11e8-87ad-fa3bdb129295.png)

css/custom.css

						
				@ -20,0 +52,4 @@

				}

				#donate > a {

				  padding: 15px 0;

jonah commented

2018-10-23 13:28:14 +00:00

I'd add some space (margin) between the text and the heart.

Vincevrp commented

2018-10-23 13:33:56 +00:00

(Migrated from github.com)

Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly.

Maybe we should implement some sort of CI/CD with linting and validation before migrating to BS4? Just to make sure that the future code will be W3 compliant.

I will fix this issues later this week.

> > Maybe we should open a big PR / branch to change the look to BS4? Now that websites use BS4, BS3 is quite ugly. Maybe we should implement some sort of CI/CD with linting and validation before migrating to BS4? Just to make sure that the future code will be W3 compliant. I will fix this issues later this week.

ghost commented

2018-10-23 13:51:19 +00:00

(Migrated from github.com)

@Vincevrp Good idea.

We really should switch to BS4. I could help with some of these things better as I'm very familiar with BS4 syntax.

@Vincevrp Good idea. We really should switch to BS4. I could help with some of these things better as I'm very familiar with BS4 syntax.

ghost commented

2018-10-23 13:52:44 +00:00

(Migrated from github.com)

I'll start some work on the transition already. I'll create a new branch.

Vincevrp commented

2018-10-25 14:40:22 +00:00

(Migrated from github.com)

Should be fixed now.

ghost commented

2018-10-25 15:12:31 +00:00

(Migrated from github.com)

If we're going to merge the BS4 branch soon, this change is unnecessary. See the BS4 version of the navbar:

If we're going to merge the BS4 branch soon, this change is unnecessary. See the BS4 version of the navbar: ![screenshot from 2018-10-25 17-11-33](https://user-images.githubusercontent.com/4354706/47510749-09b06e00-d879-11e8-93f3-2829441a23a8.png)

Vincevrp commented

2018-10-25 16:08:00 +00:00

(Migrated from github.com)

I finished it so it's fixed while BS4 is getting implemented. If you prefer not to merge it you may close this PR.

ghost commented

2018-10-25 19:07:14 +00:00

(Migrated from github.com)

I think that's @privacytoolsIO's BTC address, I hope he still has access to it, I haven't heard from him for a long time.

Your donation will cover our cost for server, domains, coffee, beer and pizza.

Right now our (@privacytoolsIO's) only expense is the domain cost (and possibly Cloudflare, not sure). Which is covered for many years ahead from the BTC on these two addresses only https://www.blockchain.com/btc/address/1N4bKCx3kpvUTBhsvbmthPDssN8ATPEhgt https://www.blockchain.com/btc/address/1EM2JEbQeoiZP4Cd4Pm2wgJcBPAWJBeijz (there's also https://www.blockchain.com/btc/address/1N6heMWD34ARyApkRmNv7V7NzQfYvgC4dg which had a few BTC prior to the creation of PTIO). I'd personally rather see any money left after domain costs are paid invested in other privacy projects.

I think that's @privacytoolsIO's BTC address, I hope he still has access to it, I haven't heard from him for a long time. > Your donation will cover our cost for server, domains, coffee, beer and pizza. Right now our (@privacytoolsIO's) only expense is the domain cost (and possibly Cloudflare, not sure). Which is covered for many years ahead from the BTC on these two addresses only https://www.blockchain.com/btc/address/1N4bKCx3kpvUTBhsvbmthPDssN8ATPEhgt https://www.blockchain.com/btc/address/1EM2JEbQeoiZP4Cd4Pm2wgJcBPAWJBeijz (there's also https://www.blockchain.com/btc/address/1N6heMWD34ARyApkRmNv7V7NzQfYvgC4dg which had a few BTC prior to the creation of PTIO). I'd personally rather see any money left after domain costs are paid invested in other privacy projects.

👍 1

This repo is archived. You cannot comment on pull requests.

No reviewers