Add a Clearnet URL and Darknet URL to email provider table #166
Closed
MitchellCash wants to merge 3 commits from
dark_email
into master
pull from: dark_email
merge into: privacyguides:master
privacyguides:master
privacyguides:dependabot/bundler/nokogiri-1.13.6
privacyguides:dependabot/bundler/addressable-2.8.0
privacyguides:freddy-m-patch-3
privacyguides:pr-add_RemoveMyPhone_sponsor
privacyguides:pr-browser_cleanup_1257_1328_1430
privacyguides:freddy-m-patch-2
privacyguides:freddy-m-patch-1
privacyguides:pr-vpn_hated_one_video
privacyguides:cdn
privacyguides:update-nitrohorse-image
privacyguides:promote-metager-to-card
privacyguides:hardware
privacyguides:pr-add_azirevpn
privacyguides:pr-add_mailfence
privacyguides:shop
privacyguides:1673
privacyguides:pr/1658
privacyguides:i18n-simple
privacyguides:sponsorship-edits-nov2019
privacyguides:i18n
privacyguides:ipfs
privacyguides:blacklight447-ptio-patch-3
privacyguides:blog
privacyguides:remove-windows-icons
privacyguides:pr/1147
privacyguides:i18n-testing
privacyguides:add-beautify
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
WIP
Milestone
No items
No Milestone
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#166
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "dark_email"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #165.
If you wish to view the diff without whitespace add
?w=1
to the end of the URL. Like this.Fixed merge conflicts
All URLs have remained the same,
one onion URL was added for protonmail.
A quick search turns up that
https://protonirockerxow.onion is indeed the right onion url.
I have not tested if this PR messes up the format/html.
I'm not so sure about the whitespaces. They don't seem to affect the file size, though.
@mitchellcash Putting a "Darknet URL" column shouldn't be the way to do that, especially considering that next-gen onion services will have 52 characters. There's certainly a much better UX solution (adding an onion icon near Protonmail.ch?).
@e5f3c2ea895af0f27667 I like the idea you proposed, design wise it is a lot better. I'd use an official Tor logo to make it more obvious tho. Or simply the text "onion"..
@e5f3c2ea895af0f27667 @kewde good thinking, I've made the applicable changes. It now looks like the below, what are your thoughts?
I've now also added tooltips, so the user better understands where each URL takes them to.
@mitchellcash That does look better! Whatcha think @Shifterovich?
I'd perhaps keep the clearnet URL as text. How would that look like @mitchellcash?
@Shifterovich what do you think?
I think I personally like the my other mock ups. But maybe I can play around with this some more.
Or...
My opinion is either two buttons or a button for clearnet and text for darknet. Could you also make that one?
The buttons works nicely, I've resolved the merge conflicts.
I tried moving these svgs into their own file :| The tags didn't work.
#248 fixed
@kewde apologies, I totally missed this. I just happened to be browsing the website and was thinking - wait, those changes look like my forgotten pull request!
Thanks for fixing this up and getting it merged :)