Add a Clearnet URL and Darknet URL to email provider table #166

2017-01-20T07:53:34Z

MitchellCash commented

2017-01-20 07:53:34 +00:00

(Migrated from github.com)

Fixes #165.

If you wish to view the diff without whitespace add ?w=1 to the end of the URL. Like this.

Fixes #165. If you wish to view the diff without whitespace add `?w=1` to the end of the URL. Like [this](https://github.com/privacytoolsIO/privacytools.io/pull/166/files?w=1).

MitchellCash commented

2017-02-12 11:03:06 +00:00

(Migrated from github.com)

Fixed merge conflicts

kewde (Migrated from github.com) approved these changes 2017-03-05 23:51:12 +00:00

kewde (Migrated from github.com) left a comment

All URLs have remained the same,
one onion URL was added for protonmail.
A quick search turns up that
https://protonirockerxow.onion is indeed the right onion url.

I have not tested if this PR messes up the format/html.

All URLs have remained the same, one onion URL was added for protonmail. A quick search turns up that https://protonirockerxow.onion is indeed the right onion url. I have not tested if this PR messes up the format/html.

ghost commented

2017-03-06 16:53:23 +00:00

(Migrated from github.com)

I'm not so sure about the whitespaces. They don't seem to affect the file size, though.

ghost commented

2017-03-07 17:36:54 +00:00

(Migrated from github.com)

@mitchellcash Putting a "Darknet URL" column shouldn't be the way to do that, especially considering that next-gen onion services will have 52 characters. There's certainly a much better UX solution (adding an onion icon near Protonmail.ch?).

kewde commented

2017-03-07 21:32:24 +00:00

(Migrated from github.com)

@e5f3c2ea895af0f27667 I like the idea you proposed, design wise it is a lot better. I'd use an official Tor logo to make it more obvious tho. Or simply the text "onion"..

MitchellCash commented

2017-03-08 03:15:57 +00:00

(Migrated from github.com)

@e5f3c2ea895af0f27667 @kewde good thinking, I've made the applicable changes. It now looks like the below, what are your thoughts?

@e5f3c2ea895af0f27667 @kewde good thinking, I've made the applicable changes. It now looks like the below, what are your thoughts? <img width="482" alt="email-provider-clearnet-darknet-url" src="https://cloud.githubusercontent.com/assets/8009243/23688580/32483b16-0401-11e7-9eca-fb692cdd2eeb.png">

MitchellCash commented

2017-03-08 04:50:52 +00:00

(Migrated from github.com)

I've now also added tooltips, so the user better understands where each URL takes them to.

I've now also added tooltips, so the user better understands where each URL takes them to. <img width="447" alt="email-provider-clearnet-darknet-url-2" src="https://cloud.githubusercontent.com/assets/8009243/23690590/90bf4538-040e-11e7-8fe3-74d6921cea8c.png">

kewde commented

2017-03-08 11:21:45 +00:00

(Migrated from github.com)

@mitchellcash That does look better! Whatcha think @Shifterovich?

ghost commented

2017-03-08 14:15:03 +00:00

(Migrated from github.com)

I'd perhaps keep the clearnet URL as text. How would that look like @mitchellcash?

MitchellCash commented

2017-04-09 09:11:57 +00:00

(Migrated from github.com)

@Shifterovich what do you think?

I think I personally like the my other mock ups. But maybe I can play around with this some more.

@Shifterovich what do you think? ![email-provider-clearnet-darknet-url-3](https://cloud.githubusercontent.com/assets/8009243/24836185/3bd9e18c-1d58-11e7-9a20-a8bbcecc723e.png) I think I personally like the my other mock ups. But maybe I can play around with this some more.

MitchellCash commented

2017-04-09 09:29:41 +00:00

(Migrated from github.com)

Or...

Or... ![email-provider-clearnet-darknet-url-4](https://cloud.githubusercontent.com/assets/8009243/24836268/d25dc54a-1d5a-11e7-8ab0-4ff249fe2485.png)

ghost commented

2017-04-09 18:58:52 +00:00

(Migrated from github.com)

My opinion is either two buttons or a button for clearnet and text for darknet. Could you also make that one?

kewde commented

2017-07-04 17:49:17 +00:00

(Migrated from github.com)

The buttons works nicely, I've resolved the merge conflicts.

I tried moving these svgs into their own file :| The tags didn't work.

The buttons works nicely, I've resolved the merge conflicts. I tried moving these svgs into their own file :| The <img> tags didn't work.

kewde commented

2017-07-04 18:11:35 +00:00

(Migrated from github.com)

#248 fixed

MitchellCash commented

2017-07-29 12:02:39 +00:00

(Migrated from github.com)

@kewde apologies, I totally missed this. I just happened to be browsing the website and was thinking - wait, those changes look like my forgotten pull request!

Thanks for fixing this up and getting it merged :)

@kewde apologies, I totally missed this. I just happened to be browsing the website and was thinking - wait, those changes look like my forgotten pull request! Thanks for fixing this up and getting it merged :)

This repo is archived. You cannot comment on pull requests.

No reviewers

kewde