privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update Edward Snowden quotes from Permanent Record #1654

Merged
sgraaf merged 2 commits from master into master 2020-01-26 01:15:05 +00:00
Conversation 15 Commits 2 Files Changed 1 +7 -2
sgraaf commented 2020-01-16 10:33:57 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: #none

Check List

<!-- PLEASE READ OUR CODE OF CONDUCT (https://github.com/privacytoolsIO/privacytools.io/blob/master/CODE_OF_CONDUCT.md) AND CONTRIBUTING GUIDELINES (https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #none <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. --> #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [the contributing guidelines](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://deploy-preview-1654--privacytools-io.netlify.com/
netlify[bot] commented 2020-01-16 10:34:56 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit 0014396fdb

https://deploy-preview-1654--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit 0014396fdbfc1fa3663e0e9aa4ca4835f2ad451e https://deploy-preview-1654--privacytools-io.netlify.com
Mikaela (Migrated from github.com) reviewed 2020-01-16 11:37:32 +00:00
Mikaela (Migrated from github.com) left a comment

Thank you for this PR, I checked that the quotes are correct, but the only thing I am not certain of is linking to Amazon.

As I didn't find any official website for the book, what would you think about linking to Wikipedia (or would it give spoilers) or Goodreads (I am not sure if this one is justifiable) instead?

If everyone else is fine with linking to Amazon, could the link point at least to smile.amazon.com so Amazon will donate some to charities including Tor (see question 26)?

Thank you for this PR, I checked that the quotes are correct, but the only thing I am not certain of is linking to Amazon. As I didn't find any official website for the book, what would you think about linking to Wikipedia (or would it give spoilers) or Goodreads (I am not sure if this one is justifiable) instead? * https://en.wikipedia.org/wiki/Permanent_Record_(autobiography) * https://www.goodreads.com/book/show/46223297-permanent-record If everyone else is fine with linking to Amazon, could the link point at least to smile.amazon.com so Amazon will donate some to charities [including Tor (see question 26)](https://donate.torproject.org/donor-faq)?
sgraaf commented 2020-01-16 12:10:26 +00:00 (Migrated from github.com)
Copy Link

Thank you for this PR, I checked that the quotes are correct, but the only thing I am not certain of is linking to Amazon.

As I didn't find any official website for the book, what would you think about linking to Wikipedia (or would it give spoilers) or Goodreads (I am not sure if this one is justifiable) instead?

* https://en.wikipedia.org/wiki/Permanent_Record_(autobiography)

* https://www.goodreads.com/book/show/46223297-permanent-record

If everyone else is fine with linking to Amazon, could the link point at least to smile.amazon.com so Amazon will donate some to charities including Tor (see question 26)?

I was unsure about linking to Amazon myself. Linking to Goodreads seems like a perfectly fine substitute.

> > > Thank you for this PR, I checked that the quotes are correct, but the only thing I am not certain of is linking to Amazon. > > As I didn't find any official website for the book, what would you think about linking to Wikipedia (or would it give spoilers) or Goodreads (I am not sure if this one is justifiable) instead? > > * https://en.wikipedia.org/wiki/Permanent_Record_(autobiography) > > * https://www.goodreads.com/book/show/46223297-permanent-record > > > If everyone else is fine with linking to Amazon, could the link point at least to smile.amazon.com so Amazon will donate some to charities [including Tor (see question 26)](https://donate.torproject.org/donor-faq)? I was unsure about linking to Amazon myself. Linking to Goodreads seems like a perfectly fine substitute.
👍 1
danarel commented 2020-01-16 19:04:10 +00:00 (Migrated from github.com)
Copy Link

I was unsure about linking to Amazon myself. Linking to Goodreads seems like a perfectly fine substitute.

Amazon own's Goodreads.

I would recommend linking directly to the publisher and letting the user decide where to buy:

https://us.macmillan.com/books/9781250237231

> I was unsure about linking to Amazon myself. Linking to Goodreads seems like a perfectly fine substitute. Amazon own's Goodreads. I would recommend linking directly to the publisher and letting the user decide where to buy: https://us.macmillan.com/books/9781250237231
👍 1
nitrohorse (Migrated from github.com) reviewed 2020-01-16 19:30:30 +00:00
nitrohorse (Migrated from github.com) left a comment

Thanks!

Although I’m inclined to recommend just downloading a copy online due to this:

Edward Snowden is not entitled to the profits from his memoir Permanent Record, and any money made must go to the US government, a judge has ruled. - https://www.theguardian.com/books/2019/dec/20/edward-snowden-profits-memoir-us-government-judge-rules-permanent-record

But linking to Wikipedia seems fine to me.

Thanks! Although I’m inclined to recommend just downloading a copy online due to this: > Edward Snowden is not entitled to the profits from his memoir Permanent Record, and any money made must go to the US government, a judge has ruled. - https://www.theguardian.com/books/2019/dec/20/edward-snowden-profits-memoir-us-government-judge-rules-permanent-record But linking to Wikipedia seems fine to me.
Mikaela commented 2020-01-17 15:01:05 +00:00 (Migrated from github.com)
Copy Link

Although I’m inclined to recommend just downloading a copy online due to this:

I fear that would get copyright people after us, while it would be interesting how much information there can be about that.

Unless you just said (note: Edward Snowden doesn't receive money from the book)?

> Although I’m inclined to recommend just downloading a copy online due to this: I fear that would get copyright people after us, while it would be interesting how much information there can be about that. Unless you just said (note: Edward Snowden doesn't receive money from the book)?
dngray commented 2020-01-23 14:02:13 +00:00 (Migrated from github.com)
Copy Link

We probably can't link to a pirated copy of the book no. But we certainly shouldn't link to a shopfront of any kind given that all money is being confiscated.

We probably can't link to a pirated copy of the book no. But we certainly shouldn't link to a shopfront of any kind given that all money is being confiscated.
nitrohorse commented 2020-01-24 18:56:54 +00:00 (Migrated from github.com)
Copy Link

@sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think.

@sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think.
danarel commented 2020-01-24 19:13:12 +00:00 (Migrated from github.com)
Copy Link

Is there a reason why we are choosing Wikipedia over the publishers site?

Is there a reason why we are choosing Wikipedia over the publishers site?
nitrohorse commented 2020-01-24 22:44:56 +00:00 (Migrated from github.com)
Copy Link

I’d think Wikipedia could be a bit more informative for users due to it containing info on the civil lawsuit, specifically that the US government “aims to capture the proceeds Snowden would be earning from [the book].”

But to be clear, this is just my perspective; updating the quote here is most important regardless I think

I’d think Wikipedia could be a bit more informative for users due to it containing info on the civil lawsuit, specifically that the US government “aims to capture the proceeds Snowden would be earning from [the book].” But to be clear, this is just my perspective; updating the quote here is most important regardless I think
danarel commented 2020-01-24 22:51:12 +00:00 (Migrated from github.com)
Copy Link

Fair enough

Fair enough
sgraaf commented 2020-01-24 23:36:00 +00:00 (Migrated from github.com)
Copy Link

@sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think.

Yes. Will do so tomorrow.

> > > @sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think. Yes. Will do so tomorrow.
sgraaf commented 2020-01-25 18:35:19 +00:00 (Migrated from github.com)
Copy Link

@sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think.

Done.

> > > @sgraaf, would you be able to update the link to Wikipedia? Then we could merge I think. Done.
nitrohorse (Migrated from github.com) approved these changes 2020-01-25 22:17:30 +00:00
nitrohorse (Migrated from github.com) left a comment

LGTM

LGTM
dngray (Migrated from github.com) approved these changes 2020-01-26 01:11:51 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
nitrohorse
dngray
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
✨ enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1654
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?