Archived
Update Wire's metadata warning to increase clarity #1172
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#1172
Reference in New Issue
Block a user
Description
This was brought up by abreast:privacytools.io in the Matrix chat room:
So this PR attempts to make the warning a bit more clear.
Relates to: https://github.com/privacytoolsIO/privacytools.io/issues/949
Check List
I have read and understand CONTRIBUTING.md.
[ ] I have listed the source code for this project in source_code.md.[ ] This project is free/libre software.This project has an associated discussion.
Code Repository (if applicable): N/A
Deploy preview for privacytools-io ready!
Built with commit
c10ece1516https://deploy-preview-1172--privacytools-io.netlify.com
wouldn't the word "contacts" be more clear than word "connections"?
Yeah good catch! Ideally I think this would be good:
However commas (
,) are breaking the tooltip lol so I'll try to figure out what's going on with that.[edit] looks like commas are used as delimiters in cardv2's labels...
I don't think so as that would seem like phone contacts that Wire server doesn't have plaintext access to those.
This is just a guess, but how about
\,?if you'd change it to that, then it would be perfect IMO. ill wait for you to make the changes and figure the tooltip issue and approve it after that.
Hmm @Mikaela is right; they hash contacts but store metadata about user-to-user connections in plaintext I think...
Good to merge.
@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}@JonahAragon is it alright to change the delimiter in labels to a different character other than
,?@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}Maybe something not used normally like
|would be better than;.@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}I wouldn't see any reason why not.
@@ -62,0 +94,4 @@{% if include.windows != "" %}<a href="{{ include.windows }}"><i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i></a>Is this going to break anything else?
@@ -62,0 +94,4 @@{% if include.windows != "" %}<a href="{{ include.windows }}"><i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i></a>Good catch! I’m going to put the “wip” label on this and verify. 🙏🏼
@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}You can change it to whatever, but you will need to update everything that uses the labels functionality to match. You should also change the badges delimiter to match, since it uses the same syntax as labels.
@@ -62,0 +94,4 @@{% if include.windows != "" %}<a href="{{ include.windows }}"><i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i></a>Yeah, most likely going to break existing labels. I'd also like to see
badgeschanged to use the same syntax: https://github.com/privacytoolsIO/privacytools.io/pull/1172/files#diff-8f1346aae81a8f63f53e2815d9f6582eR4-R22@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}Okay, that's a good catch. I'll update the badges delimiter to match + validate this doesn't break anything.
@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}Alright, so I went through the repo's code and couldn't find any place where multiple badges or labels are being used in a v2 card aside from Wire. So I think we're fine with making the cardv2 delimiter change without breaking anything.
@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}I've also updated the formatting of
cardv2.htmlto make editing and reading a bit more easier for future contributors.@@ -20,3 +24,3 @@{% else %}{{include.title}}{{ include.title }}{% endif %}Maybe Wire was the one I was thinking of, I knew I had seen one with two labels recently lol
@@ -20,0 +18,4 @@> {{text}} {{ help_icon }}{% else %}> {{text}}{% endif %}Updated to "|"
@@ -20,0 +18,4 @@> {{text}} {{ help_icon }}{% else %}> {{text}}{% endif %}I am somewhat surprised that works, seeing as Liquid uses "|"s internally. There's even one in that line in particular 😆
@@ -20,0 +18,4 @@> {{text}} {{ help_icon }}{% else %}> {{text}}{% endif %}Oh really? I missed that lol. Great that’s probably a bug I created...
@@ -20,0 +18,4 @@> {{text}} {{ help_icon }}{% else %}> {{text}}{% endif %}Idk, it appears to function.
@@ -20,0 +18,4 @@> {{text}} {{ help_icon }}{% else %}> {{text}}{% endif %}Ah I must have mis-understood -- I didn't realize we're using a module called Liquid lol! Yeah, then this is alright since the | is within quotes so it's treated simply as a string 😄