privacyguides
/
privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Update Wire's metadata warning to increase clarity #1172

Merged
nitrohorse merged 6 commits from update-wire-metadata-warning into master 2019-08-18 14:13:20 +00:00
Conversation 6 Commits 6 Files Changed 2 +220 -54
nitrohorse commented 2019-08-17 17:49:56 +00:00 (Migrated from github.com)
Copy Link

Description

This was brought up by abreast:privacytools.io in the Matrix chat room:

The warning for Wire on ptio website is a bit misleading: "Wire stores metadata such as list of your connections/conversations in plaintext (= not encrypted)."
Including conversations in the warning will lead people to think that their actual conversation is stored in paintext which would be incorrect.

So this PR attempts to make the warning a bit more clear.

Relates to: https://github.com/privacytoolsIO/privacytools.io/issues/949

Check List

Code Repository (if applicable): N/A

<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description This was brought up by abreast:privacytools.io in the Matrix chat room: > The warning for Wire on ptio website is a bit misleading: "Wire stores metadata such as list of your connections/conversations in plaintext (= not encrypted)." > Including conversations in the warning will lead people to think that their actual conversation is stored in paintext which would be incorrect. So this PR attempts to make the warning a bit more clear. Relates to: https://github.com/privacytoolsIO/privacytools.io/issues/949 #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I have read and understand [CONTRIBUTING.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md). - ~~[ ] I have listed the source code for this project in [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md).~~ - ~~[ ] This project is [free/libre software](https://www.wikipedia.org/wiki/Free_software).~~ - [x] This project has an [associated discussion](https://github.com/privacytoolsIO/privacytools.io/issues). Code Repository (if applicable): N/A
netlify[bot] commented 2019-08-17 17:50:36 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit c10ece1516

https://deploy-preview-1172--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit c10ece1516e7d4576da1e58c08763b49730b0c14 https://deploy-preview-1172--privacytools-io.netlify.com
blacklight447 (Migrated from github.com) reviewed 2019-08-17 17:53:11 +00:00
blacklight447 (Migrated from github.com) left a comment

wouldn't the word "contacts" be more clear than word "connections"?

wouldn't the word "contacts" be more clear than word "connections"?
nitrohorse commented 2019-08-17 17:56:06 +00:00 (Migrated from github.com)
Copy Link

wouldn't the word "contacts" be more clear than word "connections"?

Yeah good catch! Ideally I think this would be good:

Wire stores some plaintext metadata about its users on their servers. This data includes profile names, profile pictures, usernames, and users' lists of contacts and conversations.

However commas (,) are breaking the tooltip lol so I'll try to figure out what's going on with that.

[edit] looks like commas are used as delimiters in cardv2's labels...

> wouldn't the word "contacts" be more clear than word "connections"? Yeah good catch! Ideally I think this would be good: > Wire stores some plaintext metadata about its users on their servers. This data includes profile names, profile pictures, usernames, and users' lists of contacts and conversations. _However_ commas (`,`) are breaking the tooltip lol so I'll try to figure out what's going on with that. [edit] looks like commas are used as delimiters in cardv2's labels...
Mikaela (Migrated from github.com) reviewed 2019-08-17 17:56:14 +00:00
Mikaela commented 2019-08-17 17:57:48 +00:00 (Migrated from github.com)
Copy Link

wouldn't the word "contacts" be more clear than word "connections"?

I don't think so as that would seem like phone contacts that Wire server doesn't have plaintext access to those.

However commas (,) are breaking the tooltip lol so I'll try to figure out what's going on with that.

This is just a guess, but how about \, ?

> wouldn't the word "contacts" be more clear than word "connections"? I don't think so as that would seem like phone contacts that Wire server doesn't have plaintext access to those. > However commas (,) are breaking the tooltip lol so I'll try to figure out what's going on with that. This is just a guess, but how about `\,` ?
blacklight447 commented 2019-08-17 18:03:25 +00:00 (Migrated from github.com)
Copy Link

wouldn't the word "contacts" be more clear than word "connections"?

Yeah good catch! Ideally I think this would be good:

Wire stores some plaintext metadata about its users on their servers. This data includes profile names, profile pictures, usernames, and users' lists of contacts and conversations.

However commas (,) are breaking the tooltip lol so I'll try to figure out what's going on with that.

if you'd change it to that, then it would be perfect IMO. ill wait for you to make the changes and figure the tooltip issue and approve it after that.

> > wouldn't the word "contacts" be more clear than word "connections"? > > Yeah good catch! Ideally I think this would be good: > > > Wire stores some plaintext metadata about its users on their servers. This data includes profile names, profile pictures, usernames, and users' lists of contacts and conversations. > > _However_ commas (`,`) are breaking the tooltip lol so I'll try to figure out what's going on with that. if you'd change it to that, then it would be perfect IMO. ill wait for you to make the changes and figure the tooltip issue and approve it after that.
nitrohorse commented 2019-08-17 18:05:33 +00:00 (Migrated from github.com)
Copy Link

Hmm @Mikaela is right; they hash contacts but store metadata about user-to-user connections in plaintext I think...

Hmm @Mikaela is right; they hash contacts but store metadata about user-to-user connections in plaintext I think...
nitrohorse commented 2019-08-17 18:07:00 +00:00 (Migrated from github.com)
Copy Link

If you agree to give Wire access to your address book contacts, only hashed phone numbers will be used to match you with other users. The content of your address book is never uploaded to or stored on our servers. -- https://wire.com/en/legal/#privacy

> If you agree to give Wire access to your address book contacts, only hashed phone numbers will be used to match you with other users. The content of your address book is never uploaded to or stored on our servers. -- https://wire.com/en/legal/#privacy
blacklight447 (Migrated from github.com) approved these changes 2019-08-17 18:07:02 +00:00
blacklight447 (Migrated from github.com) left a comment

Good to merge.

Good to merge.
blacklight447 (Migrated from github.com) reviewed 2019-08-17 18:07:45 +00:00
nitrohorse (Migrated from github.com) reviewed 2019-08-17 18:08:00 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-17 18:08:00 +00:00

@JonahAragon is it alright to change the delimiter in labels to a different character other than ,?

@JonahAragon is it alright to change the delimiter in labels to a different character other than `,`?
nitrohorse (Migrated from github.com) reviewed 2019-08-17 18:08:43 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-17 18:08:43 +00:00

Maybe something not used normally like | would be better than ;.

Maybe something not used normally like `|` would be better than `;`.
blacklight447 (Migrated from github.com) reviewed 2019-08-17 18:08:46 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
blacklight447 (Migrated from github.com) commented 2019-08-17 18:08:46 +00:00

I wouldn't see any reason why not.

I wouldn't see any reason why not.
blacklight447 (Migrated from github.com) reviewed 2019-08-17 18:11:23 +00:00
Mikaela (Migrated from github.com) reviewed 2019-08-17 18:26:52 +00:00
_includes/cardv2.html
@ -62,0 +94,4 @@
{% if include.windows != "" %}
<a href="{{ include.windows }}">
<i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i>
</a>
Mikaela (Migrated from github.com) commented 2019-08-17 18:26:48 +00:00

Is this going to break anything else?

Is this going to break anything else?
nitrohorse (Migrated from github.com) reviewed 2019-08-17 18:56:31 +00:00
_includes/cardv2.html
@ -62,0 +94,4 @@
{% if include.windows != "" %}
<a href="{{ include.windows }}">
<i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i>
</a>
nitrohorse (Migrated from github.com) commented 2019-08-17 18:56:31 +00:00

Good catch! I’m going to put the “wip” label on this and verify. 🙏🏼

Good catch! I’m going to put the “wip” label on this and verify. 🙏🏼
jonah reviewed 2019-08-17 18:57:49 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
jonah commented 2019-08-17 18:57:49 +00:00

You can change it to whatever, but you will need to update everything that uses the labels functionality to match. You should also change the badges delimiter to match, since it uses the same syntax as labels.

You can change it to whatever, but you will need to update everything that uses the labels functionality to match. You should also change the badges delimiter to match, since it uses the same syntax as labels.
jonah requested changes 2019-08-17 18:58:40 +00:00
_includes/cardv2.html
@ -62,0 +94,4 @@
{% if include.windows != "" %}
<a href="{{ include.windows }}">
<i class="fab fa-windows fa-2x fa-fw d-inline pr-1"></i>
</a>
jonah commented 2019-08-17 18:58:36 +00:00

Yeah, most likely going to break existing labels. I'd also like to see badges changed to use the same syntax: https://github.com/privacytoolsIO/privacytools.io/pull/1172/files#diff-8f1346aae81a8f63f53e2815d9f6582eR4-R22

Yeah, most likely going to break existing labels. I'd also like to see `badges` changed to use the same syntax: https://github.com/privacytoolsIO/privacytools.io/pull/1172/files#diff-8f1346aae81a8f63f53e2815d9f6582eR4-R22
nitrohorse (Migrated from github.com) reviewed 2019-08-17 19:53:37 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-17 19:53:37 +00:00

Okay, that's a good catch. I'll update the badges delimiter to match + validate this doesn't break anything.

Okay, that's a good catch. I'll update the badges delimiter to match + validate this doesn't break anything.
nitrohorse (Migrated from github.com) reviewed 2019-08-17 23:38:23 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-17 23:38:23 +00:00

Alright, so I went through the repo's code and couldn't find any place where multiple badges or labels are being used in a v2 card aside from Wire. So I think we're fine with making the cardv2 delimiter change without breaking anything.

Alright, so I went through the repo's code and couldn't find any place where multiple badges or labels are being used in a v2 card aside from Wire. So I think we're fine with making the cardv2 delimiter change without breaking anything.
nitrohorse (Migrated from github.com) reviewed 2019-08-17 23:56:18 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-17 23:56:18 +00:00

I've also updated the formatting of cardv2.html to make editing and reading a bit more easier for future contributors.

I've also updated the formatting of `cardv2.html` to make editing and reading a bit more easier for future contributors.
jonah reviewed 2019-08-18 01:01:53 +00:00
_includes/cardv2.html
@ -20,3 +24,3 @@
{% else %}
{{include.title}}
{{ include.title }}
{% endif %}
jonah commented 2019-08-18 01:01:53 +00:00

Maybe Wire was the one I was thinking of, I knew I had seen one with two labels recently lol

Maybe Wire was the one I was thinking of, I knew I had seen one with two labels recently lol
nitrohorse (Migrated from github.com) reviewed 2019-08-18 01:28:39 +00:00
_includes/cardv2.html
@ -20,0 +18,4 @@
> {{text}} {{ help_icon }}
{% else %}
> {{text}}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-18 01:28:39 +00:00

Updated to "|"

Updated to "|"
jonah reviewed 2019-08-18 01:52:10 +00:00
_includes/cardv2.html
@ -20,0 +18,4 @@
> {{text}} {{ help_icon }}
{% else %}
> {{text}}
{% endif %}
jonah commented 2019-08-18 01:52:10 +00:00

I am somewhat surprised that works, seeing as Liquid uses "|"s internally. There's even one in that line in particular 😆

I am somewhat surprised that works, seeing as Liquid uses "|"s internally. There's even one in that line in particular 😆
jonah approved these changes 2019-08-18 01:52:45 +00:00
nitrohorse (Migrated from github.com) reviewed 2019-08-18 02:30:07 +00:00
_includes/cardv2.html
@ -20,0 +18,4 @@
> {{text}} {{ help_icon }}
{% else %}
> {{text}}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-18 02:30:07 +00:00

Oh really? I missed that lol. Great that’s probably a bug I created...

Oh really? I missed that lol. Great that’s probably a bug I created...
jonah reviewed 2019-08-18 02:48:20 +00:00
_includes/cardv2.html
@ -20,0 +18,4 @@
> {{text}} {{ help_icon }}
{% else %}
> {{text}}
{% endif %}
jonah commented 2019-08-18 02:48:20 +00:00

Idk, it appears to function.

Idk, it appears to function.
nitrohorse (Migrated from github.com) reviewed 2019-08-18 04:55:21 +00:00
_includes/cardv2.html
@ -20,0 +18,4 @@
> {{text}} {{ help_icon }}
{% else %}
> {{text}}
{% endif %}
nitrohorse (Migrated from github.com) commented 2019-08-18 04:55:21 +00:00

Ah I must have mis-understood -- I didn't realize we're using a module called Liquid lol! Yeah, then this is alright since the | is within quotes so it's treated simply as a string 😄

Ah I must have mis-understood -- I didn't realize we're using a module called _Liquid_ lol! Yeah, then this is alright since the | is within quotes so it's treated simply as a string :smile:
blacklight447 (Migrated from github.com) approved these changes 2019-08-18 11:18:20 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
jonah
blacklight447
Labels
Clear labels   
🔍🤖 Search Engines

   
approved

approved, waiting for a PR

  
dependencies

Pull requests that update a dependency file

  
duplicate

   
feedback wanted

   
high priority

   
I2P

The Invisible Internet Project (I2P)

  
iOS

   
low priority

   
OS

Operating Systems

  
Self-contained networks

   
Social media

   
stale

A label for stalebot if it gets added

  
streaming

Anything related to media streaming.

  
todo

   
Tor

Anything covering the Tor network

  
WIP

active work in progress, do not merge or PR (yet)!

  
wontfix

Issues or bugs that will not be fixed and/or do not have significant impact on the project.

  
XMPP

Extensible Messaging and Presence Protocol

  
[m]

Matrix protocol

  
₿ cryptocurrency

   
ℹ️ help wanted

   
↔️ file sharing

   
⚙️ web extensions

Browser Extension related issues

  
✨ enhancement

   
❌ software removal

   
💬 discussion

   
🤖 Android

   
🐛 bug

   
💢 conflicting

   
📝 correction

Correction of content on the website

  
🆘 critical

   
📧 email

   
🔒 file encryption

   
📁 file storage

   
🦊 Firefox

Firefox & forks, about:config etc.

  
💻 hardware

   
🌐 hosting

   
🏠 housekeeping

Anything primarily related to site cleanup.

  
🔐 password managers

   
🧰 productivity tools

   
🔎 research required

   
🌐 Social News Aggregators

   
🆕 software suggestion

   
👥 team chat

   
🔒 VPN

Virtual Private Network

  
🌐 website issue

*Technical* issues with the website.

  
🚫 Windows

   
👁️ browsers

   
🖊️ digital notebooks

   
🗄️ DNS

Domain Name System

  
🗨️ instant messaging (im)

   
🇦🇶 translations

Anything covering a translated version of the site

No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1172
No description provided.
Delete Branch "update-wire-metadata-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?