privacyguides/privacytools.io
Archived
1
0
Fork 0
Code Issues 304 Pull Requests 47 Activity

Upgrade cards to v2 and add Dnote #1075

Closed
sungwoncho wants to merge 3 commits from add-dnote-bump-cardv2 into master
pull from: add-dnote-bump-cardv2
merge into: privacyguides:master
Conversation 8 Commits 3 Files Changed 3 +53 -24
sungwoncho commented 2019-08-01 08:09:53 +00:00 (Migrated from github.com)
Copy Link

Description

Resolves: #1074

  • Upgraded the card.html partials to cardv2.html in the Digital Notebook section.
  • Added Dnote
<!-- PLEASE READ OUR [CONTRIBUTING GUIDELINES](https://github.com/privacytoolsIO/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #1074 * Upgraded the `card.html` partials to `cardv2.html` in the Digital Notebook section. * Added Dnote
netlify[bot] commented 2019-08-01 08:10:39 +00:00 (Migrated from github.com)
Copy Link

Deploy preview for privacytools-io ready!

Built with commit d2cc81a41f

https://deploy-preview-1075--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit d2cc81a41f4e9bc8ff48635185fda5caa8589d61 https://deploy-preview-1075--privacytools-io.netlify.com
Mikaela (Migrated from github.com) requested changes 2019-08-01 13:48:17 +00:00
Mikaela (Migrated from github.com) left a comment

Thanks for the contribution, however I am not comfortable merging it until Dnote has been investigated further by the team as this issue and PR are the first times I ever hear of it.

Thanks for the contribution, however I am not comfortable merging it until Dnote has been investigated further by the team as this issue and PR are the first times I ever hear of it.
ghbjklhv1 (Migrated from github.com) reviewed 2019-08-01 18:52:42 +00:00
ghbjklhv1 (Migrated from github.com) left a comment

Aye, so for discussion threads like #1074 generally try to wait about a week since the last comment before making a PR. This way discussions can form.

Besides that, I don't see any major reported issues. However, I generally like to review projects from a free-software standpoint. Your PR doesn't list anything is source_code.md.

I can also not find website source code, which although not required it is helpful.

Aye, so for discussion threads like #1074 generally try to wait about a week since the last comment before making a PR. This way discussions can form. Besides that, I don't see any major reported issues. However, I generally like to review projects from a free-software standpoint. Your PR doesn't list anything is [source_code.md](https://github.com/privacytoolsIO/privacytools.io/blob/master/source_code.md). I can also not find website source code, which although not required it is helpful.
sungwoncho commented 2019-08-01 23:54:53 +00:00 (Migrated from github.com)
Copy Link

@Mikaela @ghbjklhv1 That is a fair point. To that end, I have also started a discussion on the subreddit.

@ghbjklhv1 As you have pointed out, the website source code is not available. However one can easily see that the website is a set of simple static pages with no malicious trackers. Also, thanks for the catch. I have listed the source code in source_code.md in d2cc81a41f.

@Mikaela @ghbjklhv1 That is a fair point. To that end, I have also started a [discussion](https://www.reddit.com/r/privacytoolsIO/comments/ckw78q/suggestion_to_add_dnote_to_the_digital_notebook/) on the subreddit. @ghbjklhv1 As you have pointed out, the website source code is not available. However one can easily see that the website is a set of simple static pages with no malicious trackers. Also, thanks for the catch. I have listed the source code in source_code.md in https://github.com/privacytoolsIO/privacytools.io/pull/1075/commits/d2cc81a41f4e9bc8ff48635185fda5caa8589d61.
ghbjklhv1 commented 2019-08-08 22:15:02 +00:00 (Migrated from github.com)
Copy Link

@sungwoncho It actually isn't static, as it uses JS.
But, I couldn't find any trackers. We should be good there.

Considering your the author, I would like to inform you of LibreJS:
https://www.wikipedia.org/wiki/GNU_LibreJS
Consider supporting the project by licensing your JS.

@sungwoncho It actually isn't static, as it uses JS. But, I couldn't find any trackers. We should be good there. Considering your the author, I would like to inform you of LibreJS: https://www.wikipedia.org/wiki/GNU_LibreJS Consider supporting the project by licensing your JS.
sungwoncho commented 2019-08-09 01:41:22 +00:00 (Migrated from github.com)
Copy Link

@ghbjklhv You're correct. The website does run around 70 lines of JavaScript for dynamic styles. I will consider licensing it in the long run.

@ghbjklhv You're correct. The website does run around 70 lines of JavaScript for dynamic styles. I will consider licensing it in the long run.
jonah commented 2019-08-12 18:06:30 +00:00
Copy Link

privacytools.io is not an advertising platform for new products. We definitely can't merge this in until everything has been addressed at #1074.

privacytools.io is not an advertising platform for new products. We definitely can't merge this in until everything has been addressed at #1074.
sungwoncho commented 2019-08-12 23:49:26 +00:00 (Migrated from github.com)
Copy Link

@JonahAragon I see. Sorry if I came across marketing-y. Could you please clarify:

  • what specifically you would like to see addressed in #1074?
  • what constitutes an advertisement and contribution? This wasn't too clear from the past contributions.

Thanks for maintaining this list.

@JonahAragon I see. Sorry if I came across marketing-y. Could you please clarify: * what specifically you would like to see addressed in #1074? * what constitutes an advertisement and contribution? This wasn't too clear from the past contributions. Thanks for maintaining this list.
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Mikaela
Labels
Clear labels
🔍🤖 Search Engines
approved
approved, waiting for a PR
dependencies
Pull requests that update a dependency file
duplicate
feedback wanted
high priority
I2P
The Invisible Internet Project (I2P)
iOS
low priority
OS
Operating Systems
Self-contained networks
Social media
stale
A label for stalebot if it gets added
streaming
Anything related to media streaming.
todo
Tor
Anything covering the Tor network
WIP
active work in progress, do not merge or PR (yet)!
wontfix
Issues or bugs that will not be fixed and/or do not have significant impact on the project.
XMPP
Extensible Messaging and Presence Protocol
[m]
Matrix protocol
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
Browser Extension related issues
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
Correction of content on the website
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
Firefox & forks, about:config etc.
💻 hardware
🌐 hosting
🏠 housekeeping
Anything primarily related to site cleanup.
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
Virtual Private Network
🌐 website issue
*Technical* issues with the website.
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
Domain Name System
🗨️ instant messaging (im)
🇦🇶 translations
Anything covering a translated version of the site
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jonah
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1075
No description provided.
Delete Branch "add-dnote-bump-cardv2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?