instant-messenger: change Riot privacy conern link to #1049 #1050

jonah · 2019-07-24T22:48:35Z

Mikaela commented

2019-07-24 22:48:35 +00:00

(Migrated from github.com)

No description provided.

👍 2

blacklight447 (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

bookercodes (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

privacytoolsIO (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

c0rdis (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

jxtsai (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

kewde (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

victorhck (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

Vincevrp (Migrated from github.com) reviewed 2019-07-24 22:48:35 +00:00

netlify[bot] commented

2019-07-24 22:49:10 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit eb0221b554

https://deploy-preview-1050--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit eb0221b55492b7bb8c6a51244d6faf03739cee3c https://deploy-preview-1050--privacytools-io.netlify.com

Mikaela (Migrated from github.com) reviewed 2019-07-25 21:37:07 +00:00

_includes/sections/instant-messenger.html

Mikaela (Migrated from github.com) commented

2019-07-25 21:37:01 +00:00

Riot sends a lot of data to matrix.org and vector.im with default settings that aren't trivial to change, also with selfhosted homeservers

TODO: change this part to something actually reflecting the issue, like the most important problems. I think that would be in general metadata like with Wire and the removed messages never getting removed.

> Riot sends a lot of data to matrix.org and vector.im with default settings that aren't trivial to change, also with selfhosted homeservers TODO: change this part to something actually reflecting the issue, like the most important problems. I think that would be in general metadata like with Wire and the removed messages never getting removed.

erciccione commented

2019-07-26 12:43:46 +00:00

(Migrated from github.com)

I tend to be in favour of this PR and against #1047. But i have to catch up on the discussions before giving a fully informed opinion.

Mikaela commented

2019-07-30 12:23:56 +00:00

(Migrated from github.com)

I have removed the description from this PR and the first commit as this appears to be more popular PR and in another commit I fixed the tooltip text that was leftover from the old link.

My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again.

I have removed the description from this PR and the first commit as this appears to be more popular PR and in another commit I fixed the tooltip text that was leftover from the old link. My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again.

👍 1

nitrohorse (Migrated from github.com) requested changes 2019-07-31 05:47:07 +00:00

nitrohorse (Migrated from github.com) left a comment

My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again.

I agree. Based on the issues listed in https://github.com/privacytoolsIO/privacytools.io/issues/1049 I think we should remove Riot for now. We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice.

> My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again. I agree. Based on the issues listed in https://github.com/privacytoolsIO/privacytools.io/issues/1049 I think we should remove Riot for now. We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice.

Perelandra0x309 commented

2019-07-31 10:19:00 +00:00

(Migrated from github.com)

You are missing a closing element on your second anchor link:
<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049"<span

You are missing a closing element on your second anchor link: <a href=\"https://github.com/privacytoolsIO/privacytools.io/issues/1049\"<span

Mikaela commented

2019-07-31 11:25:57 +00:00

(Migrated from github.com)

I agree. Based on the issues listed in #1049 I think we should remove Riot for now.

Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to https://github.com/privacytoolsIO/privacytools.io/pull/1047 ?

We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice.

I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by https://github.com/privacytoolsIO/privacytools.io/issues/1065.

You are missing a closing element on your second anchor link:
<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049\"<span

Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :(

> I agree. Based on the issues listed in #1049 I think we should remove Riot for now. Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to https://github.com/privacytoolsIO/privacytools.io/pull/1047 ? > We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice. I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by https://github.com/privacytoolsIO/privacytools.io/issues/1065. > You are missing a closing element on your second anchor link: > `<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049\"<span` Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :(

nitrohorse commented

2019-07-31 15:06:11 +00:00

(Migrated from github.com)

Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to #1047 ?

Yeah 👍🏼 I’ll make an approving review of 1047.

I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by #1065.

Ah I see, that makes sense.

> Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to #1047 ? Yeah 👍🏼 I’ll make an approving review of 1047. > I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by #1065. Ah I see, that makes sense.

Perelandra0x309 commented

2019-07-31 16:28:13 +00:00

(Migrated from github.com)

Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :(

I think it's actually an inherited error from the existing version, but the html should be this:

<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049\"><span

Add a ">" before the "<span" so it is valid HTML.

> Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :( I think it's actually an inherited error from the existing version, but the html should be this: ` <a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049\"><span` Add a ">" before the "<span" so it is valid HTML.

👍 1

jonah requested changes 2019-08-02 02:17:09 +00:00

jonah left a comment

I would be fine merging this immediately if the syntax issues mentioned here were fixed, although I'm equally fine with not fixing this if we were to merge #1047 instead.

_includes/sections/instant-messenger.html

jonah commented

2019-08-02 02:15:46 +00:00

description="Riot.im is a decentralized free-software chatting application based on the <a href\"https://matrix.org/\">Matrix</a> protocol, a recent open protocol for real-time communication offering E2E encryption. It can bridge other communications via others protocols such as IRC too. <a href=\"https://github.com/vector-im/riot-web/issues/6779\"><span class=\"badge badge-warning\" data-toggle=\"tooltip\" title=\"The end-to-end encryption is currently in beta and the mobile client states 'End-to-end encryption is in beta and may not be reliable. You should not yet trust it to secure data.'\">Experimental <i class=\"far fa-question-circle\"></i></a></span> <a href=\"https://github.com/privacytoolsIO/privacytools.io/issues/1049\"><span class=\"badge badge-danger\" data-toggle=\"tooltip\" title=\"Riot has a lot of privacy issues that are tracked in our metaissue #1049.\">Privacy concerns</span></a>"

```suggestion description="Riot.im is a decentralized free-software chatting application based on the <a href\"https://matrix.org/\">Matrix</a> protocol, a recent open protocol for real-time communication offering E2E encryption. It can bridge other communications via others protocols such as IRC too. <a href=\"https://github.com/vector-im/riot-web/issues/6779\"><span class=\"badge badge-warning\" data-toggle=\"tooltip\" title=\"The end-to-end encryption is currently in beta and the mobile client states 'End-to-end encryption is in beta and may not be reliable. You should not yet trust it to secure data.'\">Experimental </a> <a href=\"https://github.com/privacytoolsIO/privacytools.io/issues/1049\">Privacy concerns</a>" ```

This repo is archived. You cannot comment on pull requests.

No Reviewers

jonah

kewde

victorhck

blacklight447

bookercodes

privacytoolsIO

jxtsai

c0rdis

Vincevrp

nitrohorse