instant-messenger: change Riot privacy conern link to #1049 #1050
No reviewers
Labels
No Label
🔍🤖 Search Engines
approved
dependencies
duplicate
feedback wanted
high priority
I2P
iOS
low priority
OS
Self-contained networks
Social media
stale
streaming
todo
Tor
WIP
wontfix
XMPP
[m]
₿ cryptocurrency
ℹ️ help wanted
↔️ file sharing
⚙️ web extensions
✨ enhancement
❌ software removal
💬 discussion
🤖 Android
🐛 bug
💢 conflicting
📝 correction
🆘 critical
📧 email
🔒 file encryption
📁 file storage
🦊 Firefox
💻 hardware
🌐 hosting
🏠 housekeeping
🔐 password managers
🧰 productivity tools
🔎 research required
🌐 Social News Aggregators
🆕 software suggestion
👥 team chat
🔒 VPN
🌐 website issue
🚫 Windows
👁️ browsers
🖊️ digital notebooks
🗄️ DNS
🗨️ instant messaging (im)
🇦🇶 translations
No Milestone
No Assignees
1 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: privacyguides/privacytools.io#1050
Loading…
Reference in New Issue
No description provided.
Delete Branch "riot-tracking"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Deploy preview for privacytools-io ready!
Built with commit
eb0221b554
https://deploy-preview-1050--privacytools-io.netlify.com
TODO: change this part to something actually reflecting the issue, like the most important problems. I think that would be in general metadata like with Wire and the removed messages never getting removed.
I tend to be in favour of this PR and against #1047. But i have to catch up on the discussions before giving a fully informed opinion.
I have removed the description from this PR and the first commit as this appears to be more popular PR and in another commit I fixed the tooltip text that was leftover from the old link.
My personal preference would still be delisting Riot until they have gotten their privacy issues resolved and then listing them again.
I agree. Based on the issues listed in https://github.com/privacytoolsIO/privacytools.io/issues/1049 I think we should remove Riot for now. We could also bump it to the "Worth Mentioning" section with the "privacy conerns" tooltip warning users but that wouldn’t be my first choice.
You are missing a closing element on your second anchor link:
<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049"<span
Do I understand correctly that you are requesting changes to block merging of this and will be giving an approving review to https://github.com/privacytoolsIO/privacytools.io/pull/1047 ?
I disagree as Riot is not an instant messenger for people, but teams, and would be blocked by https://github.com/privacytoolsIO/privacytools.io/issues/1065.
Could you clarify what is wrong in the file and what should it be instead? I looked at it a few times, but I don't spot the issue. I find the code too confusing :(
Yeah 👍🏼 I’ll make an approving review of 1047.
Ah I see, that makes sense.
I think it's actually an inherited error from the existing version, but the html should be this:
<a href="https://github.com/privacytoolsIO/privacytools.io/issues/1049\"><span
Add a ">" before the "<span" so it is valid HTML.
I would be fine merging this immediately if the syntax issues mentioned here were fixed, although I'm equally fine with not fixing this if we were to merge #1047 instead.