browser-tweaks: note privacy.trackingprotection.fingerprinting|cryptomining is FF67+ #1012

jonah · 2019-07-04T08:53:51Z

Mikaela commented

2019-07-04 08:53:51 +00:00

(Migrated from github.com)

Resolves: #1010

jonah reviewed 2019-07-04 08:53:51 +00:00

blacklight447 (Migrated from github.com) reviewed 2019-07-04 08:53:51 +00:00

netlify[bot] commented

2019-07-04 08:54:31 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit af7aaf8403

https://deploy-preview-1012--privacytools-io.netlify.com

Deploy preview for *privacytools-io* ready! Built with commit af7aaf84036f1095619dcb18134097dc52d1d6bd https://deploy-preview-1012--privacytools-io.netlify.com

Mikaela commented

2019-07-04 14:49:21 +00:00

(Migrated from github.com)

@Thorin-Oakenpants I could use a review here :)

Thorin-Oakenpants commented

2019-07-04 14:57:18 +00:00

(Migrated from github.com)

I don't have the ability to review anything so you can merge, if that's what you meant, but the changes look good to me :)

👍 1

Mikaela commented

2019-07-04 15:02:20 +00:00

(Migrated from github.com)

the changes look good to me :)

This is what I meant, I was afraid there were more notices I was forgetting to add. Thanks

I don't have the ability to review anything

I think GitHub would offer you the review buttons in the files tab on top right corner, even if you wouldn't have permission to merge https://github.com/privacytoolsIO/privacytools.io/pull/1012/files

> the changes look good to me :) This is what I meant, I was afraid there were more notices I was forgetting to add. Thanks > I don't have the ability to review anything I think GitHub would offer you the review buttons in the files tab on top right corner, even if you wouldn't have permission to merge https://github.com/privacytoolsIO/privacytools.io/pull/1012/files

Thorin-Oakenpants (Migrated from github.com) approved these changes 2019-07-04 15:19:46 +00:00

Thorin-Oakenpants (Migrated from github.com) left a comment

Ahh, so that's where the review button was. Looks good to me.

Mikaela commented

2019-07-08 17:01:16 +00:00

(Migrated from github.com)

This is a minor change and there is an approving review, so I am going to merge this.

Mikaela commented

2019-07-08 17:10:01 +00:00

(Migrated from github.com)

└┌(%:~/src/github.com/privacytoolsio/privacytools.io)┌- git push origin master
DNS lookup error: data does not exist
Authenticated to github.com ([140.82.118.3]:22).
warning: not sending a push certificate since the receiving end does not support --signed push
Enumerating objects: 28, done.
Counting objects: 100% (26/26), done.
Delta compression using up to 4 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (18/18), 4.67 KiB | 2.33 MiB/s, done.
Total 18 (delta 14), reused 10 (delta 8)
remote: Resolving deltas: 100% (14/14), completed with 8 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 2 of 2 required status checks are expected. At least 1 approving review is required by reviewers with write access.
Transferred: sent 7460, received 3936 bytes, in 2.2 seconds
Bytes per second: sent 3401.5, received 1794.7
To github.com:privacytoolsIO/privacytools.io.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:privacytoolsIO/privacytools.io.git'

or maybe not.

``` └┌(%:~/src/github.com/privacytoolsio/privacytools.io)┌- git push origin master DNS lookup error: data does not exist Authenticated to github.com ([140.82.118.3]:22). warning: not sending a push certificate since the receiving end does not support --signed push Enumerating objects: 28, done. Counting objects: 100% (26/26), done. Delta compression using up to 4 threads Compressing objects: 100% (10/10), done. Writing objects: 100% (18/18), 4.67 KiB | 2.33 MiB/s, done. Total 18 (delta 14), reused 10 (delta 8) remote: Resolving deltas: 100% (14/14), completed with 8 local objects. remote: error: GH006: Protected branch update failed for refs/heads/master. remote: error: 2 of 2 required status checks are expected. At least 1 approving review is required by reviewers with write access. Transferred: sent 7460, received 3936 bytes, in 2.2 seconds Bytes per second: sent 3401.5, received 1794.7 To github.com:privacytoolsIO/privacytools.io.git ! [remote rejected] master -> master (protected branch hook declined) error: failed to push some refs to 'git@github.com:privacytoolsIO/privacytools.io.git' ``` or maybe not.

privacytoolsIO (Migrated from github.com) approved these changes 2019-07-09 11:43:35 +00:00

This repo is archived. You cannot comment on pull requests.

No Reviewers

jonah

blacklight447

Thorin-Oakenpants

privacytoolsIO

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1012