WIP: Adding accessibility features #2359

Draft
CristianAUnisa wants to merge 2 commits from CristianAUnisa/master into master
CristianAUnisa commented 2021-06-26 18:29:59 +00:00 (Migrated from github.com)

Made the theme button toggable by keyboard
Added aria-label to many without any text (usually, they contains Font Awesome icons)
Added aria-hidden whenever necessary
Labelled the "Copy URL and Description" contained in footer
Added an hidden label for the menu toggle for mobile accessibility
Changed some colors to meet the Color Contrast AA level: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

Description

Resolves: #none

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

Made the theme button toggable by keyboard Added aria-label to many <a> without any text (usually, they contains Font Awesome icons) Added aria-hidden whenever necessary Labelled the "Copy URL and Description" contained in footer Added an hidden label for the menu toggle for mobile accessibility Changed some colors to meet the Color Contrast AA level: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html <!-- PLEASE READ OUR CODE OF CONDUCT (https://wiki.privacytools.io/view/PrivacyTools:Code_of_Conduct) AND CONTRIBUTING GUIDELINES (https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md) BEFORE SUBMITTING --> ## Description Resolves: #none <!-- A link to the (discussion) issue resolved by this pull request. There must be a discussion issue here at GitHub, before a pull request of software/service suggestion can be considered for merging. --> #### Check List <!-- Please add an x in each box below, like so: [x] --> - [x] I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging. - [x] I have read and understand [the contributing guidelines](https://github.com/privacytools/privacytools.io/blob/master/.github/CONTRIBUTING.md). - [x] The project is [Free Libre](https://en.wikipedia.org/wiki/Free_software) and/or [Open Source](https://en.wikipedia.org/wiki/Open-source_software) Software * Netlify preview for the mainly edited page: https://sleepy-heyrovsky-6a1470.netlify.app/ * Code repository of the project (if applicable): https://github.com/CristianAUnisa/privacytools.io/
CristianAUnisa commented 2021-06-27 00:24:46 +00:00 (Migrated from github.com)

There's a line of code you can find there at line 13 that's not showing when you toggle the menu. Should it be deleted?

<div class="menu w-100">
    <div id="nav-left" class="position-relative flex-col">
    <a class="nav-anchor" href="/"> <!-- This one right here -->
        <span id="nav-home" class="fas fa-home fa-fw"></span>
    </a>
There's a line of code [you can find there](https://github.com/privacytools/privacytools.io/blob/master/_includes/nav.html]) at line 13 that's not showing when you toggle the menu. Should it be deleted? ``` <div class="menu w-100"> <div id="nav-left" class="position-relative flex-col"> <a class="nav-anchor" href="/"> <!-- This one right here --> <span id="nav-home" class="fas fa-home fa-fw"></span> </a> ```
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#2359
No description provided.