/

privacytools.io

Archived

Change PC Operating Systems to Introductory Operating Systems #1995

Merged

dngray merged 2 commits from pr-introductory_os into master

2020-07-27 15:29:16 +00:00

dngray commented

2020-07-17 14:45:57 +00:00

(Migrated from github.com)

https://deploy-preview-1995--privacytools-io.netlify.app/operating-systems/#os

https://deploy-preview-1995--privacytools-io.netlify.app/operating-systems/#os

jonah commented

2020-07-17 14:59:20 +00:00

We should change the navbar menu and add an entry there for the advanced section as well so it matches the page.

We should change the navbar menu and add an entry there for the advanced section as well so it matches the page.

Mikaela commented

2020-07-18 19:21:44 +00:00

(Migrated from github.com)

What does Introductory mean in this context?

What does Introductory mean in this context?

dngray commented

2020-07-18 19:59:02 +00:00

(Migrated from github.com)

What does Introductory mean in this context?

A place where you should start.

> What does Introductory mean in this context? A place where you should start.

dngray commented

2020-07-18 21:16:17 +00:00

(Migrated from github.com)

We should change the navbar menu and add an entry there for the advanced section as well so it matches the page.

I decided we don't really need to link to introductory/advanced as they're both "PC OS", so just link to the main page.

If we did add those two separate subcategories to the nav.html, we'd need to think of suitable icons for each.

> We should change the navbar menu and add an entry there for the advanced section as well so it matches the page. I decided we don't really need to link to introductory/advanced as they're both "PC OS", so just link to the main page. If we did add those two separate subcategories to the nav.html, we'd need to think of suitable icons for each.

jonah reviewed 2020-07-19 23:47:35 +00:00

_includes/nav.html

						
				@ -88,3 +88,3 @@

				          <span class="nav-dropdown">

				            <a class="dropdown-item" href="/operating-systems/#os"><span class="fas fa-th-large fa-fw"></span> PC OS</a>

				            <a class="dropdown-item" href="/operating-systems"><span class="fas fa-th-large fa-fw"></span> PC OS</a>

				            <a class="dropdown-item" href="/operating-systems/#tor_os"><span class="ptio-tor"></span> Tor focused distributions</a>

jonah commented

2020-07-19 23:47:29 +00:00

What is the reason for this change?

What is the reason for this change?

jonah approved these changes 2020-07-19 23:49:31 +00:00

jonah left a comment

Nvm, can't read properly on my phone. I'm not entirely sure how I feel about the navbar links not bringing you directly to a section... but I guess it makes sense to me either way.

Nvm, can't read properly on my phone. I'm not entirely sure how I feel about the navbar links not bringing you directly to a section... but I guess it makes sense to me either way.

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

🔍🤖 Search Engines

feedback wanted

Self-contained networks

₿ cryptocurrency

ℹ️ help wanted

↔️ file sharing

⚙️ web extensions

✨ enhancement

❌ software removal

💬 discussion

💢 conflicting

📝 correction

🔒 file encryption

📁 file storage

🏠 housekeeping

🔐 password managers

🧰 productivity tools

🔎 research required

🌐 Social News Aggregators

🆕 software suggestion

🌐 website issue

👁️ browsers

🖊️ digital notebooks

🗨️ instant messaging (im)

🇦🇶 translations

No Milestone

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1995

No description provided.