Use cdn.privacytools.io for static resources #1936

jonah · 2020-05-27T04:09:59Z

jonah commented

2020-05-27 04:09:59 +00:00

You'd have to build locally with JEKYLL_ENV=production bundle exec jekyll serve or JEKYLL_ENV=production bundle exec jekyll build to see the changes yourself, since the CDN URL should not be used in a development environment like Netlify

You'd have to build locally with `JEKYLL_ENV=production bundle exec jekyll serve` or `JEKYLL_ENV=production bundle exec jekyll build` to see the changes yourself, since the CDN URL should not be used in a development environment like Netlify

privacytoolsIO (Migrated from github.com) reviewed 2020-05-27 04:09:59 +00:00

nitrohorse commented

2020-05-27 05:38:24 +00:00

(Migrated from github.com)

Nice, could we also update the Readme build instructions to include this PR’s description? Helpful for future reference.

blacklight447 commented

2020-05-27 12:32:13 +00:00

(Migrated from github.com)

Why would we need a CDN though?

👍 1

jonah commented

2020-05-29 02:36:00 +00:00

could we also update the Readme build instructions to include this PR’s description?

We could, although it doesn't make sense to load from the CDN in development. Because if you add a new image or whatever to your local fork, the CDN won't display it obviously, it will only load assets on the webserver. So really you'd only set JEKYLL_ENV=production when building the live website, or if you just wanted to see the CDN in action for some reason (like you might with this specific PR). But otherwise I'm not sure it's particularly helpful information.

> could we also update the Readme build instructions to include this PR’s description? We *could*, although it doesn't make sense to load from the CDN in development. Because if you add a new image or whatever to your local fork, the CDN won't display it obviously, it will only load assets on the webserver. So really you'd only set `JEKYLL_ENV=production` when building the live website, or if you just wanted to see the CDN in action for some reason (like you might with this specific PR). But otherwise I'm not sure it's particularly helpful information.

nitrohorse commented

2020-05-29 22:11:43 +00:00

(Migrated from github.com)

Ah that makes sense, okay, I was mistaken; we can leave the Readme as-is.

nitrohorse (Migrated from github.com) approved these changes 2020-05-29 22:12:23 +00:00

blacklight447 (Migrated from github.com) approved these changes 2020-06-03 20:44:09 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: privacyguides/privacytools.io#1936