Add additional VPN resource links #1891

jonah · 2020-05-06T03:00:20Z

nitrohorse commented

2020-05-06 03:00:20 +00:00

(Migrated from github.com)

Description

Refactor of https://github.com/privacytoolsIO/privacytools.io/pull/1805

Netlify

https://deploy-preview-1891--privacytools-io.netlify.app/providers/vpn/#related-vpn-info

## Description Refactor of https://github.com/privacytoolsIO/privacytools.io/pull/1805 ## Netlify https://deploy-preview-1891--privacytools-io.netlify.app/providers/vpn/#related-vpn-info

netlify[bot] commented

2020-05-06 03:02:27 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 78ad967e29

https://deploy-preview-1891--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 78ad967e2985df5b88aae55b59db3826d86dafde https://deploy-preview-1891--privacytools-io.netlify.app

netlify[bot] commented

2020-05-06 03:04:32 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit 0047f7a128

https://deploy-preview-1891--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit 0047f7a128fcad0fb02ae0ea9115804a341c6a35 https://deploy-preview-1891--privacytools-io.netlify.app

netlify[bot] commented

2020-05-06 03:05:06 +00:00

(Migrated from github.com)

Deploy preview for privacytools-io ready!

Built with commit c15a5dce47

https://deploy-preview-1891--privacytools-io.netlify.app

Deploy preview for *privacytools-io* ready! Built with commit c15a5dce47703b8eee3a747fd2750eb3216c062f https://deploy-preview-1891--privacytools-io.netlify.app

jonah reviewed 2020-05-06 03:17:14 +00:00

pages/providers/vpn.html

						
				@ -238,0 +231,4 @@

				          <li>

				            <a href="https://www.top10vpn.com/free-vpn-app-investigation/">Free VPN App Investigation</a>

				            <span class="badge badge-warning" data-toggle="tooltip" title="This site has affiliate based recommendations">

				              <a href="https://blog.privacytools.io/the-trouble-with-vpn-and-privacy-reviews"/>Warning</a>

jonah commented

2020-05-06 03:17:13 +00:00

This is very large. Feels like it could be col-lg-6 col-12 with a "Related Videos" header.

        <div class="col-lg-6 col-12">
        <h3>Related Videos</h3>
          <a href="https://invidio.us/watch?v=WVDQEoe6ZWY" target="_blank">
            <img
              src="/assets/img/png/3rd-party/this-video-is-sponsored-by-vpn.png"
              class="img-fluid float-left mr-3"
              alt="This Video Is Sponsored By ███ VPN">
          </a>
        </div>

This is very large. Feels like it could be `col-lg-6 col-12` with a "Related Videos" header. ```suggestion <div class="col-lg-6 col-12"> <h3>Related Videos</h3> <a href="https://invidio.us/watch?v=WVDQEoe6ZWY" target="_blank"> <img src="/assets/img/png/3rd-party/this-video-is-sponsored-by-vpn.png" class="img-fluid float-left mr-3" alt="This Video Is Sponsored By ███ VPN"> </a> </div> ```

dngray (Migrated from github.com) approved these changes 2020-05-06 04:14:42 +00:00

dngray (Migrated from github.com) reviewed 2020-05-06 04:15:39 +00:00

dngray (Migrated from github.com) left a comment

I like how this looks. The one column table looks better (we only had one link in the other column and it looked weird.

Also I think I prefer the video tile smaller like you've got it now, that way if we add another one in the future it can go side-by-side.

I like how this looks. The one column table looks better (we only had one link in the other column and it looked weird. Also I think I prefer the video tile smaller like you've got it now, that way if we add another one in the future it can go side-by-side.

dngray (Migrated from github.com) reviewed 2020-05-06 04:18:42 +00:00

dawidpotocki (Migrated from github.com) reviewed 2020-05-06 06:44:32 +00:00

dawidpotocki (Migrated from github.com) left a comment

Uses non-standard image resolution (1050x590px), please use 1280x720px
Image is in wrong directory, it should be in /assets/img/png/layout/

* Uses non-standard image resolution (1050x590px), please use 1280x720px * Image is in wrong directory, it should be in /assets/img/png/layout/

nitrohorse commented

2020-05-06 06:47:29 +00:00

(Migrated from github.com)

* Uses non-standard image resolution (1050x590px), please use 1280x720px

Based on our CSS, I see it'll only ever be 630px wide which is what I resized it to in the latest commit if that's cool?

> * Uses non-standard image resolution (1050x590px), please use 1280x720px Based on our CSS, I see it'll only ever be 630px wide which is what I resized it to in the latest commit if that's cool?

dngray (Migrated from github.com) approved these changes 2020-05-07 08:44:18 +00:00

jonah approved these changes 2020-05-08 03:39:09 +00:00

danarel (Migrated from github.com) approved these changes 2020-05-08 03:39:55 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

dngray

danarel